You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by bu...@apache.org on 2007/06/05 11:02:54 UTC

DO NOT REPLY [Bug 42582] New: - Patch to r541884, adding pretty JSON rendering to 'Response Data' tab of View Results Tree

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42582>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42582

           Summary: Patch to r541884, adding pretty JSON rendering to
                    'Response Data' tab of View Results Tree
           Product: JMeter
           Version: 2.2
          Platform: Other
        OS/Version: All
            Status: NEW
          Keywords: PatchAvailable
          Severity: enhancement
          Priority: P2
         Component: Main
        AssignedTo: jmeter-dev@jakarta.apache.org
        ReportedBy: tim-asf@baverstock.org.uk


Hi, I found it annoying to have to copy/paste JSON response data into a Perl
script to pretty-print it, so I developed a patch adding a 'Render JSON' button
alongside the 'Render XML' one, which I'll attach once I've submitted this.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org


DO NOT REPLY [Bug 42582] - Patch to r541884, adding pretty JSON rendering to 'Response Data' tab of View Results Tree

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42582>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42582


sebb@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




------- Additional Comments From sebb@apache.org  2007-06-10 11:08 -------
Thanks, applied to SVN in r545917.

BTW, the patch was a bit awkward to apply, as it was not in unified diff 
format.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org


DO NOT REPLY [Bug 42582] - Patch to r541884, adding pretty JSON rendering to 'Response Data' tab of View Results Tree

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42582>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42582





------- Additional Comments From tim-asf@baverstock.org.uk  2007-06-06 16:54 -------
Uh.. well, it would if the " character weren't quoted. Try this:
http://geocities.com/tim_baverstock/

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org


DO NOT REPLY [Bug 42582] - Patch to r541884, adding pretty JSON rendering to 'Response Data' tab of View Results Tree

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42582>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42582





------- Additional Comments From tim-asf@baverstock.org.uk  2007-06-06 06:07 -------
Created an attachment (id=20320)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=20320&action=view)
Patch to add pretty JSON rendering to 'Response Data' tab of 'View Results
Tree' node.

I've updated the documentation, but as with the previous Google contribution,
the associated images will need to be updated.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org


DO NOT REPLY [Bug 42582] - Patch to r541884, adding pretty JSON rendering to 'Response Data' tab of View Results Tree

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42582>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42582





------- Additional Comments From sebb@apache.org  2007-06-06 11:42 -------
Thanks. Are there any public sites that I can test it on?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org


DO NOT REPLY [Bug 42582] - Patch to r541884, adding pretty JSON rendering to 'Response Data' tab of View Results Tree

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42582>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42582





------- Additional Comments From sebb@apache.org  2007-06-14 08:13 -------
(In reply to comment #7)
> (In reply to comment #6)
> > BTW, the patch was a bit awkward to apply, as it was not in unified diff 
> > format.
> Really? I'm sorry about that: I generated it with 'diff -u', which I thought 
was
> right. Thanks for bearing with it!

I see now - the patch is in unified diff, but the original file name is wrong.

Or perhaps Eclipse is just being picky - I've noticed some other patches that 
looked OK did not get applied in their entirety.

S.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org


DO NOT REPLY [Bug 42582] - Patch to r541884, adding pretty JSON rendering to 'Response Data' tab of View Results Tree

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42582>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42582





------- Additional Comments From tim-asf@baverstock.org.uk  2007-06-05 03:33 -------
Sorry, I wrote this at work, and forgot I need to run the patch through Google's
Open Source liaison people. Doing that now.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org


DO NOT REPLY [Bug 42582] - Patch to r541884, adding pretty JSON rendering to 'Response Data' tab of View Results Tree

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42582>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42582





------- Additional Comments From tim-asf@baverstock.org.uk  2007-06-06 16:39 -------
You don't need a real JSON site: Just point it at a page with some JSON in it.
Like... this very page once the following's been posted! :)

It'll parse anything looking even vaguely like JSON, including JavaScript with
some embedded. There's some example JSON at http://www.json.org/example.html but
it's been pretty-printed already... here's the collapsed version:

{"glossary": {"title":"example glossary","GlossDiv": {"title": "S","GlossList":
{"GlossEntry": {"ID": "SGML","SortAs": "SGML","GlossTerm": "Standard Generalized
Markup Language","Acronym": "SGML","Abbrev": "ISO 8879:1986","GlossDef":
{"para": "A meta-markup language, used to create markup languages such as
DocBook.","GlossSeeAlso": ["GML", "XML"]},"GlossSee": "markup"}}}}
}

Cheers.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org


DO NOT REPLY [Bug 42582] - Patch to r541884, adding pretty JSON rendering to 'Response Data' tab of View Results Tree

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42582>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42582





------- Additional Comments From tim-asf@baverstock.org.uk  2007-06-11 06:23 -------
(In reply to comment #6)
> Thanks, applied to SVN in r545917.

Great!

> BTW, the patch was a bit awkward to apply, as it was not in unified diff 
> format.

Really? I'm sorry about that: I generated it with 'diff -u', which I thought was
right. Thanks for bearing with it!

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org