You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "angela (JIRA)" <ji...@apache.org> on 2011/02/09 18:53:57 UTC

[jira] Created: (JCR-2886) Add SessionImpl#isAdminOrSystem

Add SessionImpl#isAdminOrSystem
-------------------------------

                 Key: JCR-2886
                 URL: https://issues.apache.org/jira/browse/JCR-2886
             Project: Jackrabbit Content Repository
          Issue Type: Improvement
            Reporter: angela
            Assignee: angela
            Priority: Minor


we have several places in jackrabbit-core where we need to find out if the executing session is either a SystemSession or corresponds to the admin user.
currently the same code (analysing the sessions subject) is copied throughout jackrabbit-core. i would like to replace that by a helper method on SessionImpl.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Resolved: (JCR-2886) Add SessionImpl#isAdminOrSystem

Posted by "angela (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

angela resolved JCR-2886.
-------------------------

    Resolution: Fixed

while working on this i felt that it was more appropriate to distinguish the two 
cases and therefore added isAdmin() and isSystem().

the implementation of the latter in SessionImpl still has a TODO as we may have
both SessionImpl and SystemSession instances that must be treated as 'system'
in order to be compatible with the previous code.
however, i feel that at some point we should clear this up. the issue is due to the
fact that SystemSession doesn't have its own createSession method.

> Add SessionImpl#isAdminOrSystem
> -------------------------------
>
>                 Key: JCR-2886
>                 URL: https://issues.apache.org/jira/browse/JCR-2886
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core, security
>            Reporter: angela
>            Assignee: angela
>            Priority: Minor
>             Fix For: 2.3.0
>
>
> we have several places in jackrabbit-core where we need to find out if the executing session is either a SystemSession or corresponds to the admin user.
> currently the same code (analysing the sessions subject) is copied throughout jackrabbit-core. i would like to replace that by a helper method on SessionImpl.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (JCR-2886) Add SessionImpl#isAdminOrSystem

Posted by "angela (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

angela updated JCR-2886:
------------------------

      Component/s: security
                   jackrabbit-core
    Fix Version/s: 2.3.0

> Add SessionImpl#isAdminOrSystem
> -------------------------------
>
>                 Key: JCR-2886
>                 URL: https://issues.apache.org/jira/browse/JCR-2886
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core, security
>            Reporter: angela
>            Assignee: angela
>            Priority: Minor
>             Fix For: 2.3.0
>
>
> we have several places in jackrabbit-core where we need to find out if the executing session is either a SystemSession or corresponds to the admin user.
> currently the same code (analysing the sessions subject) is copied throughout jackrabbit-core. i would like to replace that by a helper method on SessionImpl.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira