[GitHub] [spark] dcoliversun commented on a change in pull request #35886: [SPARK-38582][K8S] Introduce buildEnvVarsWithKV and buildEnvVarsWithFieldRef for KubernetesUtils to eliminate duplicate code pattern

[GitBox <gi...@apache.org>]

dcoliversun commented on a change in pull request #35886:
URL: https://github.com/apache/spark/pull/35886#discussion_r828907240



##########
File path: resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/KubernetesUtilsSuite.scala
##########
@@ -127,4 +127,34 @@ class KubernetesUtilsSuite extends SparkFunSuite with PrivateMethodTester {
       }
     }
   }
+

Review comment:
       Already have. Please check
   https://github.com/apache/spark/blob/46ccc22ee40c780f6ae4a9af4562fb1ad10ccd9f/resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStepSuite.scala#L51
   
   https://github.com/apache/spark/blob/46ccc22ee40c780f6ae4a9af4562fb1ad10ccd9f/resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStepSuite.scala#L506-L535




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org