You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/07/27 18:58:41 UTC
[GitHub] [superset] michael-s-molina opened a new pull request #15915: chore: Moves the SQL Lab menu before Charts
michael-s-molina opened a new pull request #15915:
URL: https://github.com/apache/superset/pull/15915
### SUMMARY
Moves the SQL Lab menu before Charts.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<img width="495" alt="Screen Shot 2021-07-27 at 1 53 24 PM" src="https://user-images.githubusercontent.com/70410625/127211943-d3dfe888-f62e-4fe4-896c-6e035e2aac06.png">
<img width="491" alt="Screen Shot 2021-07-27 at 3 56 43 PM" src="https://user-images.githubusercontent.com/70410625/127211964-30b3ab79-79c8-46ed-8ca6-3d796c1e3d77.png">
@junlincc @rusackas
### TESTING INSTRUCTIONS
- Login to Superset
- Check the main menu
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #15915: [DISCUSS] - Moves the SQL Lab menu before Charts
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #15915:
URL: https://github.com/apache/superset/pull/15915#issuecomment-888335424
@junlincc @ktmud Thanks for your comments.
@junlincc @ktmud @srinify @john-bodley @graceguo-supercat
Can we proceed and make the change to follow [SIP-34](https://github.com/apache/superset/issues/8976) order?
Dashboards -> Charts -> SQL Lab -> Data
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #15915: [DISCUSS] - Moves the SQL Lab menu before Charts
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #15915:
URL: https://github.com/apache/superset/pull/15915#issuecomment-887867118
Personally I think it'd make more sense to order by usage than workflow:
1. **Most users don't need the full workflow:** even for Data Scientists, they seldom work through the whole workflow in one go---IMO having the full workflow in the right order is less important than having easiest access to the most used steps in the workflow.
2. **Different users have different workflows:** "Data -> SQL Lab -> Chart -> Dashboard" is just _one_ workflow of _some_ Data Scientists. Some more frequent workflows are:
1. "Chart -> Dashboard"---for Data Scientists who only use pre-configured and shared datasets (which is probably something Superset should encourage), in which case one may argue the Data tab should be hidden into "Settings" (like [Redash](https://redash.io/help/user-guide/getting-started) does).
2. "Dashboard -> Chart -> SQL Lab"---for dashboard viewers who are also interested in how the underlying data were computed. This is somewhat similar to Looker's "Browse -> Explore -> Develop".
3. **The order is less important in the main menu:** while having the right order is important in some places, it's not like users can return to previous steps by clicking on the main menu.
4. **Home page already orders content by usage:** it's better be consistent than not.
I went back and checked, [SIP-34](https://github.com/apache/superset/issues/8976) actually re-arranged the menu by usage order (Dashboards -> Charts -> SQL Lab -> Data). There must be some reason behind that---hope it was in line with what I described above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #15915: [DISCUSS] - Moves the SQL Lab menu before Charts
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #15915:
URL: https://github.com/apache/superset/pull/15915#issuecomment-888505351
Before we go, I'd also like to vent out something that has been brewing in my mind for a while. I've noticed many times that whenever there is a disagreement in UX changes, there is the argument that "we are doing this for the broader Superset community/the majority of Superset users", or the so-called "business users". To me, this argument feels counterproductive.
As shown above, there can be many more substantive arguments about either side of each choice. Even if you made a decision with your version of "the majority of users" in mind, it's possible that there are the other side of the coin or some deal-breaking edge cases not factored into the decision-making process. We raise our concerns based on what _our users_ tell us (and years of experience of dealing with real Superset users), too. It's quite discouraging to have to defend these concerns as if they were only of the interest of a small group.
Let's focus on the substance and make sure all future PRs have logical and thorough reasoning clearly stated BEFORE they are up for review. "We think this is better for new/most users" is not good enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud edited a comment on pull request #15915: [DISCUSS] - Moves the SQL Lab menu before Charts
Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on pull request #15915:
URL: https://github.com/apache/superset/pull/15915#issuecomment-888505351
Before we go, I'd like to vent out something that has been brewing in my mind for a while. I've noticed many times that whenever there is a disagreement in UX changes, there is the argument that "we made the choice for the broader Superset community/the majority of Superset users", or the so-called "business users". To me, this argument feels counterproductive.
As shown above, there can be many more substantive arguments about either side of each choice. Even if you made a decision with your version of "the majority of users" in mind, it's possible that there are the other side of the coin or some deal-breaking edge cases not factored into the decision-making process. We raise our concerns based on what _our users_ tell us (and years of experience of dealing with real Superset users), too. It's quite discouraging to having to defend these concerns as if they were only of the interest of a small group (or ourselves).
Let's focus on the substance and make sure all future PRs have logical and thorough reasoning clearly stated BEFORE they are up for review so potential debates can be more efficient. The more well-reasoned and clearly-described a PR description is, the better people can understand your original intention. The better we understand each other, the more efficient the discussion would be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud edited a comment on pull request #15915: [DISCUSS] - Moves the SQL Lab menu before Charts
Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on pull request #15915:
URL: https://github.com/apache/superset/pull/15915#issuecomment-888505351
Before we go, I'd like to vent out something that has been brewing in my mind for a while. I've noticed many times that whenever there is a disagreement in UX changes, there is the argument that "we made the choice for the broader Superset community/the majority of Superset users", or the so-called "business users". To me, this argument feels counterproductive.
As shown above, there can be many more substantive arguments about either side of each choice. Even if you made a decision with your version of "the majority of users" in mind, it's possible that there are the other side of the coin or some deal-breaking edge cases not factored into the decision-making process. We raise our concerns based on what _our users_ tell us (and years of experience of dealing with real Superset users), too. It's quite discouraging to having to defend these concerns as if they were only of the interest of a small group (or ourselves).
Let's focus on the substance and make sure all future PRs have logical and thorough reasoning clearly stated BEFORE they are up for review so we can have less of these grueling debates---because if the changes are very defensible, we don't even need to have a debate!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #15915: [DISCUSS] - Moves the SQL Lab menu before Charts
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #15915:
URL: https://github.com/apache/superset/pull/15915#issuecomment-888324981
@ktmud i agree. those routes you mentioned are validated in our research as well.
I personally don't have a strong preference of arranging the order by "Dashboards-> Charts -> SQL lab -> Data" or the other way around, as long as SQL lab is being placed in AN order. I know that this module was added separately and organically before without any design thinking.
Looks like we have reached an agreement here. I'm happy to change in order to move this PR forward :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud edited a comment on pull request #15915: [DISCUSS] - Moves the SQL Lab menu before Charts
Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on pull request #15915:
URL: https://github.com/apache/superset/pull/15915#issuecomment-887867118
Personally I think it'd make more sense to order by usage than workflow:
1. **Most users don't need the full workflow:** even for Data Scientists, they seldom work through the whole workflow in one go---IMO having the full workflow in the right order is less important than having easiest access to the most used steps in the workflow.
2. **Different users have different workflows:** "Data -> SQL Lab -> Chart -> Dashboard" is just _one_ workflow of _some_ Data Scientists. Some more frequent workflows are:
1. "Chart -> Dashboard"---for Data Scientists who only use pre-configured and shared datasets (which is probably something Superset should encourage), in which case one may argue the Data tab should be hidden into "Settings" (like [Redash](https://redash.io/help/user-guide/getting-started) does).
2. "Dashboard -> Chart -> SQL Lab"---for dashboard viewers who are also interested in how the underlying data were computed. This is somewhat similar to Looker's "Browse -> Explore -> Develop".
3. **The order is less important in the main menu:** while having the right order is important in some places, it's not like users can return to previous steps by clicking on the main menu.
4. **Home page already orders content by usage:** it's better be consistent than not.
I went back and checked, [SIP-34](https://github.com/apache/superset/issues/8976) actually re-arranged the menu by usage order (Dashboards -> Charts -> SQL Lab -> Data). There must be some reason behind that---hope it was in line with what I described above.
Lastly, even if "not being disruptive" is the only concern, changing from "Data -> Charts -> Dashboards -> SQL Lab" to "Data -> SQL Lab -> Charts -> Dashboards" would change the position of 3 tabs, while "Dashboards -> Charts -> Data -> SQL Lab" would only change 2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud edited a comment on pull request #15915: [DISCUSS] - Moves the SQL Lab menu before Charts
Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on pull request #15915:
URL: https://github.com/apache/superset/pull/15915#issuecomment-887867118
Personally I think it'd make more sense to order by usage than workflow:
1. **Most users don't need the full workflow:** even for Data Scientists, they seldom work through the whole workflow in one go---IMO having the full workflow in the right order is less important than having easiest access to the most used steps in the workflow.
2. **Different users have different workflows:** "Data -> SQL Lab -> Chart -> Dashboard" is just _one_ workflow of _some_ Data Scientists. Some more frequent workflows are:
1. "Chart -> Dashboard"---for Data Scientists who only use pre-configured and shared datasets (which is probably something Superset should encourage), in which case one may even argue the Data tab can be hidden into "Settings" (like [Redash](https://redash.io/help/user-guide/getting-started) does).
2. "Dashboard -> Chart -> SQL Lab"---for dashboard viewers who are also interested in how the underlying data were computed. This is somewhat similar to Looker's "Browse -> Explore -> Develop".
3. **The workflow order is less important in the main menu:** while having the right order is important in some places, it's not like users can or need to return to previous steps by clicking on the main menu when they are creating a dashboard from scratch.
4. **Home page already orders content by usage:** it's better be consistent than not.
I went back and checked, [SIP-34](https://github.com/apache/superset/issues/8976) actually re-arranged the menu by usage order (Dashboards -> Charts -> SQL Lab -> Data). There must be some reason behind that---hope it was in line with what I described above.
Lastly, even if "not being disruptive" is the only concern, changing from "Data -> Charts -> Dashboards -> SQL Lab" to "Data -> SQL Lab -> Charts -> Dashboards" would change the position of 3 tabs, keeping the **least** used tab unchanged; while "Dashboards -> Charts -> Data -> SQL Lab" would only change 2, keeping the **most** used tab unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #15915: [DISCUSS] - Moves the SQL Lab menu before Charts
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #15915:
URL: https://github.com/apache/superset/pull/15915#issuecomment-888498312
> @michael-s-molina please reopen the PR and proceed the change with below order.
> Dashboards -> Charts -> SQL Lab -> Data
>
> thanks for everyone's discussion
@junlincc I opened a [follow-up PR](https://github.com/apache/superset/pull/15929) to preserve the original description and screenshots of this PR. Both PRs are referencing each other.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #15915: [DISCUSS] - Moves the SQL Lab menu before Charts
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #15915:
URL: https://github.com/apache/superset/pull/15915#issuecomment-888487856
@michael-s-molina please reopen the PR and proceed the change with below order.
Dashboards -> Charts -> SQL Lab -> Data
thanks for everyone's discussion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud edited a comment on pull request #15915: [DISCUSS] - Moves the SQL Lab menu before Charts
Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on pull request #15915:
URL: https://github.com/apache/superset/pull/15915#issuecomment-887867118
Personally I think it'd make more sense to order by usage than workflow:
1. **Most users don't need the full workflow:** even for Data Scientists, they seldom work through the whole workflow in one go---IMO having the full workflow in the right order is less important than having easiest access to the most used steps in the workflow.
2. **Different users have different workflows:** "Data -> SQL Lab -> Chart -> Dashboard" is just _one_ workflow of _some_ Data Scientists. Some more frequent workflows are:
1. "Chart -> Dashboard"---for Data Scientists who only use pre-configured and shared datasets (which is probably something Superset should encourage), in which case one may even argue the Data tab can be hidden into "Settings" (like [Redash](https://redash.io/help/user-guide/getting-started) does).
2. "Dashboard -> Chart -> SQL Lab"---for dashboard viewers who are also interested in how the underlying data were computed. This is somewhat similar to Looker's "Browse -> Explore -> Develop".
3. **The workflow order is less important in the main menu:** while having the right order is important in some places, it's not like users can return to previous steps by clicking on the main menu.
4. **Home page already orders content by usage:** it's better be consistent than not.
I went back and checked, [SIP-34](https://github.com/apache/superset/issues/8976) actually re-arranged the menu by usage order (Dashboards -> Charts -> SQL Lab -> Data). There must be some reason behind that---hope it was in line with what I described above.
Lastly, even if "not being disruptive" is the only concern, changing from "Data -> Charts -> Dashboards -> SQL Lab" to "Data -> SQL Lab -> Charts -> Dashboards" would change the position of 3 tabs, keeping the **least** used tab unchanged; while "Dashboards -> Charts -> Data -> SQL Lab" would only change 2, keeping the **most** used tab unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] srinify commented on pull request #15915: [DISCUSS] - Moves the SQL Lab menu before Charts
Posted by GitBox <gi...@apache.org>.
srinify commented on pull request #15915:
URL: https://github.com/apache/superset/pull/15915#issuecomment-888347447
Thanks for the discussion y'all, I say let's move forward @michael-s-molina !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #15915: [DISCUSS] - Moves the SQL Lab menu before Charts
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #15915:
URL: https://github.com/apache/superset/pull/15915#issuecomment-888366993
I think both "Dashboards -> Charts -> SQL Lab -> Data" and "Dashboards -> Charts -> Data -> SQL Lab" make sense and don't have a strong preference of either.
The former is in line with the order by usage, but although `SQL Lab` may be more frequently used than `Data` overall, a lot of users almost never use either. For users do use SQL Lab directly from the main nav, it's a very separate workflow and they tend to use it a lot. So Keeping it as the last item also makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #15915: chore: Moves the SQL Lab menu before Charts
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #15915:
URL: https://github.com/apache/superset/pull/15915#issuecomment-887836918
Thanks for your comment @junlincc!
@john-bodley @ktmud @graceguo-supercat I updated the PR's description with Junlin's comments. We are trying to establish the most suited workflow for the majority of organizations using Superset.
Do you agree with the change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud edited a comment on pull request #15915: chore: Moves the SQL Lab menu before Charts
Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on pull request #15915:
URL: https://github.com/apache/superset/pull/15915#issuecomment-887803854
Please make sure PR description has enough context.
Without enough context, it'd just look like "because we talked about this internally so we are doing it", which is very much against [the Apache way](https://apache.org/theapacheway/).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud edited a comment on pull request #15915: [DISCUSS] - Moves the SQL Lab menu before Charts
Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on pull request #15915:
URL: https://github.com/apache/superset/pull/15915#issuecomment-888505351
Before we go, I'd like to vent out something that has been brewing in my mind for a while. I've noticed many times that whenever there is a disagreement in UX changes, there is the argument that "we made the choice for the broader Superset community/the majority of Superset users", or the so-called "business users". To me, this argument feels counterproductive.
As shown above, there can be many more substantive arguments about either side of each choice. Even if you made a decision with your version of "the majority of users" in mind, it's possible that there are the other side of the coin or some deal-breaking edge cases not factored into the decision-making process. We raise our concerns based on what _our users_ tell us (and years of experience of dealing with real Superset users), too. It's quite discouraging to having to defend these concerns as if they were only of the interest of a small group (or ourselves).
Let's focus on the substance and make sure all future PRs have logical and thorough reasoning clearly stated BEFORE they are up for review. "We think this is better for new/most users" is not good enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #15915: chore: Moves the SQL Lab menu before Charts
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #15915:
URL: https://github.com/apache/superset/pull/15915#issuecomment-887810186
@john-bodley @ktmud I'll check with @junlincc and @rusackas about the change and provide more context in the PR's description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #15915: chore: Moves the SQL Lab menu before Charts
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #15915:
URL: https://github.com/apache/superset/pull/15915#issuecomment-887793341
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina edited a comment on pull request #15915: chore: Moves the SQL Lab menu before Charts
Posted by GitBox <gi...@apache.org>.
michael-s-molina edited a comment on pull request #15915:
URL: https://github.com/apache/superset/pull/15915#issuecomment-887810186
@john-bodley @ktmud @graceguo-supercat I'll check with @junlincc and @rusackas about the change and provide more context in the PR's description. I'm converting the PR to draft to avoid being merged before the context is provided.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #15915: chore: Moves the SQL Lab menu before Charts
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #15915:
URL: https://github.com/apache/superset/pull/15915#issuecomment-887766532
# [Codecov](https://codecov.io/gh/apache/superset/pull/15915?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#15915](https://codecov.io/gh/apache/superset/pull/15915?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ca559dc) into [master](https://codecov.io/gh/apache/superset/commit/94e759dbfa84dec890d8e0cdf7c3ef0cfd9fd01c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (94e759d) will **decrease** coverage by `0.24%`.
> The diff coverage is `55.55%`.
> :exclamation: Current head ca559dc differs from pull request most recent head 468a857. Consider uploading reports for the commit 468a857 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/15915?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15915 +/- ##
==========================================
- Coverage 77.01% 76.77% -0.25%
==========================================
Files 986 986
Lines 51978 51985 +7
Branches 7091 7090 -1
==========================================
- Hits 40030 39910 -120
- Misses 11722 11849 +127
Partials 226 226
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `81.40% <47.05%> (-0.03%)` | :arrow_down: |
| postgres | `81.42% <47.05%> (-0.03%)` | :arrow_down: |
| presto | `?` | |
| python | `81.51% <47.05%> (-0.46%)` | :arrow_down: |
| sqlite | `81.06% <47.05%> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/15915?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...l/AdhocFilterEditPopoverSimpleTabContent/index.tsx](https://codecov.io/gh/apache/superset/pull/15915/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50L2luZGV4LnRzeA==) | `65.68% <ø> (ø)` | |
| [...ponents/controls/VizTypeControl/VizTypeGallery.tsx](https://codecov.io/gh/apache/superset/pull/15915/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC9WaXpUeXBlR2FsbGVyeS50c3g=) | `93.65% <ø> (ø)` | |
| [superset/examples/bart\_lines.py](https://codecov.io/gh/apache/superset/pull/15915/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmFydF9saW5lcy5weQ==) | `27.58% <0.00%> (-0.99%)` | :arrow_down: |
| [superset/examples/country\_map.py](https://codecov.io/gh/apache/superset/pull/15915/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhhbXBsZXMvY291bnRyeV9tYXAucHk=) | `25.00% <0.00%> (-0.65%)` | :arrow_down: |
| [superset/examples/energy.py](https://codecov.io/gh/apache/superset/pull/15915/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhhbXBsZXMvZW5lcmd5LnB5) | `26.19% <0.00%> (-0.64%)` | :arrow_down: |
| [superset/examples/flights.py](https://codecov.io/gh/apache/superset/pull/15915/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhhbXBsZXMvZmxpZ2h0cy5weQ==) | `17.64% <0.00%> (-0.54%)` | :arrow_down: |
| [superset/examples/long\_lat.py](https://codecov.io/gh/apache/superset/pull/15915/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhhbXBsZXMvbG9uZ19sYXQucHk=) | `23.80% <0.00%> (-0.59%)` | :arrow_down: |
| [superset/examples/multiformat\_time\_series.py](https://codecov.io/gh/apache/superset/pull/15915/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhhbXBsZXMvbXVsdGlmb3JtYXRfdGltZV9zZXJpZXMucHk=) | `16.66% <0.00%> (-0.36%)` | :arrow_down: |
| [superset/examples/paris.py](https://codecov.io/gh/apache/superset/pull/15915/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhhbXBsZXMvcGFyaXMucHk=) | `26.92% <0.00%> (-1.08%)` | :arrow_down: |
| [superset/examples/random\_time\_series.py](https://codecov.io/gh/apache/superset/pull/15915/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhhbXBsZXMvcmFuZG9tX3RpbWVfc2VyaWVzLnB5) | `19.44% <0.00%> (-0.56%)` | :arrow_down: |
| ... and [14 more](https://codecov.io/gh/apache/superset/pull/15915/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/15915?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/15915?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [94e759d...468a857](https://codecov.io/gh/apache/superset/pull/15915?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina closed pull request #15915: chore: Moves the SQL Lab menu before Charts
Posted by GitBox <gi...@apache.org>.
michael-s-molina closed pull request #15915:
URL: https://github.com/apache/superset/pull/15915
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina edited a comment on pull request #15915: [DISCUSS] - Moves the SQL Lab menu before Charts
Posted by GitBox <gi...@apache.org>.
michael-s-molina edited a comment on pull request #15915:
URL: https://github.com/apache/superset/pull/15915#issuecomment-888335424
@junlincc @ktmud @graceguo-supercat @john-bodley @srinify Thanks for your comments.
Can we proceed and make the change to follow [SIP-34](https://github.com/apache/superset/issues/8976) order?
Dashboards -> Charts -> SQL Lab -> Data
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #15915: chore: Moves the SQL Lab menu before Charts
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #15915:
URL: https://github.com/apache/superset/pull/15915#issuecomment-887803854
Please make sure PR description has enough context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud edited a comment on pull request #15915: [DISCUSS] - Moves the SQL Lab menu before Charts
Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on pull request #15915:
URL: https://github.com/apache/superset/pull/15915#issuecomment-888505351
Before we go, I'd like to vent out something that has been brewing in my mind for a while. I've noticed many times that whenever there is a disagreement in UX changes, there is the argument that "we made the choice for the broader Superset community/the majority of Superset users", or the so-called "business users". To me, this argument feels counterproductive.
As shown above, there can be many more substantive arguments about either side of each choice. Even if you made a decision with your version of "the majority of users" in mind, it's possible that there are the other side of the coin or some deal-breaking edge cases not factored into the decision-making process. We raise our concerns based on what _our users_ tell us (and years of experience of dealing with real Superset users), too. It's quite discouraging to have to defend these concerns as if they were only of the interest of a small group.
Let's focus on the substance and make sure all future PRs have logical and thorough reasoning clearly stated BEFORE they are up for review. "We think this is better for new/most users" is not good enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud edited a comment on pull request #15915: [DISCUSS] - Moves the SQL Lab menu before Charts
Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on pull request #15915:
URL: https://github.com/apache/superset/pull/15915#issuecomment-888505351
Before we go, I'd like to vent out something that has been brewing in my mind for a while. I've noticed many times that whenever there is a disagreement in UX changes, there is the argument that "we made the choice for the broader Superset community/the majority of Superset users", or the so-called "business users". To me, this argument feels counterproductive.
As shown above, there can be many more substantive arguments about either side of each choice. Even if you made a decision with your version of "the majority of users" in mind, it's possible that there are the other side of the coin or some deal-breaking edge cases not factored into the decision-making process. We raise our concerns based on what _our users_ tell us (and years of experience of dealing with real Superset users), too. It's quite discouraging to having to defend these concerns as if they were only of the interest of a small group (or ourselves).
Let's focus on the substance and make sure all future PRs have logical and thorough reasoning clearly stated BEFORE they are up for review so potential debates can be more efficient---because if the changes are very defensible, we don't even need to have to make a counter argument!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #15915: chore: Moves the SQL Lab menu before Charts
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #15915:
URL: https://github.com/apache/superset/pull/15915#issuecomment-887766532
# [Codecov](https://codecov.io/gh/apache/superset/pull/15915?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#15915](https://codecov.io/gh/apache/superset/pull/15915?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ca559dc) into [master](https://codecov.io/gh/apache/superset/commit/94e759dbfa84dec890d8e0cdf7c3ef0cfd9fd01c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (94e759d) will **decrease** coverage by `0.14%`.
> The diff coverage is `55.55%`.
> :exclamation: Current head ca559dc differs from pull request most recent head 468a857. Consider uploading reports for the commit 468a857 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/15915?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15915 +/- ##
==========================================
- Coverage 77.01% 76.86% -0.15%
==========================================
Files 986 986
Lines 51978 51985 +7
Branches 7091 7090 -1
==========================================
- Hits 40030 39959 -71
- Misses 11722 11800 +78
Partials 226 226
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `81.40% <47.05%> (-0.03%)` | :arrow_down: |
| postgres | `81.42% <47.05%> (-0.03%)` | :arrow_down: |
| presto | `81.16% <47.05%> (-0.02%)` | :arrow_down: |
| python | `81.69% <47.05%> (-0.28%)` | :arrow_down: |
| sqlite | `81.06% <47.05%> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/15915?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...l/AdhocFilterEditPopoverSimpleTabContent/index.tsx](https://codecov.io/gh/apache/superset/pull/15915/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50L2luZGV4LnRzeA==) | `65.68% <ø> (ø)` | |
| [...ponents/controls/VizTypeControl/VizTypeGallery.tsx](https://codecov.io/gh/apache/superset/pull/15915/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC9WaXpUeXBlR2FsbGVyeS50c3g=) | `93.65% <ø> (ø)` | |
| [superset/examples/bart\_lines.py](https://codecov.io/gh/apache/superset/pull/15915/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmFydF9saW5lcy5weQ==) | `27.58% <0.00%> (-0.99%)` | :arrow_down: |
| [superset/examples/country\_map.py](https://codecov.io/gh/apache/superset/pull/15915/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhhbXBsZXMvY291bnRyeV9tYXAucHk=) | `25.00% <0.00%> (-0.65%)` | :arrow_down: |
| [superset/examples/energy.py](https://codecov.io/gh/apache/superset/pull/15915/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhhbXBsZXMvZW5lcmd5LnB5) | `26.19% <0.00%> (-0.64%)` | :arrow_down: |
| [superset/examples/flights.py](https://codecov.io/gh/apache/superset/pull/15915/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhhbXBsZXMvZmxpZ2h0cy5weQ==) | `17.64% <0.00%> (-0.54%)` | :arrow_down: |
| [superset/examples/long\_lat.py](https://codecov.io/gh/apache/superset/pull/15915/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhhbXBsZXMvbG9uZ19sYXQucHk=) | `23.80% <0.00%> (-0.59%)` | :arrow_down: |
| [superset/examples/multiformat\_time\_series.py](https://codecov.io/gh/apache/superset/pull/15915/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhhbXBsZXMvbXVsdGlmb3JtYXRfdGltZV9zZXJpZXMucHk=) | `16.66% <0.00%> (-0.36%)` | :arrow_down: |
| [superset/examples/paris.py](https://codecov.io/gh/apache/superset/pull/15915/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhhbXBsZXMvcGFyaXMucHk=) | `26.92% <0.00%> (-1.08%)` | :arrow_down: |
| [superset/examples/random\_time\_series.py](https://codecov.io/gh/apache/superset/pull/15915/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhhbXBsZXMvcmFuZG9tX3RpbWVfc2VyaWVzLnB5) | `19.44% <0.00%> (-0.56%)` | :arrow_down: |
| ... and [11 more](https://codecov.io/gh/apache/superset/pull/15915/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/15915?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/15915?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [94e759d...468a857](https://codecov.io/gh/apache/superset/pull/15915?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud edited a comment on pull request #15915: [DISCUSS] - Moves the SQL Lab menu before Charts
Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on pull request #15915:
URL: https://github.com/apache/superset/pull/15915#issuecomment-888505351
Before we go, I'd like to vent out something that has been brewing in my mind for a while. I've noticed many times that whenever there is a disagreement in UX changes, there is the argument that "we made the choice for the broader Superset community/the majority of Superset users", or the so-called "business users". To me, this argument feels counterproductive.
As shown above, there can be many more substantive arguments about either side of each choice. Even if you made a decision with your version of "the majority of users" in mind, it's possible that there are the other side of the coin or some deal-breaking edge cases not factored into the decision-making process. We raise our concerns based on what _our users_ tell us (and years of experience of dealing with real Superset users), too. It's quite discouraging to having to defend these concerns as if they were only of the interest of a small group (or ourselves).
Let's focus on the substance and make sure all future PRs have logical and thorough reasoning clearly stated BEFORE they are up for review so potential debates can be more efficient. The more well-reasoned and clearly-described a PR description is, the better people can understand your intention. The better we understand each other, the more efficient the discussion would be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud edited a comment on pull request #15915: [DISCUSS] - Moves the SQL Lab menu before Charts
Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on pull request #15915:
URL: https://github.com/apache/superset/pull/15915#issuecomment-887867118
Personally I think it'd make more sense to order by usage than workflow:
1. **Most users don't need the full workflow:** even for Data Scientists, they seldom work through the whole workflow in one go---IMO having the full workflow in the right order is less important than having easiest access to the most used steps in the workflow.
2. **Different users have different workflows:** "Data -> SQL Lab -> Chart -> Dashboard" is just _one_ workflow of _some_ Data Scientists. Some more frequent workflows are:
1. "Chart -> Dashboard"---for Data Scientists who only use pre-configured and shared datasets (which is probably something Superset should encourage), in which case one may argue the Data tab should be hidden into "Settings" (like [Redash](https://redash.io/help/user-guide/getting-started) does).
2. "Dashboard -> Chart -> SQL Lab"---for dashboard viewers who are also interested in how the underlying data were computed. This is somewhat similar to Looker's "Browse -> Explore -> Develop".
3. **The order is less important in the main menu:** while having the right order is important in some places, it's not like users can return to previous steps by clicking on the main menu.
4. **Home page already orders content by usage:** it's better be consistent than not.
I went back and checked, [SIP-34](https://github.com/apache/superset/issues/8976) actually re-arranged the menu by usage order (Dashboards -> Charts -> SQL Lab -> Data). There must be some reason behind that---hope it was in line with what I described above.
Lastly, even if "not being disruptive" is the only concern, changing from "Data -> Charts -> Dashboards -> SQL Lab" to "Data -> SQL Lab -> Charts -> Dashboards" would change the position of 3 tabs, keeping the **least** used tab unchanged; while "Dashboards -> Charts -> Data -> SQL Lab" would only change 2, keeping the **most** used tab unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on pull request #15915: [DISCUSS] - Moves the SQL Lab menu before Charts
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #15915:
URL: https://github.com/apache/superset/pull/15915#issuecomment-889286611
I agree we should have a better flow for communicating and implementing UI/UX changes, and we will make sure it happens soon.
FYI This change may seem recent, but the actual research that was done to support this change happened last year, 80% of our datapoint is actually collected from airbnb users last year, and if not all, most of the interviewee agreed with changing the order, and the research summary is in
https://docs.google.com/presentation/d/182UJeK4y-BhcYkWJWYTJSA-O2_2LOXDYoAANi76-uBQ/edit
2 Preset designers and I each talked to 6-7 users from Airbnb, connected by @zuzana-vej.
@graceguo-supercat @ktmud @john-bodley @willbarrett @kristw
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #15915: chore: Moves the SQL Lab menu before Charts
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #15915:
URL: https://github.com/apache/superset/pull/15915#issuecomment-887766532
# [Codecov](https://codecov.io/gh/apache/superset/pull/15915?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#15915](https://codecov.io/gh/apache/superset/pull/15915?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ca559dc) into [master](https://codecov.io/gh/apache/superset/commit/94e759dbfa84dec890d8e0cdf7c3ef0cfd9fd01c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (94e759d) will **decrease** coverage by `0.14%`.
> The diff coverage is `55.55%`.
> :exclamation: Current head ca559dc differs from pull request most recent head 468a857. Consider uploading reports for the commit 468a857 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/15915?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15915 +/- ##
==========================================
- Coverage 77.01% 76.86% -0.15%
==========================================
Files 986 986
Lines 51978 51985 +7
Branches 7091 7090 -1
==========================================
- Hits 40030 39959 -71
- Misses 11722 11800 +78
Partials 226 226
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `81.40% <47.05%> (-0.03%)` | :arrow_down: |
| postgres | `81.42% <47.05%> (-0.03%)` | :arrow_down: |
| presto | `81.16% <47.05%> (-0.02%)` | :arrow_down: |
| python | `81.69% <47.05%> (-0.28%)` | :arrow_down: |
| sqlite | `81.06% <47.05%> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/15915?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...l/AdhocFilterEditPopoverSimpleTabContent/index.tsx](https://codecov.io/gh/apache/superset/pull/15915/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50L2luZGV4LnRzeA==) | `65.68% <ø> (ø)` | |
| [...ponents/controls/VizTypeControl/VizTypeGallery.tsx](https://codecov.io/gh/apache/superset/pull/15915/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC9WaXpUeXBlR2FsbGVyeS50c3g=) | `93.65% <ø> (ø)` | |
| [superset/examples/bart\_lines.py](https://codecov.io/gh/apache/superset/pull/15915/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmFydF9saW5lcy5weQ==) | `27.58% <0.00%> (-0.99%)` | :arrow_down: |
| [superset/examples/country\_map.py](https://codecov.io/gh/apache/superset/pull/15915/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhhbXBsZXMvY291bnRyeV9tYXAucHk=) | `25.00% <0.00%> (-0.65%)` | :arrow_down: |
| [superset/examples/energy.py](https://codecov.io/gh/apache/superset/pull/15915/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhhbXBsZXMvZW5lcmd5LnB5) | `26.19% <0.00%> (-0.64%)` | :arrow_down: |
| [superset/examples/flights.py](https://codecov.io/gh/apache/superset/pull/15915/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhhbXBsZXMvZmxpZ2h0cy5weQ==) | `17.64% <0.00%> (-0.54%)` | :arrow_down: |
| [superset/examples/long\_lat.py](https://codecov.io/gh/apache/superset/pull/15915/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhhbXBsZXMvbG9uZ19sYXQucHk=) | `23.80% <0.00%> (-0.59%)` | :arrow_down: |
| [superset/examples/multiformat\_time\_series.py](https://codecov.io/gh/apache/superset/pull/15915/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhhbXBsZXMvbXVsdGlmb3JtYXRfdGltZV9zZXJpZXMucHk=) | `16.66% <0.00%> (-0.36%)` | :arrow_down: |
| [superset/examples/paris.py](https://codecov.io/gh/apache/superset/pull/15915/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhhbXBsZXMvcGFyaXMucHk=) | `26.92% <0.00%> (-1.08%)` | :arrow_down: |
| [superset/examples/random\_time\_series.py](https://codecov.io/gh/apache/superset/pull/15915/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhhbXBsZXMvcmFuZG9tX3RpbWVfc2VyaWVzLnB5) | `19.44% <0.00%> (-0.56%)` | :arrow_down: |
| ... and [11 more](https://codecov.io/gh/apache/superset/pull/15915/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/15915?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/15915?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [94e759d...468a857](https://codecov.io/gh/apache/superset/pull/15915?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat commented on pull request #15915: chore: Moves the SQL Lab menu before Charts
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on pull request #15915:
URL: https://github.com/apache/superset/pull/15915#issuecomment-887809904
In airbnb, SQL users and Dashboard creation users are overlapped but not same group of people. Many users come to superset only for SQL Lab. This change is minor, but still might make them feel inconvenient and confused. Could you provide more reason for this change? thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #15915: chore: Moves the SQL Lab menu before Charts
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15915:
URL: https://github.com/apache/superset/pull/15915#issuecomment-887810385
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #15915: chore: Moves the SQL Lab menu before Charts
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15915:
URL: https://github.com/apache/superset/pull/15915#issuecomment-887794527
@junlincc Ephemeral environment spinning up at http://34.221.101.194:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] john-bodley commented on pull request #15915: chore: Moves the SQL Lab menu before Charts
Posted by GitBox <gi...@apache.org>.
john-bodley commented on pull request #15915:
URL: https://github.com/apache/superset/pull/15915#issuecomment-887798921
@michael-s-molina would you be able to document the motivation for the change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #15915: chore: Moves the SQL Lab menu before Charts
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #15915:
URL: https://github.com/apache/superset/pull/15915#issuecomment-887815118
Hi @john-bodley
We are trying to clearing some low-hanging fruit that previously discussed with Cartel, and approved in SIP-34.
Menu items in the top nav bar historically were not arranged in any particular order. We re-ordered the nav menu once last year and re-organize items in the sub menu as first step.
In the research with Cartel, the designer suggested that we can either arrange it by user's work flow, which is 1. to connect with database in **Data**, Persona: Data scientist. -> 2. to explore raw data, cleanup and restructure data if needed, prepare data for exploration by creating virtual datasets in **SQL Lab**, etc, Persona: Data scientist -> 3. to explore, slice and dice data, and to create charts for dashboard in **Explore(Chart)**; Persona: Data analyst ->4. to view and edit dashboard in **Dashboard** Persona: Business analyst/business users.
The other idea is to reorder the objects by usage, and the order would be the opposite. Dashboards-> Charts->SQL Lab->Data. This argument may seems counterintuitive to DS, as DS spend majority of their time in handling data. But the number of dashboard consumers is way larger than dashboard creators in large enterprises.
Given the current order, Data -> Charts -> Dashboards -> SQL lab, it seems to be less disruptive if we reorder by workflow.
We also did some user research in-house to validate our assumption, it's not directly related but could use it as a support document.
https://docs.google.com/presentation/d/182UJeK4y-BhcYkWJWYTJSA-O2_2LOXDYoAANi76-uBQ/edit#slide=id.g9743bec153_1_113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #15915: chore: Moves the SQL Lab menu before Charts
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #15915:
URL: https://github.com/apache/superset/pull/15915#issuecomment-887766532
# [Codecov](https://codecov.io/gh/apache/superset/pull/15915?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#15915](https://codecov.io/gh/apache/superset/pull/15915?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ca559dc) into [master](https://codecov.io/gh/apache/superset/commit/94e759dbfa84dec890d8e0cdf7c3ef0cfd9fd01c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (94e759d) will **decrease** coverage by `0.25%`.
> The diff coverage is `55.55%`.
> :exclamation: Current head ca559dc differs from pull request most recent head 468a857. Consider uploading reports for the commit 468a857 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/15915?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15915 +/- ##
==========================================
- Coverage 77.01% 76.75% -0.26%
==========================================
Files 986 986
Lines 51978 51945 -33
Branches 7091 7090 -1
==========================================
- Hits 40030 39871 -159
- Misses 11722 11848 +126
Partials 226 226
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `81.40% <47.05%> (-0.03%)` | :arrow_down: |
| postgres | `81.40% <47.05%> (-0.06%)` | :arrow_down: |
| presto | `?` | |
| python | `81.49% <47.05%> (-0.49%)` | :arrow_down: |
| sqlite | `81.06% <47.05%> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/15915?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...l/AdhocFilterEditPopoverSimpleTabContent/index.tsx](https://codecov.io/gh/apache/superset/pull/15915/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50L2luZGV4LnRzeA==) | `65.68% <ø> (ø)` | |
| [...ponents/controls/VizTypeControl/VizTypeGallery.tsx](https://codecov.io/gh/apache/superset/pull/15915/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC9WaXpUeXBlR2FsbGVyeS50c3g=) | `93.65% <ø> (ø)` | |
| [superset/examples/bart\_lines.py](https://codecov.io/gh/apache/superset/pull/15915/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmFydF9saW5lcy5weQ==) | `27.58% <0.00%> (-0.99%)` | :arrow_down: |
| [superset/examples/country\_map.py](https://codecov.io/gh/apache/superset/pull/15915/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhhbXBsZXMvY291bnRyeV9tYXAucHk=) | `25.00% <0.00%> (-0.65%)` | :arrow_down: |
| [superset/examples/energy.py](https://codecov.io/gh/apache/superset/pull/15915/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhhbXBsZXMvZW5lcmd5LnB5) | `26.19% <0.00%> (-0.64%)` | :arrow_down: |
| [superset/examples/flights.py](https://codecov.io/gh/apache/superset/pull/15915/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhhbXBsZXMvZmxpZ2h0cy5weQ==) | `17.64% <0.00%> (-0.54%)` | :arrow_down: |
| [superset/examples/long\_lat.py](https://codecov.io/gh/apache/superset/pull/15915/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhhbXBsZXMvbG9uZ19sYXQucHk=) | `23.80% <0.00%> (-0.59%)` | :arrow_down: |
| [superset/examples/multiformat\_time\_series.py](https://codecov.io/gh/apache/superset/pull/15915/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhhbXBsZXMvbXVsdGlmb3JtYXRfdGltZV9zZXJpZXMucHk=) | `16.66% <0.00%> (-0.36%)` | :arrow_down: |
| [superset/examples/paris.py](https://codecov.io/gh/apache/superset/pull/15915/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhhbXBsZXMvcGFyaXMucHk=) | `26.92% <0.00%> (-1.08%)` | :arrow_down: |
| [superset/examples/random\_time\_series.py](https://codecov.io/gh/apache/superset/pull/15915/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhhbXBsZXMvcmFuZG9tX3RpbWVfc2VyaWVzLnB5) | `19.44% <0.00%> (-0.56%)` | :arrow_down: |
| ... and [26 more](https://codecov.io/gh/apache/superset/pull/15915/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/15915?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/15915?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [94e759d...468a857](https://codecov.io/gh/apache/superset/pull/15915?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #15915: [DISCUSS] - Moves the SQL Lab menu before Charts
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #15915:
URL: https://github.com/apache/superset/pull/15915#issuecomment-889286611
I agree we should have a better flow for communicating and implementing UI/UX changes, and we will make sure it happens soon.
FYI This change may seem recent, but the actual research that was done to support this change happened last year, 80% of our datapoint is actually collected from airbnb users last year, and if not all, most of the interviewee agreed with changing the order, and the research summary is in
https://docs.google.com/presentation/d/182UJeK4y-BhcYkWJWYTJSA-O2_2LOXDYoAANi76-uBQ/edit
2 Preset designers and I each talked to 6-7 users, connected by @zuzana-vej.
@graceguo-supercat @ktmud @john-bodley @willbarrett @kristw
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud edited a comment on pull request #15915: [DISCUSS] - Moves the SQL Lab menu before Charts
Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on pull request #15915:
URL: https://github.com/apache/superset/pull/15915#issuecomment-888505351
Before we go, I'd like to vent out something that has been brewing in my mind for a while. I've noticed many times that whenever there is a disagreement in UX changes, there is the argument that "we are doing this for the broader Superset community/the majority of Superset users", or the so-called "business users". To me, this argument feels counterproductive.
As shown above, there can be many more substantive arguments about either side of each choice. Even if you made a decision with your version of "the majority of users" in mind, it's possible that there are the other side of the coin or some deal-breaking edge cases not factored into the decision-making process. We raise our concerns based on what _our users_ tell us (and years of experience of dealing with real Superset users), too. It's quite discouraging to have to defend these concerns as if they were only of the interest of a small group.
Let's focus on the substance and make sure all future PRs have logical and thorough reasoning clearly stated BEFORE they are up for review. "We think this is better for new/most users" is not good enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina closed pull request #15915: [DISCUSS] - Moves the SQL Lab menu before Charts
Posted by GitBox <gi...@apache.org>.
michael-s-molina closed pull request #15915:
URL: https://github.com/apache/superset/pull/15915
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina edited a comment on pull request #15915: [DISCUSS] - Moves the SQL Lab menu before Charts
Posted by GitBox <gi...@apache.org>.
michael-s-molina edited a comment on pull request #15915:
URL: https://github.com/apache/superset/pull/15915#issuecomment-888335424
@junlincc @ktmud @graceguo-supercat @john-bodley @srinify
Thanks for your comments.
Can we proceed and make the change to follow [SIP-34](https://github.com/apache/superset/issues/8976) order?
Dashboards -> Charts -> SQL Lab -> Data
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud edited a comment on pull request #15915: [DISCUSS] - Moves the SQL Lab menu before Charts
Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on pull request #15915:
URL: https://github.com/apache/superset/pull/15915#issuecomment-887867118
Personally I think it'd make more sense to order by usage than workflow:
1. **Most users don't need the full workflow:** even for Data Scientists, they seldom work through the whole workflow in one go---IMO having the full workflow in the right order is less important than having easiest access to the most used steps in the workflow.
2. **Different users have different workflows:** "Data -> SQL Lab -> Chart -> Dashboard" is just _one_ workflow of _some_ Data Scientists. Some more frequent workflows are:
1. "Chart -> Dashboard"---for Data Scientists who only use pre-configured and shared datasets (which is probably something Superset should encourage), in which case one may even argue the Data tab can be hidden into "Settings" (like [Redash](https://redash.io/help/user-guide/getting-started) does).
2. "Dashboard -> Chart -> SQL Lab"---for dashboard viewers who are also interested in how the underlying data were computed. This is somewhat similar to Looker's "Browse -> Explore -> Develop".
3. **The order is less important in the main menu:** while having the right order is important in some places, it's not like users can return to previous steps by clicking on the main menu.
4. **Home page already orders content by usage:** it's better be consistent than not.
I went back and checked, [SIP-34](https://github.com/apache/superset/issues/8976) actually re-arranged the menu by usage order (Dashboards -> Charts -> SQL Lab -> Data). There must be some reason behind that---hope it was in line with what I described above.
Lastly, even if "not being disruptive" is the only concern, changing from "Data -> Charts -> Dashboards -> SQL Lab" to "Data -> SQL Lab -> Charts -> Dashboards" would change the position of 3 tabs, keeping the **least** used tab unchanged; while "Dashboards -> Charts -> Data -> SQL Lab" would only change 2, keeping the **most** used tab unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org