[jira] [Commented] (HDFS-8422) Recursive mkdir removes sticky bit when adding implicit u+wx to intermediate directories

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-8422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14549251#comment-14549251 ] 

Hadoop QA commented on HDFS-8422:
---------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  15m  8s | Pre-patch trunk compilation is healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags. |
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to include 1 new or modified test files. |
| {color:red}-1{color} | javac |   1m 56s | The patch appears to cause the build to fail. |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12733623/HDFS-8422.001.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 0790275 |
| Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/11036/console |


This message was automatically generated.

> Recursive mkdir removes sticky bit when adding implicit u+wx to intermediate directories
> ----------------------------------------------------------------------------------------
>
>                 Key: HDFS-8422
>                 URL: https://issues.apache.org/jira/browse/HDFS-8422
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 2.7.0
>            Reporter: Jake Low
>            Assignee: Jake Low
>            Priority: Minor
>         Attachments: HDFS-8422.001.patch
>
>
> When performing a recursive {{mkdirs}} operation, the NameNode takes the provided {{FsPermission}} and applies it to the final directory that is created. The NameNode also uses these permissions when creating intermediate directories, except it promotes with {{u+wx}} (i.e. {{mode |= 0300}}) in order to ensure that there are sufficient permissions on the new directory to create further subdirectories within it.
> Currently the code that does this permission promotion uses the three-argument {{FsPermission}} constructor, which sets the sticky bit to {{false}}. I think this is probably not the intended behaviour, so I'm opening a bug. I'll attach a patch shortly that changes the behaviour so that the sticky bit is always retained.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)