[jira] [Work logged] (BEAM-8396) Default to LOOPBACK mode for local flink (spark, ...) runner.

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-8396?focusedWorklogId=337263&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337263 ]

ASF GitHub Bot logged work on BEAM-8396:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Nov/19 09:11
            Start Date: 01/Nov/19 09:11
    Worklog Time Spent: 10m 
      Work Description: mxm commented on pull request #9945: [BEAM-8396] Restore Flink runner LOOPBACK default.
URL: https://github.com/apache/beam/pull/9945#discussion_r341497803
 
 

 ##########
 File path: sdks/python/apache_beam/runners/portability/flink_runner.py
 ##########
 @@ -34,6 +34,14 @@
 
 
 class FlinkRunner(portable_runner.PortableRunner):
+  def run_pipeline(self, pipeline, options):
+    portable_options = options.view_as(pipeline_options.PortableOptions)
+    if (options.view_as(FlinkRunnerOptions).flink_master in MAGIC_HOST_NAMES
+        and not portable_options.environment_type
+        and not portable_options.output_executable_path):
 
 Review comment:
   AFAIK this change was proposed by you and Robert. So it seemed fair to go ahead with it.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 337263)
    Time Spent: 4h 10m  (was: 4h)

> Default to LOOPBACK mode for local flink (spark, ...) runner.
> -------------------------------------------------------------
>
>                 Key: BEAM-8396
>                 URL: https://issues.apache.org/jira/browse/BEAM-8396
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-py-core
>            Reporter: Robert Bradshaw
>            Assignee: Robert Bradshaw
>            Priority: Major
>          Time Spent: 4h 10m
>  Remaining Estimate: 0h
>
> As well as being lower overhead, this will avoid surprises about workers operating within the docker filesystem, etc. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)