You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "zhangqianqiong (Code Review)" <ge...@cloudera.org> on 2023/07/09 06:23:21 UTC
[Impala-ASF-CR] IMPALA-12273 Fix possible memory corruption of premature release of objects returned by native methods
zhangqianqiong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20174
Change subject: IMPALA-12273 Fix possible memory corruption of premature release of objects returned by native methods
......................................................................
IMPALA-12273 Fix possible memory corruption of premature release of objects returned by native methods
In the Jni Native method, there was an erroneous usage of JniLocalFrame.
The JniLocalFrame mistakenly released the reference to the returned object during its destruction,
causing the object to be reclaimed during high-concurrency garbage collection.
The solution is to remove the JniLocalFrame-related code, since the native method does not create
a local frame in JniEnv.
Testing: During stress testing, there have been no further occurrences of memory corruption.
Change-Id: I94b1c6b3f96897850512c01cdb942ebdcc59b694
---
M be/src/service/fe-support.cc
1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/74/20174/2
--
To view, visit http://gerrit.cloudera.org:8080/20174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I94b1c6b3f96897850512c01cdb942ebdcc59b694
Gerrit-Change-Number: 20174
Gerrit-PatchSet: 2
Gerrit-Owner: zhangqianqiong <qq...@gmail.com>
[Impala-ASF-CR] IMPALA-12273 Fix possible memory corruption of premature release of objects returned by native methods
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20174 )
Change subject: IMPALA-12273 Fix possible memory corruption of premature release of objects returned by native methods
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/20174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94b1c6b3f96897850512c01cdb942ebdcc59b694
Gerrit-Change-Number: 20174
Gerrit-PatchSet: 3
Gerrit-Owner: zhangqianqiong <qq...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: zhangqianqiong <qq...@gmail.com>
Gerrit-Comment-Date: Thu, 13 Jul 2023 17:59:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12273 Fix possible memory corruption of premature release of objects returned by native methods
Posted by "zhangqianqiong (Code Review)" <ge...@cloudera.org>.
zhangqianqiong has posted comments on this change. ( http://gerrit.cloudera.org:8080/20174 )
Change subject: IMPALA-12273 Fix possible memory corruption of premature release of objects returned by native methods
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/20174/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/20174/2//COMMIT_MSG@9
PS2, Line 9:
> nit: don't need indention and please keep the line width in 72 characters.
Done
--
To view, visit http://gerrit.cloudera.org:8080/20174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94b1c6b3f96897850512c01cdb942ebdcc59b694
Gerrit-Change-Number: 20174
Gerrit-PatchSet: 2
Gerrit-Owner: zhangqianqiong <qq...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: zhangqianqiong <qq...@gmail.com>
Gerrit-Comment-Date: Thu, 13 Jul 2023 02:41:41 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12273 Fix possible memory corruption of premature release of objects returned by native methods
Posted by "zhangqianqiong (Code Review)" <ge...@cloudera.org>.
zhangqianqiong has posted comments on this change. ( http://gerrit.cloudera.org:8080/20174 )
Change subject: IMPALA-12273 Fix possible memory corruption of premature release of objects returned by native methods
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/20174/2/be/src/service/fe-support.cc
File be/src/service/fe-support.cc:
http://gerrit.cloudera.org:8080/#/c/20174/2/be/src/service/fe-support.cc@a215
PS2, Line 215:
> This was added in IMPALA-358. result_bytes is initialized in this function
Wow, you're great! So this issue was introduced here.
--
To view, visit http://gerrit.cloudera.org:8080/20174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94b1c6b3f96897850512c01cdb942ebdcc59b694
Gerrit-Change-Number: 20174
Gerrit-PatchSet: 2
Gerrit-Owner: zhangqianqiong <qq...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: zhangqianqiong <qq...@gmail.com>
Gerrit-Comment-Date: Thu, 13 Jul 2023 02:39:47 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12273 Fix possible memory corruption of premature release of objects returned by native methods
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20174 )
Change subject: IMPALA-12273 Fix possible memory corruption of premature release of objects returned by native methods
......................................................................
Patch Set 4: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9596/
--
To view, visit http://gerrit.cloudera.org:8080/20174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94b1c6b3f96897850512c01cdb942ebdcc59b694
Gerrit-Change-Number: 20174
Gerrit-PatchSet: 4
Gerrit-Owner: zhangqianqiong <qq...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: zhangqianqiong <qq...@gmail.com>
Gerrit-Comment-Date: Mon, 14 Aug 2023 12:27:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12273 Fix possible memory corruption of premature release of objects returned by native methods
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20174 )
Change subject: IMPALA-12273 Fix possible memory corruption of premature release of objects returned by native methods
......................................................................
IMPALA-12273 Fix possible memory corruption of premature release of objects returned by native methods
In the Jni Native method, there was an erroneous usage of JniLocalFrame.
The JniLocalFrame mistakenly released the reference to the returned
object during its destruction, causing the object to be reclaimed during
high-concurrency garbage collection.
The solution is to remove the JniLocalFrame-related code, since the
native method does not create a local frame in JniEnv.
Testing: During stress testing, there have been no further occurrences
of memory corruption.
Change-Id: I94b1c6b3f96897850512c01cdb942ebdcc59b694
Reviewed-on: http://gerrit.cloudera.org:8080/20174
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/service/fe-support.cc
1 file changed, 0 insertions(+), 4 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/20174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I94b1c6b3f96897850512c01cdb942ebdcc59b694
Gerrit-Change-Number: 20174
Gerrit-PatchSet: 6
Gerrit-Owner: zhangqianqiong <qq...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: zhangqianqiong <qq...@gmail.com>
[Impala-ASF-CR] IMPALA-12273 Fix possible memory corruption of premature release of objects returned by native methods
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20174 )
Change subject: IMPALA-12273 Fix possible memory corruption of premature release of objects returned by native methods
......................................................................
Patch Set 2:
(1 comment)
Thanks for reporting the issue and providing a fix!
Is is possible to add a test?
http://gerrit.cloudera.org:8080/#/c/20174/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/20174/2//COMMIT_MSG@9
PS2, Line 9:
nit: don't need indention and please keep the line width in 72 characters.
--
To view, visit http://gerrit.cloudera.org:8080/20174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94b1c6b3f96897850512c01cdb942ebdcc59b694
Gerrit-Change-Number: 20174
Gerrit-PatchSet: 2
Gerrit-Owner: zhangqianqiong <qq...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 10 Jul 2023 13:40:38 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12273 Fix possible memory corruption of premature release of objects returned by native methods
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20174 )
Change subject: IMPALA-12273 Fix possible memory corruption of premature release of objects returned by native methods
......................................................................
Patch Set 2:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/13492/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/20174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94b1c6b3f96897850512c01cdb942ebdcc59b694
Gerrit-Change-Number: 20174
Gerrit-PatchSet: 2
Gerrit-Owner: zhangqianqiong <qq...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 09 Jul 2023 06:46:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12273 Fix possible memory corruption of premature release of objects returned by native methods
Posted by "zhangqianqiong (Code Review)" <ge...@cloudera.org>.
zhangqianqiong has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/20174 )
Change subject: IMPALA-12273 Fix possible memory corruption of premature release of objects returned by native methods
......................................................................
IMPALA-12273 Fix possible memory corruption of premature release of objects returned by native methods
In the Jni Native method, there was an erroneous usage of JniLocalFrame.
The JniLocalFrame mistakenly released the reference to the returned
object during its destruction, causing the object to be reclaimed during
high-concurrency garbage collection.
The solution is to remove the JniLocalFrame-related code, since the
native method does not create a local frame in JniEnv.
Testing: During stress testing, there have been no further occurrences
of memory corruption.
Change-Id: I94b1c6b3f96897850512c01cdb942ebdcc59b694
---
M be/src/service/fe-support.cc
1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/74/20174/3
--
To view, visit http://gerrit.cloudera.org:8080/20174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I94b1c6b3f96897850512c01cdb942ebdcc59b694
Gerrit-Change-Number: 20174
Gerrit-PatchSet: 3
Gerrit-Owner: zhangqianqiong <qq...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: zhangqianqiong <qq...@gmail.com>
[Impala-ASF-CR] IMPALA-12273 Fix possible memory corruption of premature release of objects returned by native methods
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20174 )
Change subject: IMPALA-12273 Fix possible memory corruption of premature release of objects returned by native methods
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/20174/2/be/src/service/fe-support.cc
File be/src/service/fe-support.cc:
http://gerrit.cloudera.org:8080/#/c/20174/2/be/src/service/fe-support.cc@a215
PS2, Line 215:
This was added in IMPALA-358. result_bytes is initialized in this function and returned by the function, so I agree we shouldn't release everything created in this frame. As far as I can tell result_bytes is the only JNI object allocated in this function.
The local reference to result_bytes will disappear when the function returns, which is immediately after allocating and filling it.
--
To view, visit http://gerrit.cloudera.org:8080/20174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94b1c6b3f96897850512c01cdb942ebdcc59b694
Gerrit-Change-Number: 20174
Gerrit-PatchSet: 2
Gerrit-Owner: zhangqianqiong <qq...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 10 Jul 2023 17:24:10 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12273 Fix possible memory corruption of premature release of objects returned by native methods
Posted by "zhangqianqiong (Code Review)" <ge...@cloudera.org>.
zhangqianqiong has posted comments on this change. ( http://gerrit.cloudera.org:8080/20174 )
Change subject: IMPALA-12273 Fix possible memory corruption of premature release of objects returned by native methods
......................................................................
Patch Set 2:
> (1 comment)
>
> Thanks for reporting the issue and providing a fix!
>
> Is is possible to add a test?
Let me think about it. It's not easy to add tests in this scenario, as the results are not easily verifiable.
--
To view, visit http://gerrit.cloudera.org:8080/20174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94b1c6b3f96897850512c01cdb942ebdcc59b694
Gerrit-Change-Number: 20174
Gerrit-PatchSet: 2
Gerrit-Owner: zhangqianqiong <qq...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: zhangqianqiong <qq...@gmail.com>
Gerrit-Comment-Date: Wed, 12 Jul 2023 22:44:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12273 Fix possible memory corruption of premature release of objects returned by native methods
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20174 )
Change subject: IMPALA-12273 Fix possible memory corruption of premature release of objects returned by native methods
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94b1c6b3f96897850512c01cdb942ebdcc59b694
Gerrit-Change-Number: 20174
Gerrit-PatchSet: 5
Gerrit-Owner: zhangqianqiong <qq...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: zhangqianqiong <qq...@gmail.com>
Gerrit-Comment-Date: Thu, 07 Sep 2023 21:32:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12273 Fix possible memory corruption of premature release of objects returned by native methods
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20174 )
Change subject: IMPALA-12273 Fix possible memory corruption of premature release of objects returned by native methods
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9685/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/20174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94b1c6b3f96897850512c01cdb942ebdcc59b694
Gerrit-Change-Number: 20174
Gerrit-PatchSet: 5
Gerrit-Owner: zhangqianqiong <qq...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: zhangqianqiong <qq...@gmail.com>
Gerrit-Comment-Date: Thu, 07 Sep 2023 21:32:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12273 Fix possible memory corruption of premature release of objects returned by native methods
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20174 )
Change subject: IMPALA-12273 Fix possible memory corruption of premature release of objects returned by native methods
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9596/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/20174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94b1c6b3f96897850512c01cdb942ebdcc59b694
Gerrit-Change-Number: 20174
Gerrit-PatchSet: 4
Gerrit-Owner: zhangqianqiong <qq...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: zhangqianqiong <qq...@gmail.com>
Gerrit-Comment-Date: Mon, 14 Aug 2023 08:14:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12273 Fix possible memory corruption of premature release of objects returned by native methods
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20174 )
Change subject: IMPALA-12273 Fix possible memory corruption of premature release of objects returned by native methods
......................................................................
Patch Set 3: Code-Review+2
Carrying Michael's +1. Nice catch!
--
To view, visit http://gerrit.cloudera.org:8080/20174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94b1c6b3f96897850512c01cdb942ebdcc59b694
Gerrit-Change-Number: 20174
Gerrit-PatchSet: 3
Gerrit-Owner: zhangqianqiong <qq...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: zhangqianqiong <qq...@gmail.com>
Gerrit-Comment-Date: Mon, 14 Aug 2023 08:14:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12273 Fix possible memory corruption of premature release of objects returned by native methods
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20174 )
Change subject: IMPALA-12273 Fix possible memory corruption of premature release of objects returned by native methods
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/13532/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/20174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94b1c6b3f96897850512c01cdb942ebdcc59b694
Gerrit-Change-Number: 20174
Gerrit-PatchSet: 3
Gerrit-Owner: zhangqianqiong <qq...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: zhangqianqiong <qq...@gmail.com>
Gerrit-Comment-Date: Wed, 12 Jul 2023 23:17:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12273 Fix possible memory corruption of premature release of objects returned by native methods
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20174 )
Change subject: IMPALA-12273 Fix possible memory corruption of premature release of objects returned by native methods
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94b1c6b3f96897850512c01cdb942ebdcc59b694
Gerrit-Change-Number: 20174
Gerrit-PatchSet: 4
Gerrit-Owner: zhangqianqiong <qq...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: zhangqianqiong <qq...@gmail.com>
Gerrit-Comment-Date: Mon, 14 Aug 2023 08:14:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12273 Fix possible memory corruption of premature release of objects returned by native methods
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20174 )
Change subject: IMPALA-12273 Fix possible memory corruption of premature release of objects returned by native methods
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/20174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94b1c6b3f96897850512c01cdb942ebdcc59b694
Gerrit-Change-Number: 20174
Gerrit-PatchSet: 5
Gerrit-Owner: zhangqianqiong <qq...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: zhangqianqiong <qq...@gmail.com>
Gerrit-Comment-Date: Fri, 08 Sep 2023 02:01:58 +0000
Gerrit-HasComments: No