You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Zach Calvert (JIRA)" <ji...@apache.org> on 2010/10/27 00:01:26 UTC

[jira] Created: (HTTPCLIENT-1019) httpclient-osgi Requires commons-logging 1.1.1 exported in OSGi, which they have no plan to move forward with

httpclient-osgi Requires commons-logging 1.1.1 exported in OSGi, which they have no plan to move forward with
-------------------------------------------------------------------------------------------------------------

                 Key: HTTPCLIENT-1019
                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1019
             Project: HttpComponents HttpClient
          Issue Type: Bug
    Affects Versions: 4.0.3, 4.0.2, 4.0.1
            Reporter: Zach Calvert
            Priority: Critical


If you are trying to run the httpclient-osgi version 4.0.1, there is little opportunity to make it work without hand rolling your own apache commons logging.  Using the Maven descriptor:
        <dependency>
            <groupId>org.apache.httpcomponents</groupId>
            <artifactId>httpclient-osgi</artifactId>
            <version>4.0.1</version>
        </dependency>
You will find that the downloaded bundle manifest has:
Import-Package: javax.crypto,javax.crypto.spec,javax.net.ssl,javax.sec
 urity.auth.x500,org.apache.commons.logging;version="1.1.1",org.apache
...
Emphasis on org.apache.commons.logging;version="1.1.1".  Basing my understanding of the bug at 
https://issues.apache.org/jira/browse/LOGGING-124
which I have also commented on, there is no such thing as an exported osgi package version 1.1.1 of commons logging due to problems with the OSGi classloader.  

Support needs to be made to make commons logging optional in the osgi world and if the logging mechanism for commons logging isn't there, then move forward to something that doesn't make waves for the OSGi runtime.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

[jira] Commented: (HTTPCLIENT-1019) httpclient-osgi Requires commons-logging 1.1.1 exported in OSGi, which they have no plan to move forward with

Posted by "Zach Calvert (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925387#action_12925387 ] 

Zach Calvert commented on HTTPCLIENT-1019:
------------------------------------------

Oleg, 
I attached the patch, but after reviewing the source this patch will not make the problem go away.  It looks like commons logging is pretty well meshed together with the code.  

I would not use this patch for anything other than a "what could be done if Apache Logging was stripped out of required aspects of the code"

I guess I will make use of the spring wrapped bundle of commons-logging and begin testing.



Thanks,
Zach

> httpclient-osgi Requires commons-logging 1.1.1 exported in OSGi, which they have no plan to move forward with
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1019
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1019
>             Project: HttpComponents HttpClient
>          Issue Type: New Feature
>          Components: HttpClient
>    Affects Versions: 4.0.1, 4.0.2, 4.0.3
>            Reporter: Zach Calvert
>             Fix For: Future
>
>         Attachments: optional.diff
>
>
> If you are trying to run the httpclient-osgi version 4.0.1, there is little opportunity to make it work without hand rolling your own apache commons logging.  Using the Maven descriptor:
>         <dependency>
>             <groupId>org.apache.httpcomponents</groupId>
>             <artifactId>httpclient-osgi</artifactId>
>             <version>4.0.1</version>
>         </dependency>
> You will find that the downloaded bundle manifest has:
> Import-Package: javax.crypto,javax.crypto.spec,javax.net.ssl,javax.sec
>  urity.auth.x500,org.apache.commons.logging;version="1.1.1",org.apache
> ...
> Emphasis on org.apache.commons.logging;version="1.1.1".  Basing my understanding of the bug at 
> https://issues.apache.org/jira/browse/LOGGING-124
> which I have also commented on, there is no such thing as an exported osgi package version 1.1.1 of commons logging due to problems with the OSGi classloader.  
> Support needs to be made to make commons logging optional in the osgi world and if the logging mechanism for commons logging isn't there, then move forward to something that doesn't make waves for the OSGi runtime.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

[jira] Resolved: (HTTPCLIENT-1019) httpclient-osgi Requires commons-logging 1.1.1 exported in OSGi, which they have no plan to move forward with

Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCLIENT-1019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oleg Kalnichevski resolved HTTPCLIENT-1019.
-------------------------------------------

       Resolution: Won't Fix
    Fix Version/s:     (was: Future)

Closing as WONTFIX. If you want to Commons Logging to be replaced with a different logging framework in the next major version of HttpClient, please re-open HTTPCLIENT-416

Oleg

> httpclient-osgi Requires commons-logging 1.1.1 exported in OSGi, which they have no plan to move forward with
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1019
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1019
>             Project: HttpComponents HttpClient
>          Issue Type: New Feature
>          Components: HttpClient
>    Affects Versions: 4.0.1, 4.0.2, 4.0.3
>            Reporter: Zach Calvert
>         Attachments: optional.diff
>
>
> If you are trying to run the httpclient-osgi version 4.0.1, there is little opportunity to make it work without hand rolling your own apache commons logging.  Using the Maven descriptor:
>         <dependency>
>             <groupId>org.apache.httpcomponents</groupId>
>             <artifactId>httpclient-osgi</artifactId>
>             <version>4.0.1</version>
>         </dependency>
> You will find that the downloaded bundle manifest has:
> Import-Package: javax.crypto,javax.crypto.spec,javax.net.ssl,javax.sec
>  urity.auth.x500,org.apache.commons.logging;version="1.1.1",org.apache
> ...
> Emphasis on org.apache.commons.logging;version="1.1.1".  Basing my understanding of the bug at 
> https://issues.apache.org/jira/browse/LOGGING-124
> which I have also commented on, there is no such thing as an exported osgi package version 1.1.1 of commons logging due to problems with the OSGi classloader.  
> Support needs to be made to make commons logging optional in the osgi world and if the logging mechanism for commons logging isn't there, then move forward to something that doesn't make waves for the OSGi runtime.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

[jira] Updated: (HTTPCLIENT-1019) httpclient-osgi Requires commons-logging 1.1.1 exported in OSGi, which they have no plan to move forward with

Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCLIENT-1019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oleg Kalnichevski updated HTTPCLIENT-1019:
------------------------------------------

      Component/s: HttpClient
         Priority: Major  (was: Critical)
    Fix Version/s: Future
       Issue Type: New Feature  (was: Bug)

> httpclient-osgi Requires commons-logging 1.1.1 exported in OSGi, which they have no plan to move forward with
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1019
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1019
>             Project: HttpComponents HttpClient
>          Issue Type: New Feature
>          Components: HttpClient
>    Affects Versions: 4.0.1, 4.0.2, 4.0.3
>            Reporter: Zach Calvert
>             Fix For: Future
>
>
> If you are trying to run the httpclient-osgi version 4.0.1, there is little opportunity to make it work without hand rolling your own apache commons logging.  Using the Maven descriptor:
>         <dependency>
>             <groupId>org.apache.httpcomponents</groupId>
>             <artifactId>httpclient-osgi</artifactId>
>             <version>4.0.1</version>
>         </dependency>
> You will find that the downloaded bundle manifest has:
> Import-Package: javax.crypto,javax.crypto.spec,javax.net.ssl,javax.sec
>  urity.auth.x500,org.apache.commons.logging;version="1.1.1",org.apache
> ...
> Emphasis on org.apache.commons.logging;version="1.1.1".  Basing my understanding of the bug at 
> https://issues.apache.org/jira/browse/LOGGING-124
> which I have also commented on, there is no such thing as an exported osgi package version 1.1.1 of commons logging due to problems with the OSGi classloader.  
> Support needs to be made to make commons logging optional in the osgi world and if the logging mechanism for commons logging isn't there, then move forward to something that doesn't make waves for the OSGi runtime.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

[jira] Commented: (HTTPCLIENT-1019) httpclient-osgi Requires commons-logging 1.1.1 exported in OSGi, which they have no plan to move forward with

Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925378#action_12925378 ] 

Oleg Kalnichevski commented on HTTPCLIENT-1019:
-----------------------------------------------

> then there needs to be an apache release of commons logging that has been bundlefied to export 1.1.1 of commons logging

What is the problem with using the one provided by Spring? I suspect Spring folks understand thing or two about OSGi. This is basically what I did when testing the HttpClient OSGi bundle. 

> http client needs to make commons logging optional in its osgi flavor

What do you mean by optional (and what should happen in case it is not available)? Can you submit a patch against 4.0.x branch or trunk? 

Oleg

> httpclient-osgi Requires commons-logging 1.1.1 exported in OSGi, which they have no plan to move forward with
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1019
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1019
>             Project: HttpComponents HttpClient
>          Issue Type: New Feature
>          Components: HttpClient
>    Affects Versions: 4.0.1, 4.0.2, 4.0.3
>            Reporter: Zach Calvert
>             Fix For: Future
>
>
> If you are trying to run the httpclient-osgi version 4.0.1, there is little opportunity to make it work without hand rolling your own apache commons logging.  Using the Maven descriptor:
>         <dependency>
>             <groupId>org.apache.httpcomponents</groupId>
>             <artifactId>httpclient-osgi</artifactId>
>             <version>4.0.1</version>
>         </dependency>
> You will find that the downloaded bundle manifest has:
> Import-Package: javax.crypto,javax.crypto.spec,javax.net.ssl,javax.sec
>  urity.auth.x500,org.apache.commons.logging;version="1.1.1",org.apache
> ...
> Emphasis on org.apache.commons.logging;version="1.1.1".  Basing my understanding of the bug at 
> https://issues.apache.org/jira/browse/LOGGING-124
> which I have also commented on, there is no such thing as an exported osgi package version 1.1.1 of commons logging due to problems with the OSGi classloader.  
> Support needs to be made to make commons logging optional in the osgi world and if the logging mechanism for commons logging isn't there, then move forward to something that doesn't make waves for the OSGi runtime.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

[jira] Updated: (HTTPCLIENT-1019) httpclient-osgi Requires commons-logging 1.1.1 exported in OSGi, which they have no plan to move forward with

Posted by "Zach Calvert (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCLIENT-1019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zach Calvert updated HTTPCLIENT-1019:
-------------------------------------

    Attachment: optional.diff

Diff for making the import package optional ---

HOWEVER -- This will not fix the problem as there is actual usage of the commong logging packages in commonly used classes, such as RequestCookies

> httpclient-osgi Requires commons-logging 1.1.1 exported in OSGi, which they have no plan to move forward with
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1019
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1019
>             Project: HttpComponents HttpClient
>          Issue Type: New Feature
>          Components: HttpClient
>    Affects Versions: 4.0.1, 4.0.2, 4.0.3
>            Reporter: Zach Calvert
>             Fix For: Future
>
>         Attachments: optional.diff
>
>
> If you are trying to run the httpclient-osgi version 4.0.1, there is little opportunity to make it work without hand rolling your own apache commons logging.  Using the Maven descriptor:
>         <dependency>
>             <groupId>org.apache.httpcomponents</groupId>
>             <artifactId>httpclient-osgi</artifactId>
>             <version>4.0.1</version>
>         </dependency>
> You will find that the downloaded bundle manifest has:
> Import-Package: javax.crypto,javax.crypto.spec,javax.net.ssl,javax.sec
>  urity.auth.x500,org.apache.commons.logging;version="1.1.1",org.apache
> ...
> Emphasis on org.apache.commons.logging;version="1.1.1".  Basing my understanding of the bug at 
> https://issues.apache.org/jira/browse/LOGGING-124
> which I have also commented on, there is no such thing as an exported osgi package version 1.1.1 of commons logging due to problems with the OSGi classloader.  
> Support needs to be made to make commons logging optional in the osgi world and if the logging mechanism for commons logging isn't there, then move forward to something that doesn't make waves for the OSGi runtime.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

[jira] Commented: (HTTPCLIENT-1019) httpclient-osgi Requires commons-logging 1.1.1 exported in OSGi, which they have no plan to move forward with

Posted by "Zach Calvert (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925169#action_12925169 ] 

Zach Calvert commented on HTTPCLIENT-1019:
------------------------------------------

Also, the commonsOsgi documentation (wiki) has information on the direction with the commons logging:
http://wiki.apache.org/commons/CommonsOsgi

If you're looking for an inflammatory laugh, the PAX development team has also had to deal with this mess, although on other lines.  Here is what they have to say:
http://commons.markmail.org/message/kdnjlbokvuiigcew



> httpclient-osgi Requires commons-logging 1.1.1 exported in OSGi, which they have no plan to move forward with
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1019
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1019
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>    Affects Versions: 4.0.1, 4.0.2, 4.0.3
>            Reporter: Zach Calvert
>            Priority: Critical
>
> If you are trying to run the httpclient-osgi version 4.0.1, there is little opportunity to make it work without hand rolling your own apache commons logging.  Using the Maven descriptor:
>         <dependency>
>             <groupId>org.apache.httpcomponents</groupId>
>             <artifactId>httpclient-osgi</artifactId>
>             <version>4.0.1</version>
>         </dependency>
> You will find that the downloaded bundle manifest has:
> Import-Package: javax.crypto,javax.crypto.spec,javax.net.ssl,javax.sec
>  urity.auth.x500,org.apache.commons.logging;version="1.1.1",org.apache
> ...
> Emphasis on org.apache.commons.logging;version="1.1.1".  Basing my understanding of the bug at 
> https://issues.apache.org/jira/browse/LOGGING-124
> which I have also commented on, there is no such thing as an exported osgi package version 1.1.1 of commons logging due to problems with the OSGi classloader.  
> Support needs to be made to make commons logging optional in the osgi world and if the logging mechanism for commons logging isn't there, then move forward to something that doesn't make waves for the OSGi runtime.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

[jira] Commented: (HTTPCLIENT-1019) httpclient-osgi Requires commons-logging 1.1.1 exported in OSGi, which they have no plan to move forward with

Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925361#action_12925361 ] 

Oleg Kalnichevski commented on HTTPCLIENT-1019:
-----------------------------------------------

Zach

While I agree the discovery mechanism of Commons Logging is utterly broken for containers and managed environments with complex class loader hierarchies, I personally do not think there is anything wrong with the Commons Logging API. We had a fair share of Logging Wars on the dev and user lists in the past and would not like them to repeat. 

There is _nothing_ that prevents you from using a compatibility layer such as jcl-over-slf4j provided by slf4j and whatever concrete implementation you find to be OSGi friendly.

I will happily tweak the bundle manifest but It is unlikely we will be able to replace Commons Logging with a different logging toolkit in the stable (4.x) branch. We can revisit the issue for HttpClient 5.0 (if that is of any consolation to you).

Oleg

> httpclient-osgi Requires commons-logging 1.1.1 exported in OSGi, which they have no plan to move forward with
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1019
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1019
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>    Affects Versions: 4.0.1, 4.0.2, 4.0.3
>            Reporter: Zach Calvert
>            Priority: Critical
>
> If you are trying to run the httpclient-osgi version 4.0.1, there is little opportunity to make it work without hand rolling your own apache commons logging.  Using the Maven descriptor:
>         <dependency>
>             <groupId>org.apache.httpcomponents</groupId>
>             <artifactId>httpclient-osgi</artifactId>
>             <version>4.0.1</version>
>         </dependency>
> You will find that the downloaded bundle manifest has:
> Import-Package: javax.crypto,javax.crypto.spec,javax.net.ssl,javax.sec
>  urity.auth.x500,org.apache.commons.logging;version="1.1.1",org.apache
> ...
> Emphasis on org.apache.commons.logging;version="1.1.1".  Basing my understanding of the bug at 
> https://issues.apache.org/jira/browse/LOGGING-124
> which I have also commented on, there is no such thing as an exported osgi package version 1.1.1 of commons logging due to problems with the OSGi classloader.  
> Support needs to be made to make commons logging optional in the osgi world and if the logging mechanism for commons logging isn't there, then move forward to something that doesn't make waves for the OSGi runtime.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

[jira] Commented: (HTTPCLIENT-1019) httpclient-osgi Requires commons-logging 1.1.1 exported in OSGi, which they have no plan to move forward with

Posted by "Zach Calvert (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925362#action_12925362 ] 

Zach Calvert commented on HTTPCLIENT-1019:
------------------------------------------

Hey Oleg,
I agree and I'm not trying to spark any problems here.  I just think that if the OSGi version of HTTPClient is going to require version 1.1.1 of the exported commons logging packages, then there needs to be an apache release of commons logging that has been bundlefied to export 1.1.1 of commons logging OR http client needs to make commons logging optional in its osgi flavor.

> httpclient-osgi Requires commons-logging 1.1.1 exported in OSGi, which they have no plan to move forward with
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1019
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1019
>             Project: HttpComponents HttpClient
>          Issue Type: New Feature
>          Components: HttpClient
>    Affects Versions: 4.0.1, 4.0.2, 4.0.3
>            Reporter: Zach Calvert
>             Fix For: Future
>
>
> If you are trying to run the httpclient-osgi version 4.0.1, there is little opportunity to make it work without hand rolling your own apache commons logging.  Using the Maven descriptor:
>         <dependency>
>             <groupId>org.apache.httpcomponents</groupId>
>             <artifactId>httpclient-osgi</artifactId>
>             <version>4.0.1</version>
>         </dependency>
> You will find that the downloaded bundle manifest has:
> Import-Package: javax.crypto,javax.crypto.spec,javax.net.ssl,javax.sec
>  urity.auth.x500,org.apache.commons.logging;version="1.1.1",org.apache
> ...
> Emphasis on org.apache.commons.logging;version="1.1.1".  Basing my understanding of the bug at 
> https://issues.apache.org/jira/browse/LOGGING-124
> which I have also commented on, there is no such thing as an exported osgi package version 1.1.1 of commons logging due to problems with the OSGi classloader.  
> Support needs to be made to make commons logging optional in the osgi world and if the logging mechanism for commons logging isn't there, then move forward to something that doesn't make waves for the OSGi runtime.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org