You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by gi...@git.apache.org on 2017/09/19 02:39:15 UTC

[GitHub] solin319 commented on issue #7893: Add barriers in kvstore init

solin319 commented on issue #7893: Add barriers in kvstore init
URL: https://github.com/apache/incubator-mxnet/pull/7893#issuecomment-330411554
 
 
   1. I found the "v.WaitToWrite()" in line 148 can't really wait until the push is finished. And this cause the barrier didn't work. So the  pull in workers (rank > 0) may process before the push finished in rank_0.
   2. In the function Push_, send_buf.var() was the const_vars in engine. But the send_buf was a new NDArray when "merged.ctx().dev_mask() != cpu::kDevMask". So the "values" pass to the function Push_ can be write just after "CopyFromTo(merged, &send_buf)" in line 285.
   3. I use "comm_buf_[key].WaitToWrite()" to solve this problem. "comm_buf_[key]" is the send_buf in function Push_ , and it can wait until the push finished.
   
   Is this method correct?
   
   @eric-haibin-lin  @piiswrong 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services