[GitHub] [incubator-skywalking] BFergerson commented on a change in pull request #2360: Async core APIs in java agent

[GitBox <gi...@apache.org>]

BFergerson commented on a change in pull request #2360: Async core APIs in java agent
URL: https://github.com/apache/incubator-skywalking/pull/2360#discussion_r266177717
 
 

 ##########
 File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/trace/AbstractTracingSpan.java
 ##########
 @@ -322,4 +320,19 @@ public AbstractSpan start(long startTime) {
             refs.add(ref);
         }
     }
+
+    @Override public AbstractSpan prepareForAsync() {
+        context = ContextManager.awaitFinishAsync(this);
 
 Review comment:
   `isInAsyncMode` is never set to true in this class. Did you mean:
   ```suggestion
           isInAsyncMode = true;
           context = ContextManager.awaitFinishAsync(this);
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services