[GitHub] spark pull request: [SPARK-3391][EC2] Support attaching up to 8 EB...

[shivaram <gi...@git.apache.org>]

Github user shivaram commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2260#discussion_r17129378
  
    --- Diff: ec2/spark_ec2.py ---
    @@ -348,13 +353,16 @@ def launch_cluster(conn, opts, cluster_name):
             print >> stderr, "Could not find AMI " + opts.ami
             sys.exit(1)
     
    -    # Create block device mapping so that we can add an EBS volume if asked to
    +    # Create block device mapping so that we can add EBS volumes if asked to.
    +    # The first drive is attached as /dev/sds, 2nd as /dev/sdt, ... /dev/sdz
         block_map = BlockDeviceMapping()
         if opts.ebs_vol_size > 0:
    -        device = EBSBlockDeviceType()
    -        device.size = opts.ebs_vol_size
    -        device.delete_on_termination = True
    -        block_map["/dev/sdv"] = device
    +        for i in range(opts.ebs_vol_num):
    +            device = EBSBlockDeviceType()
    +            device.size = opts.ebs_vol_size
    +            device.volume_type="gp2"
    --- End diff --
    
    what is gp2 ? Is this applicable to all instances etc. ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org