You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@uima.apache.org by "Burn Lewis (JIRA)" <de...@uima.apache.org> on 2012/07/13 20:11:36 UTC

[jira] [Created] (UIMA-2435) External Settings files are not closed

Burn Lewis created UIMA-2435:
--------------------------------

             Summary: External Settings files are not closed 
                 Key: UIMA-2435
                 URL: https://issues.apache.org/jira/browse/UIMA-2435
             Project: UIMA
          Issue Type: Bug
          Components: Core Java Framework
            Reporter: Burn Lewis
            Priority: Minor
             Fix For: 2.4.1SDK


After settings files are loaded they should be closed ... callers often forget ... should be safe to do it in the load method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (UIMA-2435) External Settings files are not closed

Posted by "Burn Lewis (JIRA)" <de...@uima.apache.org>.
     [ https://issues.apache.org/jira/browse/UIMA-2435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Burn Lewis resolved UIMA-2435.
------------------------------

    Resolution: Fixed

Close the streams opened in loadSystemDefaults
                
> External Settings files are not closed 
> ---------------------------------------
>
>                 Key: UIMA-2435
>                 URL: https://issues.apache.org/jira/browse/UIMA-2435
>             Project: UIMA
>          Issue Type: Bug
>          Components: Core Java Framework
>            Reporter: Burn Lewis
>            Priority: Minor
>             Fix For: 2.4.1SDK
>
>
> After settings files are loaded they should be closed ... callers often forget ... should be safe to do it in the load method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (UIMA-2435) External Settings files are not closed

Posted by "Burn Lewis (JIRA)" <de...@uima.apache.org>.
     [ https://issues.apache.org/jira/browse/UIMA-2435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Burn Lewis closed UIMA-2435.
----------------------------

    Assignee: Burn Lewis
    
> External Settings files are not closed 
> ---------------------------------------
>
>                 Key: UIMA-2435
>                 URL: https://issues.apache.org/jira/browse/UIMA-2435
>             Project: UIMA
>          Issue Type: Bug
>          Components: Core Java Framework
>            Reporter: Burn Lewis
>            Assignee: Burn Lewis
>            Priority: Minor
>             Fix For: 2.4.1SDK
>
>
> After settings files are loaded they should be closed ... callers often forget ... should be safe to do it in the load method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (UIMA-2435) External Settings files are not closed

Posted by "Marshall Schor (JIRA)" <de...@uima.apache.org>.
    [ https://issues.apache.org/jira/browse/UIMA-2435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413955#comment-13413955 ] 

Marshall Schor commented on UIMA-2435:
--------------------------------------

Not sure about the load method doing the closing... I think the general convention is to have the component that "opened" a stream be the one to close it.  It might surprise a developer in the future who opens a stream, calls load (passing the open stream), and then closes the stream, to get some error like "stream already closed".  (I haven't researched this, though, so it may be not a real issue).  I think it's a good idea to design systems to behave with "minimal surprise" :-)...
                
> External Settings files are not closed 
> ---------------------------------------
>
>                 Key: UIMA-2435
>                 URL: https://issues.apache.org/jira/browse/UIMA-2435
>             Project: UIMA
>          Issue Type: Bug
>          Components: Core Java Framework
>            Reporter: Burn Lewis
>            Priority: Minor
>             Fix For: 2.4.1SDK
>
>
> After settings files are loaded they should be closed ... callers often forget ... should be safe to do it in the load method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (UIMA-2435) External Settings files are not closed

Posted by "Burn Lewis (JIRA)" <de...@uima.apache.org>.
    [ https://issues.apache.org/jira/browse/UIMA-2435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13416530#comment-13416530 ] 

Burn Lewis commented on UIMA-2435:
----------------------------------

Closing a closed stream appears to be safe, but of course resetting a buffered stream will fail if closed.  So I'll follow the opener == closer convention in case of stream reuse. 
                
> External Settings files are not closed 
> ---------------------------------------
>
>                 Key: UIMA-2435
>                 URL: https://issues.apache.org/jira/browse/UIMA-2435
>             Project: UIMA
>          Issue Type: Bug
>          Components: Core Java Framework
>            Reporter: Burn Lewis
>            Priority: Minor
>             Fix For: 2.4.1SDK
>
>
> After settings files are loaded they should be closed ... callers often forget ... should be safe to do it in the load method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira