You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "kasiazjc (via GitHub)" <gi...@apache.org> on 2023/03/09 12:31:08 UTC

[GitHub] [superset] kasiazjc commented on pull request #23216: chore: Remove Cross Filter scoping modal

kasiazjc commented on PR #23216:
URL: https://github.com/apache/superset/pull/23216#issuecomment-1461960514

   > 1 more thing - the badge looks a bit weird when >= 10 filters are applied. I wonder if maybe we could change the shape to oval instead of a circle if there are 2 digits? @kasiazjc wdyt?
   > 
   > <img alt="image" width="352" src="https://user-images.githubusercontent.com/15073128/223774736-0abb2a31-8dd3-4a06-b867-708a1d612e65.png">
   
   Definitely agreed - my bad. Maybe we can just use the pill that is used in the "more filters" dropdown when filters are applied (horizontal filter bar)? (but keeping colors we have here) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org