You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "bereng (via GitHub)" <gi...@apache.org> on 2023/11/22 08:35:04 UTC
[PR] Cassandra 19050 5.0 [cassandra]
bereng opened a new pull request, #2927:
URL: https://github.com/apache/cassandra/pull/2927
Thanks for sending a pull request! Here are some tips if you're new here:
* Ensure you have added or run the [appropriate tests](https://cassandra.apache.org/_/development/testing.html) for your PR.
* Be sure to keep the PR description updated to reflect all changes.
* Write your PR title to summarize what this PR proposes.
* If possible, provide a concise example to reproduce the issue for a faster review.
* Read our [contributor guidelines](https://cassandra.apache.org/_/development/index.html)
* If you're making a documentation change, see our [guide to documentation contribution](https://cassandra.apache.org/_/development/documentation.html)
Commit messages should follow the following format:
```
<One sentence description, usually Jira title or CHANGES.txt summary>
<Optional lengthier description (context on patch)>
patch by <Authors>; reviewed by <Reviewers> for CASSANDRA-#####
Co-authored-by: Name1 <email1>
Co-authored-by: Name2 <email2>
```
The [Cassandra Jira](https://issues.apache.org/jira/projects/CASSANDRA/issues/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Cassandra 19050 5.0 [cassandra]
Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic commented on code in PR #2927:
URL: https://github.com/apache/cassandra/pull/2927#discussion_r1401783824
##########
test/unit/org/apache/cassandra/tools/JMXCompatabilityTest.java:
##########
@@ -72,6 +72,7 @@ public class JMXCompatabilityTest extends CQLTester
@BeforeClass
public static void setup() throws Exception
{
+ decorateCQLWithTestNames = false;
Review Comment:
@bereng could you rename this whole test? It is "JMXCompatibilityTest` not `Compatability'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Cassandra 19050 5.0 [cassandra]
Posted by "bereng (via GitHub)" <gi...@apache.org>.
bereng commented on PR #2927:
URL: https://github.com/apache/cassandra/pull/2927#issuecomment-1891838665
Ci [j11](https://app.circleci.com/pipelines/github/bereng/cassandra/1133/workflows/a1309702-40fa-478f-a033-a4b224449db3) [j17](https://app.circleci.com/pipelines/github/bereng/cassandra/1133/workflows/85236296-3588-4438-a8de-18e15ecba331)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Cassandra 19050 5.0 [cassandra]
Posted by "bereng (via GitHub)" <gi...@apache.org>.
bereng commented on code in PR #2927:
URL: https://github.com/apache/cassandra/pull/2927#discussion_r1401851110
##########
test/unit/org/apache/cassandra/tools/JMXCompatabilityTest.java:
##########
@@ -72,6 +72,7 @@ public class JMXCompatabilityTest extends CQLTester
@BeforeClass
public static void setup() throws Exception
{
+ decorateCQLWithTestNames = false;
Review Comment:
lol will do!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Cassandra 19050 5.0 [cassandra]
Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic commented on code in PR #2927:
URL: https://github.com/apache/cassandra/pull/2927#discussion_r1401783824
##########
test/unit/org/apache/cassandra/tools/JMXCompatabilityTest.java:
##########
@@ -72,6 +72,7 @@ public class JMXCompatabilityTest extends CQLTester
@BeforeClass
public static void setup() throws Exception
{
+ decorateCQLWithTestNames = false;
Review Comment:
@bereng could you rename this whole test? It is `JMXCompatibilityTest` not `Compatability'.
##########
test/unit/org/apache/cassandra/tools/JMXCompatabilityTest.java:
##########
@@ -72,6 +72,7 @@ public class JMXCompatabilityTest extends CQLTester
@BeforeClass
public static void setup() throws Exception
{
+ decorateCQLWithTestNames = false;
Review Comment:
@bereng could you rename this whole test while you are on it? It is `JMXCompatibilityTest` not `Compatability'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Cassandra 19050 5.0 [cassandra]
Posted by "bereng (via GitHub)" <gi...@apache.org>.
bereng commented on PR #2927:
URL: https://github.com/apache/cassandra/pull/2927#issuecomment-1822408134
Given CQLTester is widely used and sometimes cross-referenced the [j11](https://app.circleci.com/pipelines/github/bereng/cassandra/1121/workflows/3df2bb12-9795-4d4f-889a-1776fdffe8ad) CI is an extensive one. The [j17](https://app.circleci.com/pipelines/github/bereng/cassandra/1121/workflows/6b44a166-eaa5-4a1d-830c-25d82460bb5f) is just junit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Cassandra 19050 5.0 [cassandra]
Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic commented on code in PR #2927:
URL: https://github.com/apache/cassandra/pull/2927#discussion_r1401783824
##########
test/unit/org/apache/cassandra/tools/JMXCompatabilityTest.java:
##########
@@ -72,6 +72,7 @@ public class JMXCompatabilityTest extends CQLTester
@BeforeClass
public static void setup() throws Exception
{
+ decorateCQLWithTestNames = false;
Review Comment:
@bereng could you rename this whole test while you are on it? It is `JMXCompatibilityTest` not `Compatability`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Cassandra 19050 5.0 [cassandra]
Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic commented on code in PR #2927:
URL: https://github.com/apache/cassandra/pull/2927#discussion_r1401783824
##########
test/unit/org/apache/cassandra/tools/JMXCompatabilityTest.java:
##########
@@ -72,6 +72,7 @@ public class JMXCompatabilityTest extends CQLTester
@BeforeClass
public static void setup() throws Exception
{
+ decorateCQLWithTestNames = false;
Review Comment:
@bereng could you rename this whole test while you are on it? It is `JMXCompatibilityTest` not `JMXCompatabilityTest`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Cassandra 19050 5.0 [cassandra]
Posted by "bereng (via GitHub)" <gi...@apache.org>.
bereng commented on PR #2927:
URL: https://github.com/apache/cassandra/pull/2927#issuecomment-1822322918
It is very tempting to try to extract the repeated code into a function. But given the variations on the format string, the sequential numbering, etc it becomes a mess so I left it as it is...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Cassandra 19050 5.0 [cassandra]
Posted by "bereng (via GitHub)" <gi...@apache.org>.
bereng closed pull request #2927: Cassandra 19050 5.0
URL: https://github.com/apache/cassandra/pull/2927
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org