You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "morningman (via GitHub)" <gi...@apache.org> on 2024/03/12 10:18:18 UTC
[PR] [fix](profile) avoid update profile in deconstructor [doris]
morningman opened a new pull request, #32131:
URL: https://github.com/apache/doris/pull/32131
## Proposed changes
In previous, the counter in `profile` may be updated when close the file reader.
And the file reader may be closed when the object being deconstruted.
But at that time, the `profile` object may already be deleted, causing NPE and BE will crash.
This PR try to fix this issue:
1. Remove the "profile counter update" logic from all `close()` method.
2. Add a new interface `ProfileCollector`
It has 2 methods:
- `collect_profile_at_runtime()`
It can be called at runtime, eg, in every `get_next_block()` method.
So that the counter in profile can be updated at runtime.
- `collect_profile_before_close()`
Should be called before the object call `close()`. And it will only be called once.
3. Derived from `ProfileCollector`
All classes which may update the profile counter in `close()` method should extends
the `ProfileCollector`. Such as `GenericReader`, etc. And implement `collect_profile_before_close()`
And `collect_profile_before_close()` will be called in `scanner->mark_to_need_to_close()`.
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](profile) avoid update profile in deconstructor [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #32131:
URL: https://github.com/apache/doris/pull/32131#issuecomment-1996250374
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](profile) avoid update profile in deconstructor [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32131:
URL: https://github.com/apache/doris/pull/32131#issuecomment-2002690561
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](profile) avoid update profile in deconstructor [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32131:
URL: https://github.com/apache/doris/pull/32131#issuecomment-1993237620
<details>
<summary>TPC-DS: <b>Total hot run time: 186366 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d5b2c62cd1291eff5976ca7c06b7ccf879365881, data reload: false
query1 911 371 347 347
query2 7376 1973 1894 1894
query3 6715 219 209 209
query4 31191 20868 20788 20788
query5 4406 421 403 403
query6 265 177 168 168
query7 4625 282 288 282
query8 231 170 169 169
query9 10004 2276 2232 2232
query10 455 265 249 249
query11 15542 14284 14177 14177
query12 139 89 79 79
query13 1645 429 434 429
query14 10968 10542 11289 10542
query15 263 219 195 195
query16 7873 252 249 249
query17 1962 543 537 537
query18 2038 277 270 270
query19 271 158 147 147
query20 88 86 85 85
query21 199 125 122 122
query22 4625 4496 4445 4445
query23 31687 31048 30887 30887
query24 10742 2868 2807 2807
query25 583 379 371 371
query26 758 154 162 154
query27 2278 339 348 339
query28 6603 1914 1847 1847
query29 878 646 643 643
query30 306 149 148 148
query31 984 709 733 709
query32 95 64 59 59
query33 769 263 254 254
query34 1048 466 473 466
query35 842 608 606 606
query36 1004 894 864 864
query37 124 80 81 80
query38 3241 3185 3099 3099
query39 1397 1375 1366 1366
query40 213 109 112 109
query41 49 50 46 46
query42 102 93 100 93
query43 473 455 451 451
query44 1173 741 717 717
query45 273 253 232 232
query46 1083 681 681 681
query47 1682 1577 1602 1577
query48 448 352 346 346
query49 1114 348 343 343
query50 761 375 371 371
query51 6716 6576 6649 6576
query52 114 91 93 91
query53 340 281 280 280
query54 306 239 238 238
query55 86 78 78 78
query56 242 245 231 231
query57 1088 1013 990 990
query58 227 209 202 202
query59 2777 2488 2435 2435
query60 295 240 257 240
query61 114 111 110 110
query62 585 406 393 393
query63 311 273 279 273
query64 5514 3933 3846 3846
query65 3055 3007 3052 3007
query66 852 333 336 333
query67 14581 14306 14099 14099
query68 8863 534 537 534
query69 638 390 382 382
query70 1241 1137 1126 1126
query71 533 288 277 277
query72 6610 2654 2503 2503
query73 806 317 318 317
query74 7233 6491 6574 6491
query75 9545 8004 8126 8004
query76 5279 919 957 919
query77 658 276 259 259
query78 10382 9630 9582 9582
query79 11943 521 537 521
query80 1785 388 372 372
query81 514 216 215 215
query82 327 200 195 195
query83 213 150 152 150
query84 287 79 78 78
query85 936 324 316 316
query86 354 315 307 307
query87 3384 3255 3231 3231
query88 5290 2296 2295 2295
query89 489 367 362 362
query90 2029 176 174 174
query91 162 127 131 127
query92 63 46 46 46
query93 6796 518 496 496
query94 1350 180 177 177
query95 448 335 324 324
query96 620 267 265 265
query97 4411 4264 4290 4264
query98 232 217 210 210
query99 1027 742 755 742
Total cold run time: 314153 ms
Total hot run time: 186366 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](profile) avoid update profile in deconstructor [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32131:
URL: https://github.com/apache/doris/pull/32131#issuecomment-1993203792
TeamCity be ut coverage result:
Function Coverage: 34.94% (8558/24492)
Line Coverage: 26.80% (69531/259490)
Region Coverage: 26.04% (36077/138547)
Branch Coverage: 23.01% (18442/80148)
Coverage Report: http://coverage.selectdb-in.cc/coverage/d5b2c62cd1291eff5976ca7c06b7ccf879365881_d5b2c62cd1291eff5976ca7c06b7ccf879365881/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](profile) avoid update profile in deconstructor [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32131:
URL: https://github.com/apache/doris/pull/32131#issuecomment-1993258732
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit d5b2c62cd1291eff5976ca7c06b7ccf879365881 with default session variables
Stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
Stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select: 16.7 seconds inserted 10000000 Rows, about 598K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](profile) avoid update profile in deconstructor [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32131:
URL: https://github.com/apache/doris/pull/32131#issuecomment-1996284976
TeamCity be ut coverage result:
Function Coverage: 34.98% (8577/24521)
Line Coverage: 26.75% (69477/259717)
Region Coverage: 26.02% (36080/138670)
Branch Coverage: 22.97% (18420/80188)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f89b842c52952f09bc6fb1708e59590db5d892d7_f89b842c52952f09bc6fb1708e59590db5d892d7/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](profile) avoid update profile in deconstructor [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman merged PR #32131:
URL: https://github.com/apache/doris/pull/32131
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](profile) avoid update profile in deconstructor [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32131:
URL: https://github.com/apache/doris/pull/32131#issuecomment-1993207825
<details>
<summary>TPC-H: <b>Total hot run time: 36757 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d5b2c62cd1291eff5976ca7c06b7ccf879365881, data reload: false
------ Round 1 ----------------------------------
q1 17618 4472 4105 4105
q2 2037 152 150 150
q3 10565 956 904 904
q4 4655 726 809 726
q5 7597 2800 2802 2800
q6 200 122 130 122
q7 1211 843 808 808
q8 9484 2077 2055 2055
q9 7371 6479 6453 6453
q10 8137 2480 2530 2480
q11 413 218 228 218
q12 767 294 293 293
q13 17962 2999 3008 2999
q14 270 242 250 242
q15 506 456 452 452
q16 480 407 399 399
q17 951 530 609 530
q18 6750 5892 5768 5768
q19 1571 1496 1405 1405
q20 567 277 279 277
q21 7390 3301 3281 3281
q22 840 290 291 290
Total cold run time: 107342 ms
Total hot run time: 36757 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4099 4122 4095 4095
q2 324 229 226 226
q3 3017 2887 2872 2872
q4 1824 1502 1559 1502
q5 5197 5258 5276 5258
q6 199 117 117 117
q7 2275 1839 1809 1809
q8 3156 3306 3305 3305
q9 8540 8541 8550 8541
q10 6160 3724 3639 3639
q11 537 440 444 440
q12 756 599 597 597
q13 11734 2860 2873 2860
q14 276 262 255 255
q15 485 443 438 438
q16 463 421 416 416
q17 1740 1490 1471 1471
q18 7626 7286 7150 7150
q19 7457 1537 1578 1537
q20 1891 1719 1692 1692
q21 4859 4641 4610 4610
q22 506 453 444 444
Total cold run time: 73121 ms
Total hot run time: 53274 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](profile) avoid update profile in deconstructor [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #32131:
URL: https://github.com/apache/doris/pull/32131#issuecomment-1993073976
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](profile) avoid update profile in deconstructor [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32131:
URL: https://github.com/apache/doris/pull/32131#issuecomment-1996563033
<details>
<summary>TPC-H: <b>Total hot run time: 38685 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b895bcb8e38c598007a2b763aaf173a1d7767323, data reload: false
------ Round 1 ----------------------------------
q1 17696 4542 4121 4121
q2 2023 160 146 146
q3 10683 1099 915 915
q4 6760 749 737 737
q5 7482 2782 2743 2743
q6 186 121 128 121
q7 1186 842 818 818
q8 9427 2084 2047 2047
q9 7121 6473 6438 6438
q10 8495 3528 3625 3528
q11 424 229 223 223
q12 700 304 301 301
q13 17810 2869 2871 2869
q14 287 257 244 244
q15 504 462 482 462
q16 487 395 396 395
q17 961 534 614 534
q18 7395 6562 6512 6512
q19 3605 1477 1402 1402
q20 552 281 285 281
q21 6445 3536 3557 3536
q22 372 312 314 312
Total cold run time: 110601 ms
Total hot run time: 38685 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4271 4088 4137 4088
q2 319 222 230 222
q3 3021 2884 2847 2847
q4 1855 1524 1555 1524
q5 5243 5315 5281 5281
q6 196 117 125 117
q7 2288 1858 1851 1851
q8 3154 3314 3322 3314
q9 8602 8596 8554 8554
q10 3725 3670 3688 3670
q11 568 453 448 448
q12 717 552 541 541
q13 16908 2860 2835 2835
q14 279 238 262 238
q15 492 450 449 449
q16 478 424 422 422
q17 1736 1492 1470 1470
q18 7598 7407 7110 7110
q19 1613 1557 1532 1532
q20 1915 1709 1696 1696
q21 4911 4651 4752 4651
q22 543 447 478 447
Total cold run time: 70432 ms
Total hot run time: 53307 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](profile) avoid update profile in deconstructor [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #32131:
URL: https://github.com/apache/doris/pull/32131#issuecomment-1996466101
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](profile) avoid update profile in deconstructor [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #32131:
URL: https://github.com/apache/doris/pull/32131#discussion_r1524245991
##########
be/src/util/profile_collector.h:
##########
@@ -0,0 +1,45 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+
+#include <atomic>
+
+namespace doris {
+
+class ProfileCollector {
+public:
+ void collect_profile_at_runtime() { _collect_profile_at_runtime(); }
+
+ void collect_profile_before_close() {
+ bool expected = false;
+ if (_collected.compare_exchange_strong(expected, true, std::memory_order_acq_rel)) {
+ _collect_profile_before_close();
+ }
+ }
+
+ virtual ~ProfileCollector() {}
Review Comment:
warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
```suggestion
virtual ~ProfileCollector() = default;
```
##########
be/src/vec/exec/scan/new_olap_scanner.cpp:
##########
@@ -554,14 +554,14 @@ void NewOlapScanner::_update_realtime_counters() {
_tablet_reader->mutable_stats()->raw_rows_read = 0;
}
-void NewOlapScanner::_update_counters_before_close() {
+void NewOlapScanner::_collect_profile_before_close() {
Review Comment:
warning: function '_collect_profile_before_close' exceeds recommended size/complexity thresholds [readability-function-size]
```cpp
void NewOlapScanner::_collect_profile_before_close() {
^
```
<details>
<summary>Additional context</summary>
**be/src/vec/exec/scan/new_olap_scanner.cpp:556:** 112 lines including whitespace and comments (threshold 80)
```cpp
void NewOlapScanner::_collect_profile_before_close() {
^
```
</details>
##########
be/src/vec/exec/format/table/table_format_reader.h:
##########
@@ -57,6 +57,13 @@ class TableFormatReader : public GenericReader {
virtual Status init_row_filters(const TFileRangeDesc& range) = 0;
+protected:
+ void _collect_profile_before_close() override {
+ if (_file_format_reader != nullptr) {
+ _file_format_reader->collect_profile_before_close();
+ }
+ }
+
protected:
Review Comment:
warning: redundant access specifier has the same accessibility as the previous access specifier [readability-redundant-access-specifiers]
```suggestion
```
<details>
<summary>Additional context</summary>
**be/src/vec/exec/format/table/table_format_reader.h:59:** previously declared here
```cpp
protected:
^
```
</details>
##########
be/src/vec/exec/format/parquet/vparquet_reader.h:
##########
@@ -210,7 +213,9 @@ class ParquetReader : public GenericReader {
std::string _meta_cache_key(const std::string& path) { return "meta_" + path; }
std::vector<io::PrefetchRange> _generate_random_access_ranges(
const RowGroupReader::RowGroupIndex& group, size_t* avg_io_size);
+ void _collect_profile();
+private:
Review Comment:
warning: redundant access specifier has the same accessibility as the previous access specifier [readability-redundant-access-specifiers]
```suggestion
```
<details>
<summary>Additional context</summary>
**be/src/vec/exec/format/parquet/vparquet_reader.h:156:** previously declared here
```cpp
private:
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](profile) avoid update profile in deconstructor [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32131:
URL: https://github.com/apache/doris/pull/32131#issuecomment-1996571425
TeamCity be ut coverage result:
Function Coverage: 34.98% (8575/24515)
Line Coverage: 26.74% (69462/259758)
Region Coverage: 26.01% (36072/138688)
Branch Coverage: 22.96% (18418/80202)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b895bcb8e38c598007a2b763aaf173a1d7767323_b895bcb8e38c598007a2b763aaf173a1d7767323/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](profile) avoid update profile in deconstructor [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32131:
URL: https://github.com/apache/doris/pull/32131#issuecomment-1993250894
<details>
<summary>ClickBench: <b>Total hot run time: 29.49 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d5b2c62cd1291eff5976ca7c06b7ccf879365881, data reload: false
query1 0.04 0.03 0.03
query2 0.07 0.03 0.03
query3 0.22 0.07 0.07
query4 1.65 0.10 0.11
query5 0.53 0.52 0.52
query6 1.19 0.61 0.63
query7 0.02 0.02 0.02
query8 0.04 0.03 0.02
query9 0.55 0.51 0.51
query10 0.55 0.53 0.56
query11 0.12 0.09 0.09
query12 0.12 0.09 0.09
query13 0.56 0.56 0.58
query14 0.73 0.76 0.74
query15 0.80 0.78 0.77
query16 0.37 0.40 0.40
query17 0.97 1.02 1.01
query18 0.19 0.28 0.23
query19 1.73 1.64 1.66
query20 0.01 0.01 0.01
query21 15.43 0.57 0.55
query22 3.00 2.19 2.00
query23 17.24 0.89 0.79
query24 3.20 1.19 0.13
query25 0.09 0.04 0.05
query26 0.50 0.12 0.11
query27 0.03 0.04 0.03
query28 12.21 0.86 0.86
query29 12.57 3.27 3.03
query30 0.64 0.61 0.54
query31 2.80 0.34 0.32
query32 3.37 0.43 0.44
query33 2.78 2.83 2.80
query34 16.18 4.34 4.28
query35 4.37 4.28 4.32
query36 1.06 1.03 1.02
query37 0.08 0.05 0.06
query38 0.04 0.03 0.04
query39 0.03 0.02 0.02
query40 0.18 0.13 0.13
query41 0.07 0.02 0.02
query42 0.03 0.02 0.02
query43 0.03 0.03 0.03
Total cold run time: 106.39 s
Total hot run time: 29.49 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](profile) avoid update profile in deconstructor [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32131:
URL: https://github.com/apache/doris/pull/32131#issuecomment-1996287377
<details>
<summary>TPC-H: <b>Total hot run time: 38351 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f89b842c52952f09bc6fb1708e59590db5d892d7, data reload: false
------ Round 1 ----------------------------------
q1 17663 4205 4115 4115
q2 2033 154 143 143
q3 10675 1116 915 915
q4 7785 739 720 720
q5 7469 2619 2597 2597
q6 197 121 130 121
q7 1216 821 817 817
q8 9342 2027 2048 2027
q9 7192 6442 6456 6442
q10 8489 3544 3680 3544
q11 445 231 221 221
q12 614 295 296 295
q13 17818 2850 2875 2850
q14 269 254 248 248
q15 501 454 446 446
q16 495 390 394 390
q17 965 555 558 555
q18 7364 6610 6399 6399
q19 3484 1401 1437 1401
q20 560 280 275 275
q21 6274 3535 3615 3535
q22 362 295 305 295
Total cold run time: 111212 ms
Total hot run time: 38351 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4118 4069 4088 4069
q2 322 232 222 222
q3 2989 2869 2847 2847
q4 1865 1544 1596 1544
q5 5220 5273 5452 5273
q6 197 114 118 114
q7 2204 1904 1804 1804
q8 3174 3290 3307 3290
q9 8528 8491 8535 8491
q10 3716 3679 3676 3676
q11 551 444 444 444
q12 737 544 529 529
q13 16911 2857 2841 2841
q14 280 247 266 247
q15 482 443 443 443
q16 449 415 423 415
q17 1732 1485 1455 1455
q18 7564 7098 7222 7098
q19 1619 1521 1603 1521
q20 1906 1684 1698 1684
q21 4934 4637 4735 4637
q22 519 476 471 471
Total cold run time: 70017 ms
Total hot run time: 53115 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](profile) avoid update profile in deconstructor [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32131:
URL: https://github.com/apache/doris/pull/32131#issuecomment-1991281233
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](profile) avoid update profile in deconstructor [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32131:
URL: https://github.com/apache/doris/pull/32131#issuecomment-2002502080
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org