You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/01/28 20:30:20 UTC
[GitHub] [spark] MaxGekk opened a new pull request #31387: [WIP][SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests
MaxGekk opened a new pull request #31387:
URL: https://github.com/apache/spark/pull/31387
### What changes were proposed in this pull request?
1. Port DS v1 tests from `DDLSuite` to `v1.TruncateTableSuiteBase` and to `v1.TruncateTableSuite`.
### Why are the changes needed?
To improve test coverage.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
By running new test suites:
```
$ build/sbt -Phive-2.3 -Phive-thriftserver "test:testOnly *TruncateTableSuite"
$ build/sbt -Phive-2.3 -Phive-thriftserver "test:testOnly *CatalogedDDLSuite"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31387: [WIP][SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31387:
URL: https://github.com/apache/spark/pull/31387#issuecomment-769817891
**[Test build #134649 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134649/testReport)** for PR 31387 at commit [`2b0c5f4`](https://github.com/apache/spark/commit/2b0c5f405660477218feb61ae3718ede9e589b60).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class TruncateTableParserSuite extends AnalysisTest with SharedSparkSession `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31387: [WIP][SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31387:
URL: https://github.com/apache/spark/pull/31387#issuecomment-769694058
**[Test build #134649 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134649/testReport)** for PR 31387 at commit [`2b0c5f4`](https://github.com/apache/spark/commit/2b0c5f405660477218feb61ae3718ede9e589b60).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31387: [SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31387:
URL: https://github.com/apache/spark/pull/31387#issuecomment-771526874
**[Test build #134775 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134775/testReport)** for PR 31387 at commit [`48fcae0`](https://github.com/apache/spark/commit/48fcae03b30bf6a8f37fe8a4610cb6ea5e068fd5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31387: [WIP][SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31387:
URL: https://github.com/apache/spark/pull/31387#issuecomment-769753600
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39237/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31387: [SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31387:
URL: https://github.com/apache/spark/pull/31387#issuecomment-770271741
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39264/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31387: [WIP][SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31387:
URL: https://github.com/apache/spark/pull/31387#issuecomment-769445990
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134626/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #31387: [SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #31387:
URL: https://github.com/apache/spark/pull/31387#issuecomment-770218265
@cloud-fan @HyukjinKwon Please, review this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31387: [WIP][SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31387:
URL: https://github.com/apache/spark/pull/31387#issuecomment-769733928
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39237/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31387: [SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31387:
URL: https://github.com/apache/spark/pull/31387#issuecomment-771526874
**[Test build #134775 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134775/testReport)** for PR 31387 at commit [`48fcae0`](https://github.com/apache/spark/commit/48fcae03b30bf6a8f37fe8a4610cb6ea5e068fd5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31387: [SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31387:
URL: https://github.com/apache/spark/pull/31387#issuecomment-770223813
**[Test build #134675 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134675/testReport)** for PR 31387 at commit [`ab34310`](https://github.com/apache/spark/commit/ab34310f354b76be2e4723a3d9a0124906580b7d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31387: [SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31387:
URL: https://github.com/apache/spark/pull/31387#issuecomment-770277756
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39264/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31387: [SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31387:
URL: https://github.com/apache/spark/pull/31387#issuecomment-771675332
thanks, merging to master!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31387: [SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31387:
URL: https://github.com/apache/spark/pull/31387#issuecomment-771583471
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #31387: [SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #31387:
URL: https://github.com/apache/spark/pull/31387
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31387: [WIP][SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31387:
URL: https://github.com/apache/spark/pull/31387#issuecomment-769444435
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39214/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31387: [SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31387:
URL: https://github.com/apache/spark/pull/31387#issuecomment-771668019
**[Test build #134775 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134775/testReport)** for PR 31387 at commit [`48fcae0`](https://github.com/apache/spark/commit/48fcae03b30bf6a8f37fe8a4610cb6ea5e068fd5).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31387: [WIP][SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31387:
URL: https://github.com/apache/spark/pull/31387#issuecomment-769380220
**[Test build #134626 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134626/testReport)** for PR 31387 at commit [`ae4389c`](https://github.com/apache/spark/commit/ae4389c40fa38b97fcaf82808c20238d0e9483d6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31387: [SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31387:
URL: https://github.com/apache/spark/pull/31387#issuecomment-770245503
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39262/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31387: [SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31387:
URL: https://github.com/apache/spark/pull/31387#issuecomment-771675332
thanks, merging to master!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31387: [SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31387:
URL: https://github.com/apache/spark/pull/31387#issuecomment-770262019
**[Test build #134677 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134677/testReport)** for PR 31387 at commit [`4a7b7ca`](https://github.com/apache/spark/commit/4a7b7ca0920c83e4a8461d8db2dc452b05a37cc8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31387: [SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31387:
URL: https://github.com/apache/spark/pull/31387#issuecomment-770298420
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134677/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31387: [WIP][SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31387:
URL: https://github.com/apache/spark/pull/31387#issuecomment-769721598
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39237/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31387: [SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31387:
URL: https://github.com/apache/spark/pull/31387#issuecomment-770294654
**[Test build #134677 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134677/testReport)** for PR 31387 at commit [`4a7b7ca`](https://github.com/apache/spark/commit/4a7b7ca0920c83e4a8461d8db2dc452b05a37cc8).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #31387: [SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #31387:
URL: https://github.com/apache/spark/pull/31387#discussion_r567898359
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/v2/TruncateTableSuite.scala
##########
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.command.v2
+
+import org.apache.spark.sql.AnalysisException
+import org.apache.spark.sql.execution.command
+
+/**
+ * The class contains tests for the `TRUNCATE TABLE` command to check V2 table catalogs.
+ */
+class TruncateTableSuite extends command.TruncateTableSuiteBase with CommandSuiteBase {
+
+ // TODO(SPARK-34290): Support v2 TRUNCATE TABLE
Review comment:
The v2 API is ready, and this should be easy to do?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31387: [SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31387:
URL: https://github.com/apache/spark/pull/31387#issuecomment-771583471
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39361/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31387: [SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31387:
URL: https://github.com/apache/spark/pull/31387#issuecomment-770249694
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39262/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31387: [WIP][SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31387:
URL: https://github.com/apache/spark/pull/31387#issuecomment-769444435
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39214/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31387: [SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31387:
URL: https://github.com/apache/spark/pull/31387#issuecomment-770223813
**[Test build #134675 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134675/testReport)** for PR 31387 at commit [`ab34310`](https://github.com/apache/spark/commit/ab34310f354b76be2e4723a3d9a0124906580b7d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31387: [SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31387:
URL: https://github.com/apache/spark/pull/31387#issuecomment-770270031
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134675/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31387: [SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31387:
URL: https://github.com/apache/spark/pull/31387#issuecomment-770249694
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39262/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31387: [SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31387:
URL: https://github.com/apache/spark/pull/31387#issuecomment-770270031
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134675/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31387: [WIP][SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31387:
URL: https://github.com/apache/spark/pull/31387#issuecomment-769694058
**[Test build #134649 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134649/testReport)** for PR 31387 at commit [`2b0c5f4`](https://github.com/apache/spark/commit/2b0c5f405660477218feb61ae3718ede9e589b60).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31387: [SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31387:
URL: https://github.com/apache/spark/pull/31387#issuecomment-770262019
**[Test build #134677 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134677/testReport)** for PR 31387 at commit [`4a7b7ca`](https://github.com/apache/spark/commit/4a7b7ca0920c83e4a8461d8db2dc452b05a37cc8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #31387: [SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #31387:
URL: https://github.com/apache/spark/pull/31387
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31387: [SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31387:
URL: https://github.com/apache/spark/pull/31387#issuecomment-771567544
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39361/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31387: [SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31387:
URL: https://github.com/apache/spark/pull/31387#issuecomment-771552428
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39361/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31387: [WIP][SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31387:
URL: https://github.com/apache/spark/pull/31387#issuecomment-769842851
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134649/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31387: [SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31387:
URL: https://github.com/apache/spark/pull/31387#issuecomment-771526874
**[Test build #134775 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134775/testReport)** for PR 31387 at commit [`48fcae0`](https://github.com/apache/spark/commit/48fcae03b30bf6a8f37fe8a4610cb6ea5e068fd5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31387: [SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31387:
URL: https://github.com/apache/spark/pull/31387#issuecomment-770230486
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39262/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31387: [SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31387:
URL: https://github.com/apache/spark/pull/31387#issuecomment-770268197
**[Test build #134675 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134675/testReport)** for PR 31387 at commit [`ab34310`](https://github.com/apache/spark/commit/ab34310f354b76be2e4723a3d9a0124906580b7d).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31387: [SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31387:
URL: https://github.com/apache/spark/pull/31387#issuecomment-771583471
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31387: [SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31387:
URL: https://github.com/apache/spark/pull/31387#issuecomment-770277756
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #31387: [SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #31387:
URL: https://github.com/apache/spark/pull/31387#discussion_r567900934
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/v2/TruncateTableSuite.scala
##########
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.command.v2
+
+import org.apache.spark.sql.AnalysisException
+import org.apache.spark.sql.execution.command
+
+/**
+ * The class contains tests for the `TRUNCATE TABLE` command to check V2 table catalogs.
+ */
+class TruncateTableSuite extends command.TruncateTableSuiteBase with CommandSuiteBase {
+
+ // TODO(SPARK-34290): Support v2 TRUNCATE TABLE
Review comment:
Not yet, this https://github.com/apache/spark/pull/31420 is the first step.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31387: [WIP][SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31387:
URL: https://github.com/apache/spark/pull/31387#issuecomment-769842851
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134649/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31387: [SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31387:
URL: https://github.com/apache/spark/pull/31387#issuecomment-771690640
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134775/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31387: [SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31387:
URL: https://github.com/apache/spark/pull/31387#issuecomment-771583471
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31387: [WIP][SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31387:
URL: https://github.com/apache/spark/pull/31387#issuecomment-769445990
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134626/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31387: [SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31387:
URL: https://github.com/apache/spark/pull/31387#issuecomment-771526874
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31387: [SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31387:
URL: https://github.com/apache/spark/pull/31387#issuecomment-770267826
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39264/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31387: [WIP][SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31387:
URL: https://github.com/apache/spark/pull/31387#issuecomment-769753600
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39237/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org