You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/12/28 19:30:42 UTC
[GitHub] [iceberg] rdblue commented on a change in pull request #1996: Flink: Transform INSERT as one DELETE following one INSERT if configure to use UPSERT
rdblue commented on a change in pull request #1996:
URL: https://github.com/apache/iceberg/pull/1996#discussion_r549462204
##########
File path: flink/src/main/java/org/apache/iceberg/flink/sink/FlinkSink.java
##########
@@ -172,6 +174,20 @@ public Builder writeParallelism(int newWriteParallelism) {
return this;
}
+ /**
+ * All INSERT/UPDATE_AFTER events from input stream will be transformed to UPSERT events, which means it will
+ * DELETE the old records and then INSERT the new records. In partitioned table, the partition fields should be
+ * a subset of equality fields, otherwise the old row that located in partition-A could not be deleted by the
+ * new row that located in partition-B.
Review comment:
Does anything validate this constraint?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org