You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/06 19:16:43 UTC
[GitHub] [arrow] nealrichardson opened a new pull request, #13086: ARROW-16414: [R] Remove ARROW_R_WITH_ARROW and arrow_available()
nealrichardson opened a new pull request, #13086:
URL: https://github.com/apache/arrow/pull/13086
The diff looks bigger than that because
* Sometimes those changes just resulted in reducing indentation
* I moved arrow_info() and related functions to their own file, and did the same with ArrowObject while I was there
* The way we were wrapping testthat::test_that to check whether arrow was available had a side effect of creating a closure that stored intermediate objects that we reused across tests, and that broke when I removed it.
* I didn't have styler configured correctly in vscode when I started because I had upgraded R to 4.2, so to fix what I had already committed that was unstyled, I ran `make style-all` across everything, which reformatted a bunch of unrelated code.
I tried to pull on all threads I noticed where we were doing things an unnatural way because we couldn't assume that arrow was present, but there may be more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on a diff in pull request #13086: ARROW-16414: [R] Remove ARROW_R_WITH_ARROW and arrow_available()
Posted by GitBox <gi...@apache.org>.
jonkeane commented on code in PR #13086:
URL: https://github.com/apache/arrow/pull/13086#discussion_r867257196
##########
r/R/arrow-package.R:
##########
@@ -80,90 +78,29 @@
}
}
- if (arrow_available()) {
- # register extension types that we use internally
- reregister_extension_type(vctrs_extension_type(vctrs::unspecified()))
- }
+ # register extension types that we use internally
+ reregister_extension_type(vctrs_extension_type(vctrs::unspecified()))
invisible()
}
.onAttach <- function(libname, pkgname) {
- if (!arrow_available()) {
- msg <- paste(
- "The Arrow C++ library is not available. To retry installation with debug output, run:",
- " install_arrow(verbose = TRUE)",
- "See https://arrow.apache.org/docs/r/articles/install.html for more guidance and troubleshooting.",
- sep = "\n"
- )
- packageStartupMessage(msg)
- } else {
- # Just to be extra safe, let's wrap this in a try();
- # we don't a failed startup message to prevent the package from loading
- try({
- features <- arrow_info()$capabilities
- # That has all of the #ifdef features, plus the compression libs and the
- # string libraries (but not the memory allocators, they're added elsewhere)
- #
- # Let's print a message if some are off
- if (some_features_are_off(features)) {
- packageStartupMessage(
- paste(
- "Some features are not enabled in this build of Arrow.",
- "Run `arrow_info()` for more information."
- )
+ # Just to be extra safe, let's wrap this in a try();
+ # we don't a failed startup message to prevent the package from loading
Review Comment:
```suggestion
# we don't want a failed startup message to prevent the package from loading
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson closed pull request #13086: ARROW-16414: [R] Remove ARROW_R_WITH_ARROW and arrow_available()
Posted by GitBox <gi...@apache.org>.
nealrichardson closed pull request #13086: ARROW-16414: [R] Remove ARROW_R_WITH_ARROW and arrow_available()
URL: https://github.com/apache/arrow/pull/13086
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13086: ARROW-16414: [R] Remove ARROW_R_WITH_ARROW and arrow_available()
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13086:
URL: https://github.com/apache/arrow/pull/13086#issuecomment-1119940068
https://issues.apache.org/jira/browse/ARROW-16414
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #13086: ARROW-16414: [R] Remove ARROW_R_WITH_ARROW and arrow_available()
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13086:
URL: https://github.com/apache/arrow/pull/13086#issuecomment-1125294248
Benchmark runs are scheduled for baseline = dc23c67b7f3d15d54eba860650b74f969fb4f06c and contender = 824f58f7df4043ba41351ee1b75d4293521e1ad8. 824f58f7df4043ba41351ee1b75d4293521e1ad8 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/13d00d412e5342368960204ae8fb3c1a...e1da6cd0cc904bbeadd1b237c75d271b/)
[Finished :arrow_down:0.86% :arrow_up:0.04%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/0fb3b361736b4492a3869257fa1acf6c...944a1da65a8c41ada35d6b17779719a4/)
[Failed :arrow_down:0.36% :arrow_up:1.43%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/731524771ff647f99c5841c4fa5d30ef...75cc65cea07240e0bd8c5076516d1ffb/)
[Finished :arrow_down:0.35% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/48e0e93d37c54a84ade0dee01dd29122...952c1078f1474e68a15008575c4d5fba/)
Buildkite builds:
[Finished] [`824f58f7` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/735)
[Finished] [`824f58f7` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/732)
[Failed] [`824f58f7` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/722)
[Finished] [`824f58f7` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/737)
[Finished] [`dc23c67b` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/734)
[Finished] [`dc23c67b` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/731)
[Failed] [`dc23c67b` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/721)
[Finished] [`dc23c67b` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/736)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org