You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "mihaibudiu (via GitHub)" <gi...@apache.org> on 2023/10/13 06:04:14 UTC
Re: [PR] [CALCITE-5921] SqlOperatorFixture.checkFails and checkAggFails don't check runtime failure [calcite]
mihaibudiu commented on code in PR #3412:
URL: https://github.com/apache/calcite/pull/3412#discussion_r1357802519
##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorFixtureImpl.java:
##########
@@ -163,6 +163,7 @@ void forEachQueryValidateAndThen(StringAndPos expression,
SqlValidator validator = factory.createValidator();
SqlNode n = parseAndValidate(validator, sql);
assertNotNull(n);
+ tester.checkFails(factory, sap, expectedError, true);
Review Comment:
the last parameter to this call should be "runtime" and not "true"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org