You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mc...@gmail.com> on 2015/04/23 15:48:56 UTC
Re: Review Request 29748: Added tests for dynamic reservation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29748/#review81311
-----------------------------------------------------------
As of now, the tests seem to take a long time to complete. We should investigate what the issue is before committing this patch.
- Michael Park
On April 8, 2015, 5:05 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29748/
> -----------------------------------------------------------
>
> (Updated April 8, 2015, 5:05 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu.
>
>
> Bugs: MESOS-2489
> https://issues.apache.org/jira/browse/MESOS-2489
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/Makefile.am 9c01f5d6c692f835100e7cade928748cc4763cc8
> src/tests/reservation_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29748/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 29748: Added tests for dynamic reservation.
Posted by Jie Yu <yu...@gmail.com>.
> On April 23, 2015, 1:48 p.m., Michael Park wrote:
> > As of now, the tests seem to take a long time to complete. We should investigate what the issue is before committing this patch.
>
> Jie Yu wrote:
> I suspect this is due to the default allocation interval (1 secs by default).
Ping, has this been resolved?
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29748/#review81311
-----------------------------------------------------------
On May 2, 2015, 4:14 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29748/
> -----------------------------------------------------------
>
> (Updated May 2, 2015, 4:14 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu.
>
>
> Bugs: MESOS-2489
> https://issues.apache.org/jira/browse/MESOS-2489
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/Makefile.am 93c7c8a807a33ab639be6289535bbd32022aa85b
> src/tests/reservation_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29748/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 29748: Added tests for dynamic reservation.
Posted by Jie Yu <yu...@gmail.com>.
> On April 23, 2015, 1:48 p.m., Michael Park wrote:
> > As of now, the tests seem to take a long time to complete. We should investigate what the issue is before committing this patch.
I suspect this is due to the default allocation interval (1 secs by default).
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29748/#review81311
-----------------------------------------------------------
On April 8, 2015, 5:05 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29748/
> -----------------------------------------------------------
>
> (Updated April 8, 2015, 5:05 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu.
>
>
> Bugs: MESOS-2489
> https://issues.apache.org/jira/browse/MESOS-2489
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/Makefile.am 9c01f5d6c692f835100e7cade928748cc4763cc8
> src/tests/reservation_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29748/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 29748: Added tests for dynamic reservation.
Posted by Michael Park <mc...@gmail.com>.
> On April 23, 2015, 1:48 p.m., Michael Park wrote:
> > As of now, the tests seem to take a long time to complete. We should investigate what the issue is before committing this patch.
>
> Jie Yu wrote:
> I suspect this is due to the default allocation interval (1 secs by default).
>
> Jie Yu wrote:
> Ping, has this been resolved?
>
> Michael Park wrote:
> Not yet. I'll look into this further today.
Resolved this with AlexR offline. Turns out the allocation_interval (default 1s) as well as Filters (default 5s) need to be manually optimized.
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29748/#review81311
-----------------------------------------------------------
On May 9, 2015, 4:38 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29748/
> -----------------------------------------------------------
>
> (Updated May 9, 2015, 4:38 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu.
>
>
> Bugs: MESOS-2489
> https://issues.apache.org/jira/browse/MESOS-2489
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/Makefile.am 93c7c8a807a33ab639be6289535bbd32022aa85b
> src/tests/reservation_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29748/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 29748: Added tests for dynamic reservation.
Posted by Michael Park <mc...@gmail.com>.
> On April 23, 2015, 1:48 p.m., Michael Park wrote:
> > As of now, the tests seem to take a long time to complete. We should investigate what the issue is before committing this patch.
>
> Jie Yu wrote:
> I suspect this is due to the default allocation interval (1 secs by default).
>
> Jie Yu wrote:
> Ping, has this been resolved?
Not yet. I'll look into this further today.
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29748/#review81311
-----------------------------------------------------------
On May 2, 2015, 4:14 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29748/
> -----------------------------------------------------------
>
> (Updated May 2, 2015, 4:14 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu.
>
>
> Bugs: MESOS-2489
> https://issues.apache.org/jira/browse/MESOS-2489
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/Makefile.am 93c7c8a807a33ab639be6289535bbd32022aa85b
> src/tests/reservation_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29748/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Michael Park
>
>