You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Ho (Code Review)" <ge...@cloudera.org> on 2018/02/23 02:29:52 UTC
[Impala-ASF-CR] IMPALA-2990: Add a warning message during cancellation
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9413
Change subject: IMPALA-2990: Add a warning message during cancellation
......................................................................
IMPALA-2990: Add a warning message during cancellation
Until IMPALA-2990 is fixed, there is no easy way to
prevent query hangs due to cancellation of fragment
instances in a backend node when it fails to report
status to the coordinator. Given it's rather hard to
diagnose IMPALA-2990, this change adds a log statement
at the point of cancellation to warn about IMPALA-2990.
This hopefully makes diagnostics slightly easier.
Change-Id: Icfd56edfe74707592f4dd9c840550b13cb80e9a0
---
M be/src/runtime/query-state.cc
1 file changed, 7 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/13/9413/1
--
To view, visit http://gerrit.cloudera.org:8080/9413
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icfd56edfe74707592f4dd9c840550b13cb80e9a0
Gerrit-Change-Number: 9413
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
[Impala-ASF-CR] IMPALA-2990: Add a warning message during cancellation
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9413 )
Change subject: IMPALA-2990: Add a warning message during cancellation
......................................................................
IMPALA-2990: Add a warning message during cancellation
Until IMPALA-2990 is fixed, there is no easy way to
prevent query hangs due to cancellation of fragment
instances in a backend node when it fails to report
status to the coordinator. Given it's rather hard to
diagnose IMPALA-2990, this change adds a log statement
at the point of cancellation to warn about IMPALA-2990.
This hopefully makes diagnostics slightly easier.
Change-Id: Icfd56edfe74707592f4dd9c840550b13cb80e9a0
Reviewed-on: http://gerrit.cloudera.org:8080/9413
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/runtime/query-state.cc
1 file changed, 7 insertions(+), 2 deletions(-)
Approvals:
Joe McDonnell: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9413
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Icfd56edfe74707592f4dd9c840550b13cb80e9a0
Gerrit-Change-Number: 9413
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
[Impala-ASF-CR] IMPALA-2990: Add a warning message during cancellation
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9413 )
Change subject: IMPALA-2990: Add a warning message during cancellation
......................................................................
Patch Set 2:
GVO failed due to IMPALA-6394
--
To view, visit http://gerrit.cloudera.org:8080/9413
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfd56edfe74707592f4dd9c840550b13cb80e9a0
Gerrit-Change-Number: 9413
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Feb 2018 08:02:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-2990: Add a warning message during cancellation
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9413 )
Change subject: IMPALA-2990: Add a warning message during cancellation
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/2018/
--
To view, visit http://gerrit.cloudera.org:8080/9413
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfd56edfe74707592f4dd9c840550b13cb80e9a0
Gerrit-Change-Number: 9413
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Feb 2018 07:53:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-2990: Add a warning message during cancellation
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9413 )
Change subject: IMPALA-2990: Add a warning message during cancellation
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2018/
--
To view, visit http://gerrit.cloudera.org:8080/9413
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfd56edfe74707592f4dd9c840550b13cb80e9a0
Gerrit-Change-Number: 9413
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Feb 2018 04:10:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-2990: Add a warning message during cancellation
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Hello Sailesh Mukil, Joe McDonnell,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9413
to look at the new patch set (#2).
Change subject: IMPALA-2990: Add a warning message during cancellation
......................................................................
IMPALA-2990: Add a warning message during cancellation
Until IMPALA-2990 is fixed, there is no easy way to
prevent query hangs due to cancellation of fragment
instances in a backend node when it fails to report
status to the coordinator. Given it's rather hard to
diagnose IMPALA-2990, this change adds a log statement
at the point of cancellation to warn about IMPALA-2990.
This hopefully makes diagnostics slightly easier.
Change-Id: Icfd56edfe74707592f4dd9c840550b13cb80e9a0
---
M be/src/runtime/query-state.cc
1 file changed, 7 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/13/9413/2
--
To view, visit http://gerrit.cloudera.org:8080/9413
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icfd56edfe74707592f4dd9c840550b13cb80e9a0
Gerrit-Change-Number: 9413
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
[Impala-ASF-CR] IMPALA-2990: Add a warning message during cancellation
Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9413 )
Change subject: IMPALA-2990: Add a warning message during cancellation
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/9413
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfd56edfe74707592f4dd9c840550b13cb80e9a0
Gerrit-Change-Number: 9413
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Feb 2018 02:41:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-2990: Add a warning message during cancellation
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9413 )
Change subject: IMPALA-2990: Add a warning message during cancellation
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9413/1/be/src/runtime/query-state.cc
File be/src/runtime/query-state.cc:
http://gerrit.cloudera.org:8080/#/c/9413/1/be/src/runtime/query-state.cc@281
PS1, Line 281: LOG(ERROR) << "Cancelling fragment instances due to failure to report status. "
: << "Query may hang. See IMPALA-2990.";
> Can we include information about which query/backend this is? That would le
Done
--
To view, visit http://gerrit.cloudera.org:8080/9413
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfd56edfe74707592f4dd9c840550b13cb80e9a0
Gerrit-Change-Number: 9413
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Sat, 24 Feb 2018 01:23:23 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-2990: Add a warning message during cancellation
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9413 )
Change subject: IMPALA-2990: Add a warning message during cancellation
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9413/1/be/src/runtime/query-state.cc
File be/src/runtime/query-state.cc:
http://gerrit.cloudera.org:8080/#/c/9413/1/be/src/runtime/query-state.cc@281
PS1, Line 281: LOG(ERROR) << "Cancelling fragment instances due to failure to report status. "
: << "Query may hang. See IMPALA-2990.";
Can we include information about which query/backend this is? That would let us know which query might be hanging.
--
To view, visit http://gerrit.cloudera.org:8080/9413
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfd56edfe74707592f4dd9c840550b13cb80e9a0
Gerrit-Change-Number: 9413
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Feb 2018 02:50:02 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-2990: Add a warning message during cancellation
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9413 )
Change subject: IMPALA-2990: Add a warning message during cancellation
......................................................................
Patch Set 2: Code-Review+2
Looks good to me.
--
To view, visit http://gerrit.cloudera.org:8080/9413
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfd56edfe74707592f4dd9c840550b13cb80e9a0
Gerrit-Change-Number: 9413
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Sat, 24 Feb 2018 01:36:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-2990: Add a warning message during cancellation
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9413 )
Change subject: IMPALA-2990: Add a warning message during cancellation
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2022/
--
To view, visit http://gerrit.cloudera.org:8080/9413
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfd56edfe74707592f4dd9c840550b13cb80e9a0
Gerrit-Change-Number: 9413
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Feb 2018 08:03:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-2990: Add a warning message during cancellation
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9413 )
Change subject: IMPALA-2990: Add a warning message during cancellation
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/9413
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfd56edfe74707592f4dd9c840550b13cb80e9a0
Gerrit-Change-Number: 9413
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Feb 2018 11:43:09 +0000
Gerrit-HasComments: No