You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/05/14 16:29:00 UTC

[jira] [Commented] (PARQUET-1266) LogicalTypes union in parquet-format doesn't include UUID

    [ https://issues.apache.org/jira/browse/PARQUET-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16474432#comment-16474432 ] 

ASF GitHub Bot commented on PARQUET-1266:
-----------------------------------------

zivanfi closed pull request #93: PARQUET-1266: LogicalTypes union in parquet-format doesn't include UUID
URL: https://github.com/apache/parquet-format/pull/93
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/src/main/thrift/parquet.thrift b/src/main/thrift/parquet.thrift
index f3aac258..3b15cfef 100644
--- a/src/main/thrift/parquet.thrift
+++ b/src/main/thrift/parquet.thrift
@@ -318,7 +318,7 @@ struct BsonType {
  * following table.
  */
 union LogicalType {
-  1:  StringType STRING       // use ConvertedType UTF8 if encoding is UTF-8
+  1:  StringType STRING       // use ConvertedType UTF8
   2:  MapType MAP             // use ConvertedType MAP
   3:  ListType LIST           // use ConvertedType LIST
   4:  EnumType ENUM           // use ConvertedType ENUM
@@ -331,6 +331,7 @@ union LogicalType {
   11: NullType UNKNOWN        // no compatible ConvertedType
   12: JsonType JSON           // use ConvertedType JSON
   13: BsonType BSON           // use ConvertedType BSON
+  14: UUIDType UUID
 }
 
 /**
@@ -381,7 +382,7 @@ struct SchemaElement {
   9: optional i32 field_id;
 
   /**
-   * The logical type of this SchemaElement; only valid for primitives.
+   * The logical type of this SchemaElement
    *
    * LogicalType replaces ConvertedType, but ConvertedType is still required
    * for some logical types to ensure forward-compatibility in format v1.


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> LogicalTypes union in parquet-format doesn't include UUID
> ---------------------------------------------------------
>
>                 Key: PARQUET-1266
>                 URL: https://issues.apache.org/jira/browse/PARQUET-1266
>             Project: Parquet
>          Issue Type: Bug
>          Components: parquet-format
>            Reporter: Nandor Kollar
>            Assignee: Nandor Kollar
>            Priority: Minor
>
> parquet-format new logical type representation doesn't include UUID type



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)