You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by sujithjay <gi...@git.apache.org> on 2018/11/29 11:30:08 UTC

[GitHub] spark pull request #22806: [SPARK-25250] : On successful completion of a tas...

Github user sujithjay commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22806#discussion_r237447252
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
    @@ -1091,6 +1091,10 @@ private[spark] class TaskSetManager(
       def executorAdded() {
         recomputeLocality()
       }
    +
    +  def markPartitionIdAsCompletedForTaskAttempt(index: Int): Unit = {
    +    successful(index) = true
    --- End diff --
    
    Should this method also make a call to `TaskSetManager.maybeFinishTaskSet()`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org