[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #7282: Update ObjectStore 0.7.0 and Arrow 46.0.0

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #7282:
URL: https://github.com/apache/arrow-datafusion/pull/7282#discussion_r1304990337


##########
datafusion/common/src/scalar.rs:
##########
@@ -1329,6 +1321,11 @@ impl ScalarValue {
         self.to_array_of_size(1)
     }
 
+    /// Converts a scalar into an arrow [`Scalar`]
+    pub fn to_scalar(&self) -> Scalar<ArrayRef> {

Review Comment:
   👍 



##########
datafusion/core/tests/memory_limit.rs:
##########
@@ -237,6 +237,7 @@ async fn sort_preserving_merge() {
 }
 
 #[tokio::test]
+#[ignore] // TODO: Fix this

Review Comment:
   this still seems to be left TODO



##########
datafusion/common/src/scalar.rs:
##########
@@ -1329,6 +1321,11 @@ impl ScalarValue {
         self.to_array_of_size(1)
     }
 
+    /// Converts a scalar into an arrow [`Scalar`]
+    pub fn to_scalar(&self) -> Scalar<ArrayRef> {

Review Comment:
   👍 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org