You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2011/02/22 20:58:38 UTC
[jira] Created: (CASSANDRA-2219) modernize nodecmd option handling
modernize nodecmd option handling
---------------------------------
Key: CASSANDRA-2219
URL: https://issues.apache.org/jira/browse/CASSANDRA-2219
Project: Cassandra
Issue Type: Improvement
Components: Tools
Reporter: Jonathan Ellis
Assignee: Pavel Yaskevich
Priority: Minor
Fix For: 0.7.3
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CASSANDRA-2219) modernize nodecmd option handling
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-2219:
--------------------------------------
Reviewer: slebresne (was: jbellis)
> modernize nodecmd option handling
> ---------------------------------
>
> Key: CASSANDRA-2219
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2219
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Jonathan Ellis
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.7.3
>
> Attachments: CASSANDRA-2219.patch
>
> Original Estimate: 1h
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CASSANDRA-2219) modernize nodecmd option
handling
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000481#comment-13000481 ]
Jonathan Ellis commented on CASSANDRA-2219:
-------------------------------------------
i think the nodetool join patch made this one not apply :-|
> modernize nodecmd option handling
> ---------------------------------
>
> Key: CASSANDRA-2219
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2219
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Jonathan Ellis
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.7.4
>
> Attachments: CASSANDRA-2219.patch
>
> Original Estimate: 1h
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CASSANDRA-2219) modernize nodecmd option
handling
Posted by "Pavel Yaskevich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000482#comment-13000482 ]
Pavel Yaskevich commented on CASSANDRA-2219:
--------------------------------------------
This was committed before 2160...
> modernize nodecmd option handling
> ---------------------------------
>
> Key: CASSANDRA-2219
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2219
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Jonathan Ellis
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.7.4
>
> Attachments: CASSANDRA-2219.patch
>
> Original Estimate: 1h
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CASSANDRA-2219) modernize nodecmd option
handling
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000189#comment-13000189 ]
Sylvain Lebresne commented on CASSANDRA-2219:
---------------------------------------------
I think we can call the optionalKsAndCFs function in the default of the main switch, to avoid having to add those commands in two places.
Other that that, this looks ok. +1 minor first remark.
It still don't feel like the most modern code we have. The help for instance is ugly, I would prefer having a general help listing the commands and be able to do 'nodetool help compact' for instance. But it's probably not worth rewriting all this for now unless someone gets really bored.
> modernize nodecmd option handling
> ---------------------------------
>
> Key: CASSANDRA-2219
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2219
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Jonathan Ellis
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.7.4
>
> Attachments: CASSANDRA-2219.patch
>
> Original Estimate: 1h
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CASSANDRA-2219) modernize nodecmd option
handling
Posted by "Pavel Yaskevich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000192#comment-13000192 ]
Pavel Yaskevich commented on CASSANDRA-2219:
--------------------------------------------
Thanks for reviewing! Both your comments about optionalKsAndCFs and improved help can be moved to separate tickets, because this task was all about changing the way we work with command line parameters.
> modernize nodecmd option handling
> ---------------------------------
>
> Key: CASSANDRA-2219
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2219
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Jonathan Ellis
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.7.4
>
> Attachments: CASSANDRA-2219.patch
>
> Original Estimate: 1h
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CASSANDRA-2219) modernize nodecmd option
handling
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000343#comment-13000343 ]
Hudson commented on CASSANDRA-2219:
-----------------------------------
Integrated in Cassandra-0.7 #329 (See [https://hudson.apache.org/hudson/job/Cassandra-0.7/329/])
Modernize nodecmd option handling.
Patch by Pavel Yaskevich, reviewed by Sylvain Lebresne for
CASSANDRA-2219
> modernize nodecmd option handling
> ---------------------------------
>
> Key: CASSANDRA-2219
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2219
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Jonathan Ellis
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.7.4
>
> Attachments: CASSANDRA-2219.patch
>
> Original Estimate: 1h
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CASSANDRA-2219) modernize nodecmd option handling
Posted by "Pavel Yaskevich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pavel Yaskevich updated CASSANDRA-2219:
---------------------------------------
Remaining Estimate: 1h
Original Estimate: 1h
> modernize nodecmd option handling
> ---------------------------------
>
> Key: CASSANDRA-2219
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2219
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Jonathan Ellis
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.7.3
>
> Attachments: CASSANDRA-2219.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CASSANDRA-2219) modernize nodecmd option handling
Posted by "Pavel Yaskevich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pavel Yaskevich updated CASSANDRA-2219:
---------------------------------------
Attachment: CASSANDRA-2219.patch
branch: cassandra-0.7
> modernize nodecmd option handling
> ---------------------------------
>
> Key: CASSANDRA-2219
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2219
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Jonathan Ellis
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.7.3
>
> Attachments: CASSANDRA-2219.patch
>
>
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CASSANDRA-2219) modernize nodecmd option
handling
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000243#comment-13000243 ]
Sylvain Lebresne commented on CASSANDRA-2219:
---------------------------------------------
+1
> modernize nodecmd option handling
> ---------------------------------
>
> Key: CASSANDRA-2219
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2219
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Jonathan Ellis
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 0.7.4
>
> Attachments: CASSANDRA-2219.patch
>
> Original Estimate: 1h
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira