You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/04/01 12:45:28 UTC

[GitHub] [kafka] ijuma opened a new pull request #10458: KAFKA-12600: Remove deprecated config value `default` for client config `client.dns.lookup`

ijuma opened a new pull request #10458:
URL: https://github.com/apache/kafka/pull/10458


   The config has been deprecated since Kafka 2.6 (released ~1 year before
   3.0), but it was the default before it got deprecated. As such, it's
   reasonably unlikely that people would have set it explicitly.
   
   Given the confusing `default` name even though it's _not_ the default, I
   think we should remove it in 3.0.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma commented on pull request #10458: KAFKA-12600: Remove deprecated config value `default` for client config `client.dns.lookup`

Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #10458:
URL: https://github.com/apache/kafka/pull/10458#issuecomment-811899095


   @dajac Yes, we can definitely remove it! Done.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dajac commented on pull request #10458: KAFKA-12600: Remove deprecated config value `default` for client config `client.dns.lookup`

Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #10458:
URL: https://github.com/apache/kafka/pull/10458#issuecomment-811885627


   @ijuma Makes sense to remove it. Should we remove `DEFAULT` from the `ClientDnsLookup` enum as well? Or do we have to keep it for something else?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma commented on pull request #10458: KAFKA-12600: Remove deprecated config value `default` for client config `client.dns.lookup`

Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #10458:
URL: https://github.com/apache/kafka/pull/10458#issuecomment-811967138


   Unrelated failure that passed on retry:
   
   > Build / JDK 11 / testResponseIncludesLeaderEpoch()


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma merged pull request #10458: KAFKA-12600: Remove deprecated config value `default` for client config `client.dns.lookup`

Posted by GitBox <gi...@apache.org>.
ijuma merged pull request #10458:
URL: https://github.com/apache/kafka/pull/10458


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org