You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by Alex Harui <ah...@adobe.com> on 2015/06/12 00:53:18 UTC
Re: [1/2] git commit: [flex-falcon] [refs/heads/develop] - Ignoring
ReferenceModelTest, for some reason the build server is not passing this, it
passes locally.
It feels like this test is failing because some window.as is still open
for writing. It looks like you are using FileUtils to wrote out window.as
so that shouldn’t be a problem. I’m wondering if that file gets opened
again during the test, or maybe since all of this is happening in one test
some OS-level file cache is keeping it open. Do you know if that file is
getting opened again after being written?
-Alex
On 6/11/15, 3:43 PM, "mschmalle@apache.org" <ms...@apache.org> wrote:
>Repository: flex-falcon
>Updated Branches:
> refs/heads/develop 9981ec5f9 -> 59b80b18c
>
>
>Ignoring ReferenceModelTest, for some reason the build server is not
>passing this, it passes locally.
>
>
>Project: http://git-wip-us.apache.org/repos/asf/flex-falcon/repo
>Commit: http://git-wip-us.apache.org/repos/asf/flex-falcon/commit/0d09cb33
>Tree: http://git-wip-us.apache.org/repos/asf/flex-falcon/tree/0d09cb33
>Diff: http://git-wip-us.apache.org/repos/asf/flex-falcon/diff/0d09cb33
>
>Branch: refs/heads/develop
>Commit: 0d09cb333cd16c172bc3084aa0870b60a184243f
>Parents: 9981ec5
>Author: Michael Schmalle <ms...@apache.org>
>Authored: Thu Jun 11 18:42:24 2015 -0400
>Committer: Michael Schmalle <ms...@apache.org>
>Committed: Thu Jun 11 18:42:24 2015 -0400
>
>----------------------------------------------------------------------
> .../compiler/internal/codegen/externals/TestReferenceModel.java | 2 ++
> 1 file changed, 2 insertions(+)
>----------------------------------------------------------------------
>
>
>http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/0d09cb33/compiler.
>jx.tests/src/org/apache/flex/compiler/internal/codegen/externals/TestRefer
>enceModel.java
>----------------------------------------------------------------------
>diff --git
>a/compiler.jx.tests/src/org/apache/flex/compiler/internal/codegen/external
>s/TestReferenceModel.java
>b/compiler.jx.tests/src/org/apache/flex/compiler/internal/codegen/external
>s/TestReferenceModel.java
>index 09a7133..d4374b3 100644
>---
>a/compiler.jx.tests/src/org/apache/flex/compiler/internal/codegen/external
>s/TestReferenceModel.java
>+++
>b/compiler.jx.tests/src/org/apache/flex/compiler/internal/codegen/external
>s/TestReferenceModel.java
>@@ -25,10 +25,12 @@ import static org.junit.Assert.assertTrue;
> import java.io.IOException;
>
> import org.apache.flex.compiler.clients.ExternCConfiguration;
>+import org.junit.Ignore;
> import org.junit.Test;
>
> public class TestReferenceModel extends ExternalsTestBase
> {
>+ @Ignore
> @Test
> public void test_full_compile() throws IOException
> {
>
Re: [1/2] git commit: [flex-falcon] [refs/heads/develop] - Ignoring
ReferenceModelTest, for some reason the build server is not passing this, it
passes locally.
Posted by Michael Schmalle <te...@gmail.com>.
Yes Windows 7. Like I said, everything passes on my machine so, I can't
figure it out.
On Thu, Jun 11, 2015 at 7:29 PM, Alex Harui <ah...@adobe.com> wrote:
> It looks like the first step of TestReferenceModel calls clean-output
> which can’t delete window.as. But just before that, I think windows.as
> gets created in the TestExternalsJSCompile test? That’s why I think that
> window.as is still open for write when the clean-output tries to delete
> its parent folder. Are you running on Windows? If not, maybe I’ll try to
> set up Windows and see if it fails there.
>
> -Alex
>
> On 6/11/15, 4:02 PM, "Michael Schmalle" <te...@gmail.com> wrote:
>
> >No it's not. But I thought the same thing, There is so much being written
> >at once, I think what may be happening is the delete call before that is
> >cleaning the directory might now be finished. I think Fred and I had this
> >same problem with testing Randori stuff where there was huge amounts of
> >data being deleted then written.
> >
> >On Thu, Jun 11, 2015 at 6:53 PM, Alex Harui <ah...@adobe.com> wrote:
> >
> >> It feels like this test is failing because some window.as is still open
> >> for writing. It looks like you are using FileUtils to wrote out
> >>window.as
> >> so that shouldn’t be a problem. I’m wondering if that file gets opened
> >> again during the test, or maybe since all of this is happening in one
> >>test
> >> some OS-level file cache is keeping it open. Do you know if that file
> >>is
> >> getting opened again after being written?
> >>
> >> -Alex
> >>
> >> On 6/11/15, 3:43 PM, "mschmalle@apache.org" <ms...@apache.org>
> >>wrote:
> >>
> >> >Repository: flex-falcon
> >> >Updated Branches:
> >> > refs/heads/develop 9981ec5f9 -> 59b80b18c
> >> >
> >> >
> >> >Ignoring ReferenceModelTest, for some reason the build server is not
> >> >passing this, it passes locally.
> >> >
> >> >
> >> >Project: http://git-wip-us.apache.org/repos/asf/flex-falcon/repo
> >> >Commit:
> >> http://git-wip-us.apache.org/repos/asf/flex-falcon/commit/0d09cb33
> >> >Tree: http://git-wip-us.apache.org/repos/asf/flex-falcon/tree/0d09cb33
> >> >Diff: http://git-wip-us.apache.org/repos/asf/flex-falcon/diff/0d09cb33
> >> >
> >> >Branch: refs/heads/develop
> >> >Commit: 0d09cb333cd16c172bc3084aa0870b60a184243f
> >> >Parents: 9981ec5
> >> >Author: Michael Schmalle <ms...@apache.org>
> >> >Authored: Thu Jun 11 18:42:24 2015 -0400
> >> >Committer: Michael Schmalle <ms...@apache.org>
> >> >Committed: Thu Jun 11 18:42:24 2015 -0400
> >> >
> >> >----------------------------------------------------------------------
> >> > .../compiler/internal/codegen/externals/TestReferenceModel.java |
> >>2 ++
> >> > 1 file changed, 2 insertions(+)
> >> >----------------------------------------------------------------------
> >> >
> >> >
> >>
> >>>
> http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/0d09cb33/compile
> >>>r
> >> .
> >>
> >>>jx.tests/src/org/apache/flex/compiler/internal/codegen/externals/TestRef
> >>>er
> >> >enceModel.java
> >> >----------------------------------------------------------------------
> >> >diff --git
> >>
> >>>a/compiler.jx.tests/src/org/apache/flex/compiler/internal/codegen/extern
> >>>al
> >> >s/TestReferenceModel.java
> >>
> >>>b/compiler.jx.tests/src/org/apache/flex/compiler/internal/codegen/extern
> >>>al
> >> >s/TestReferenceModel.java
> >> >index 09a7133..d4374b3 100644
> >> >---
> >>
> >>>a/compiler.jx.tests/src/org/apache/flex/compiler/internal/codegen/extern
> >>>al
> >> >s/TestReferenceModel.java
> >> >+++
> >>
> >>>b/compiler.jx.tests/src/org/apache/flex/compiler/internal/codegen/extern
> >>>al
> >> >s/TestReferenceModel.java
> >> >@@ -25,10 +25,12 @@ import static org.junit.Assert.assertTrue;
> >> > import java.io.IOException;
> >> >
> >> > import org.apache.flex.compiler.clients.ExternCConfiguration;
> >> >+import org.junit.Ignore;
> >> > import org.junit.Test;
> >> >
> >> > public class TestReferenceModel extends ExternalsTestBase
> >> > {
> >> >+ @Ignore
> >> > @Test
> >> > public void test_full_compile() throws IOException
> >> > {
> >> >
> >>
> >>
>
>
Re: [1/2] git commit: [flex-falcon] [refs/heads/develop] - Ignoring
ReferenceModelTest, for some reason the build server is not passing this, it
passes locally.
Posted by Alex Harui <ah...@adobe.com>.
It looks like the first step of TestReferenceModel calls clean-output
which can’t delete window.as. But just before that, I think windows.as
gets created in the TestExternalsJSCompile test? That’s why I think that
window.as is still open for write when the clean-output tries to delete
its parent folder. Are you running on Windows? If not, maybe I’ll try to
set up Windows and see if it fails there.
-Alex
On 6/11/15, 4:02 PM, "Michael Schmalle" <te...@gmail.com> wrote:
>No it's not. But I thought the same thing, There is so much being written
>at once, I think what may be happening is the delete call before that is
>cleaning the directory might now be finished. I think Fred and I had this
>same problem with testing Randori stuff where there was huge amounts of
>data being deleted then written.
>
>On Thu, Jun 11, 2015 at 6:53 PM, Alex Harui <ah...@adobe.com> wrote:
>
>> It feels like this test is failing because some window.as is still open
>> for writing. It looks like you are using FileUtils to wrote out
>>window.as
>> so that shouldn’t be a problem. I’m wondering if that file gets opened
>> again during the test, or maybe since all of this is happening in one
>>test
>> some OS-level file cache is keeping it open. Do you know if that file
>>is
>> getting opened again after being written?
>>
>> -Alex
>>
>> On 6/11/15, 3:43 PM, "mschmalle@apache.org" <ms...@apache.org>
>>wrote:
>>
>> >Repository: flex-falcon
>> >Updated Branches:
>> > refs/heads/develop 9981ec5f9 -> 59b80b18c
>> >
>> >
>> >Ignoring ReferenceModelTest, for some reason the build server is not
>> >passing this, it passes locally.
>> >
>> >
>> >Project: http://git-wip-us.apache.org/repos/asf/flex-falcon/repo
>> >Commit:
>> http://git-wip-us.apache.org/repos/asf/flex-falcon/commit/0d09cb33
>> >Tree: http://git-wip-us.apache.org/repos/asf/flex-falcon/tree/0d09cb33
>> >Diff: http://git-wip-us.apache.org/repos/asf/flex-falcon/diff/0d09cb33
>> >
>> >Branch: refs/heads/develop
>> >Commit: 0d09cb333cd16c172bc3084aa0870b60a184243f
>> >Parents: 9981ec5
>> >Author: Michael Schmalle <ms...@apache.org>
>> >Authored: Thu Jun 11 18:42:24 2015 -0400
>> >Committer: Michael Schmalle <ms...@apache.org>
>> >Committed: Thu Jun 11 18:42:24 2015 -0400
>> >
>> >----------------------------------------------------------------------
>> > .../compiler/internal/codegen/externals/TestReferenceModel.java |
>>2 ++
>> > 1 file changed, 2 insertions(+)
>> >----------------------------------------------------------------------
>> >
>> >
>>
>>>http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/0d09cb33/compile
>>>r
>> .
>>
>>>jx.tests/src/org/apache/flex/compiler/internal/codegen/externals/TestRef
>>>er
>> >enceModel.java
>> >----------------------------------------------------------------------
>> >diff --git
>>
>>>a/compiler.jx.tests/src/org/apache/flex/compiler/internal/codegen/extern
>>>al
>> >s/TestReferenceModel.java
>>
>>>b/compiler.jx.tests/src/org/apache/flex/compiler/internal/codegen/extern
>>>al
>> >s/TestReferenceModel.java
>> >index 09a7133..d4374b3 100644
>> >---
>>
>>>a/compiler.jx.tests/src/org/apache/flex/compiler/internal/codegen/extern
>>>al
>> >s/TestReferenceModel.java
>> >+++
>>
>>>b/compiler.jx.tests/src/org/apache/flex/compiler/internal/codegen/extern
>>>al
>> >s/TestReferenceModel.java
>> >@@ -25,10 +25,12 @@ import static org.junit.Assert.assertTrue;
>> > import java.io.IOException;
>> >
>> > import org.apache.flex.compiler.clients.ExternCConfiguration;
>> >+import org.junit.Ignore;
>> > import org.junit.Test;
>> >
>> > public class TestReferenceModel extends ExternalsTestBase
>> > {
>> >+ @Ignore
>> > @Test
>> > public void test_full_compile() throws IOException
>> > {
>> >
>>
>>
Re: [1/2] git commit: [flex-falcon] [refs/heads/develop] - Ignoring
ReferenceModelTest, for some reason the build server is not passing this, it
passes locally.
Posted by Michael Schmalle <te...@gmail.com>.
No it's not. But I thought the same thing, There is so much being written
at once, I think what may be happening is the delete call before that is
cleaning the directory might now be finished. I think Fred and I had this
same problem with testing Randori stuff where there was huge amounts of
data being deleted then written.
On Thu, Jun 11, 2015 at 6:53 PM, Alex Harui <ah...@adobe.com> wrote:
> It feels like this test is failing because some window.as is still open
> for writing. It looks like you are using FileUtils to wrote out window.as
> so that shouldn’t be a problem. I’m wondering if that file gets opened
> again during the test, or maybe since all of this is happening in one test
> some OS-level file cache is keeping it open. Do you know if that file is
> getting opened again after being written?
>
> -Alex
>
> On 6/11/15, 3:43 PM, "mschmalle@apache.org" <ms...@apache.org> wrote:
>
> >Repository: flex-falcon
> >Updated Branches:
> > refs/heads/develop 9981ec5f9 -> 59b80b18c
> >
> >
> >Ignoring ReferenceModelTest, for some reason the build server is not
> >passing this, it passes locally.
> >
> >
> >Project: http://git-wip-us.apache.org/repos/asf/flex-falcon/repo
> >Commit:
> http://git-wip-us.apache.org/repos/asf/flex-falcon/commit/0d09cb33
> >Tree: http://git-wip-us.apache.org/repos/asf/flex-falcon/tree/0d09cb33
> >Diff: http://git-wip-us.apache.org/repos/asf/flex-falcon/diff/0d09cb33
> >
> >Branch: refs/heads/develop
> >Commit: 0d09cb333cd16c172bc3084aa0870b60a184243f
> >Parents: 9981ec5
> >Author: Michael Schmalle <ms...@apache.org>
> >Authored: Thu Jun 11 18:42:24 2015 -0400
> >Committer: Michael Schmalle <ms...@apache.org>
> >Committed: Thu Jun 11 18:42:24 2015 -0400
> >
> >----------------------------------------------------------------------
> > .../compiler/internal/codegen/externals/TestReferenceModel.java | 2 ++
> > 1 file changed, 2 insertions(+)
> >----------------------------------------------------------------------
> >
> >
> >http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/0d09cb33/compiler
> .
> >jx.tests/src/org/apache/flex/compiler/internal/codegen/externals/TestRefer
> >enceModel.java
> >----------------------------------------------------------------------
> >diff --git
> >a/compiler.jx.tests/src/org/apache/flex/compiler/internal/codegen/external
> >s/TestReferenceModel.java
> >b/compiler.jx.tests/src/org/apache/flex/compiler/internal/codegen/external
> >s/TestReferenceModel.java
> >index 09a7133..d4374b3 100644
> >---
> >a/compiler.jx.tests/src/org/apache/flex/compiler/internal/codegen/external
> >s/TestReferenceModel.java
> >+++
> >b/compiler.jx.tests/src/org/apache/flex/compiler/internal/codegen/external
> >s/TestReferenceModel.java
> >@@ -25,10 +25,12 @@ import static org.junit.Assert.assertTrue;
> > import java.io.IOException;
> >
> > import org.apache.flex.compiler.clients.ExternCConfiguration;
> >+import org.junit.Ignore;
> > import org.junit.Test;
> >
> > public class TestReferenceModel extends ExternalsTestBase
> > {
> >+ @Ignore
> > @Test
> > public void test_full_compile() throws IOException
> > {
> >
>
>