You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Robert Munteanu (JIRA)" <ji...@apache.org> on 2014/03/04 17:33:25 UTC

[jira] [Commented] (FELIX-4277) The maven-scr-plugin generates false warnings when using @SlingServlet

    [ https://issues.apache.org/jira/browse/FELIX-4277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13919574#comment-13919574 ] 

Robert Munteanu commented on FELIX-4277:
----------------------------------------

The attached [^FELIX-4277-1.patch] works for me. Warnings are no longer generated when  building, and the descriptor is the same.

> The maven-scr-plugin generates false warnings when using @SlingServlet
> ----------------------------------------------------------------------
>
>                 Key: FELIX-4277
>                 URL: https://issues.apache.org/jira/browse/FELIX-4277
>             Project: Felix
>          Issue Type: Bug
>          Components: Maven SCR Plugin
>    Affects Versions: maven-scr-plugin 1.15.0
>            Reporter: Robert Munteanu
>            Priority: Minor
>         Attachments: FELIX-4277-1.patch
>
>
> I have a class which is annotated with 
> @SlingServlet(resourceTypes = "slingDemo/conferenceSchedule", selectors = "rss", methods = "GET", extensions = "xml")
> In Eclipse and also using the CLI, I get warnings that
> 	- Property sling.servlet.methods in class de.adaptto.conference_schedule.RssFeedServlet is set as private. This is redundant as no metatype will be generated. (org.apache.felix:maven-scr-plugin:1.15.0:scr:generate-scr-descriptor:process-classes)
> 	- Property sling.servlet.extensions in class de.adaptto.conference_schedule.RssFeedServlet is set as private. This is redundant as no metatype will be generated. (org.apache.felix:maven-scr-plugin:1.15.0:scr:generate-scr-descriptor:process-classes)
> 	- Property sling.servlet.selectors in class de.adaptto.conference_schedule.RssFeedServlet is set as private. This is redundant as no metatype will be generated. (org.apache.felix:maven-scr-plugin:1.15.0:scr:generate-scr-descriptor:process-classes)
> 	- Property sling.servlet.resourceTypes in class de.adaptto.conference_schedule.RssFeedServlet is set as private. This is redundant as no metatype will be generated. (org.apache.felix:maven-scr-plugin:1.15.0:scr:generate-scr-descriptor:process-classes)
> I guess the SlingAnnotationProcessor should not set the propertyPrivate flag if metatype = false, but I'm not sure that this is the correct change.



--
This message was sent by Atlassian JIRA
(v6.2#6252)