You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by jpeach <gi...@git.apache.org> on 2016/10/13 16:56:47 UTC

[GitHub] trafficserver pull request #1104: TS-4947: Fix log collation hosts configura...

GitHub user jpeach opened a pull request:

    https://github.com/apache/trafficserver/pull/1104

    TS-4947: Fix log collation hosts configuration.

    In the Lua logging configuration, we were failing to correctly
    configure log collation hosts. The main fix is to simply return
    true when we actually succeeded.
    
    Fixed a bug in lua_scoped_stack where we failed to count the number
    of values we pushed, which messes up the stack on return.
    
    Updated the LogHost display to show failover hosts.
    
    Added some tests for the supported syntaxes.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jpeach/trafficserver fix/4947

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/1104.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1104
    
----
commit bdfc697f5443410543dbca7c424cae3f9e7ea039
Author: James Peach <jp...@apache.org>
Date:   2016-10-13T16:52:46Z

    TS-4947: Fix log collation hosts configuration.
    
    In the Lua logging configuration, we were failing to correctly
    configure log collation hosts. The main fix is to simply return
    true when we actually succeeded.
    
    Fixed a bug in lua_scoped_stack where we failed to count the number
    of values we pushed, which messes up the stack on return.
    
    Updated the LogHost display to show failover hosts.
    
    Added some tests for the supported syntaxes.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1104: TS-4947: Fix log collation hosts configura...

Posted by bryancall <gi...@git.apache.org>.
Github user bryancall closed the pull request at:

    https://github.com/apache/trafficserver/pull/1104


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1104: TS-4947: Fix log collation hosts configuration.

Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:

    https://github.com/apache/trafficserver/pull/1104
  
    Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/891/ for details.
     



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1104: TS-4947: Fix log collation hosts configuration.

Posted by bryancall <gi...@git.apache.org>.
Github user bryancall commented on the issue:

    https://github.com/apache/trafficserver/pull/1104
  
    Build and I ran the tests.  Code looks OK, but I don't know the lua API.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1104: TS-4947: Fix log collation hosts configuration.

Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:

    https://github.com/apache/trafficserver/pull/1104
  
    FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/999/ for details.
     



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---