You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "wido (via GitHub)" <gi...@apache.org> on 2023/06/01 15:24:16 UTC
[GitHub] [cloudstack] wido commented on a diff in pull request #7580: get the right controll cidr
wido commented on code in PR #7580:
URL: https://github.com/apache/cloudstack/pull/7580#discussion_r1213324052
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java:
##########
@@ -65,10 +65,7 @@ public void configure(Map<String, Object> params) throws ConfigurationException
String networkScriptsDir = AgentPropertiesFileHandler.getPropertyValue(AgentProperties.NETWORK_SCRIPTS_DIR);
- String controlCidr = (String)params.get("control.cidr");
- if (StringUtils.isNotBlank(controlCidr)) {
- _controlCidr = controlCidr;
- }
+ _controlCidr = getControllCidr(_controlCidr, params);
Review Comment:
Single 'l' instead of 'll' for control?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org