[GitHub] [hadoop] smengcl opened a new pull request #1218: HDDS-1891. Ozone fs shell command should work with default port when port number is not specified

[GitBox <gi...@apache.org>]

smengcl opened a new pull request #1218: HDDS-1891. Ozone fs shell command should work with default port when port number is not specified
URL: https://github.com/apache/hadoop/pull/1218
 
 
   Tested manually with ozone fs:
   
   ```bash
   $ ozone fs -ls o3fs://bucket.volume.localhost/
   2019-08-02 12:57:13,223 INFO ipc.Client: Retrying connect to server: localhost/127.0.0.1:9862. Already tried 0 time(s); retry policy is RetryUpToMaximumCountWithFixedSleep(maxRetries=10, sleepTime=1000 MILLISECONDS)
   ...
   
   $ ozone fs -ls o3fs://bucket.volume.localhost:9861/
   2019-08-02 12:57:21,604 INFO ipc.Client: Retrying connect to server: localhost/127.0.0.1:9861. Already tried 0 time(s); retry policy is RetryUpToMaximumCountWithFixedSleep(maxRetries=10, sleepTime=1000 MILLISECONDS)
   ...
   ```
   
   Do we want to add a unit test for this? If yes, existing `TestOzoneShell` won't suit the need since `getOmAddress()` always returns the full address with port number. And the port number is almost always not default OM port 9862 when the running the test. So I might need to come up with a new unit test suite. e.g. test the parser only.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org