You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kibble.apache.org by Sharan Foga <sh...@apache.org> on 2020/10/06 19:58:01 UTC

[DISCUSSION] Setting up Pre-Commit

Hi All

Michal one of our new contributors has suggested setting up https://pre-commit.com/ as a first step in putting in place some checks for formatting and syntax to help with code quality.

You can see the conversation in the github issue https://github.com/apache/kibble/issues/27

I think this could be a very good way to get things started so would be willing to support this. What do others think?

Thanks
Sharan

Re: [DISCUSSION] Setting up Pre-Commit

Posted by Sharan Foga <sh...@apache.org>.
Hi All

As there has been no negative feedback against this idea - let's move forward to put something in place. I see that Michal has already started a pull request conversation so please feel free to comment while the work is in process.

Thanks
Sharan

On 2020/10/06 21:02:51, Tomasz Urbaszek <tu...@apache.org> wrote: 
> Hello all,
> 
> I heartily support pre-commits. It's an amazing framework that vastly
> automates code/content quality checking. We are using it in Apache
> Airflow where it helps us a lot.
> 
> Cheers,
> Tomek
> 
> 
> On Tue, Oct 6, 2020 at 9:58 PM Sharan Foga <sh...@apache.org> wrote:
> >
> > Hi All
> >
> > Michal one of our new contributors has suggested setting up https://pre-commit.com/ as a first step in putting in place some checks for formatting and syntax to help with code quality.
> >
> > You can see the conversation in the github issue https://github.com/apache/kibble/issues/27
> >
> > I think this could be a very good way to get things started so would be willing to support this. What do others think?
> >
> > Thanks
> > Sharan
> >
> 
> 
> -- 
> 
> Tomasz Urbaszek
> Polidea | Software Engineer
> 
> M: +48 505 628 493
> E: tomasz.urbaszek@polidea.com
> 
> Unique Tech
> Check out our projects!
>

Re: [DISCUSSION] Setting up Pre-Commit

Posted by Tomasz Urbaszek <tu...@apache.org>.
Hello all,

I heartily support pre-commits. It's an amazing framework that vastly
automates code/content quality checking. We are using it in Apache
Airflow where it helps us a lot.

Cheers,
Tomek


On Tue, Oct 6, 2020 at 9:58 PM Sharan Foga <sh...@apache.org> wrote:
>
> Hi All
>
> Michal one of our new contributors has suggested setting up https://pre-commit.com/ as a first step in putting in place some checks for formatting and syntax to help with code quality.
>
> You can see the conversation in the github issue https://github.com/apache/kibble/issues/27
>
> I think this could be a very good way to get things started so would be willing to support this. What do others think?
>
> Thanks
> Sharan
>


-- 

Tomasz Urbaszek
Polidea | Software Engineer

M: +48 505 628 493
E: tomasz.urbaszek@polidea.com

Unique Tech
Check out our projects!