You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by "Michael Vorburger (Jira)" <ji...@apache.org> on 2020/06/29 22:46:00 UTC

[jira] [Commented] (FINERACT-1062) Platform Exceptions have no message

    [ https://issues.apache.org/jira/browse/FINERACT-1062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17148180#comment-17148180 ] 

Michael Vorburger commented on FINERACT-1062:
---------------------------------------------

https://github.com/apache/fineract/pull/1125 proposes what I had in mind here (and does a number of related refactorings).

> Platform Exceptions have no message
> -----------------------------------
>
>                 Key: FINERACT-1062
>                 URL: https://issues.apache.org/jira/browse/FINERACT-1062
>             Project: Apache Fineract
>          Issue Type: Bug
>            Reporter: Michael Vorburger
>            Assignee: Michael Vorburger
>            Priority: Minor
>             Fix For: 1.4.0
>
>
> While analysing FINERACT-1060, I thought it was a bit curious that that {{UserNotFoundException}} showed up as {{UserNotFoundException: null}}, instead of something like _User with name 'system' does not exist_.
> Looking into this further, I suspect that this is related to that entire business which Fineract (apparently) has of of exception with "user" messages that can be translated (somehow, somewhere).
> What's missing & confusing, at least if these exceptions are then also used for error logging, is that the "normal" exception message is never set.
> It should be fairly simply to actually set it to be that "defaultUserMessage" (especially after doing some refactoring which I thought would be natural to do after [~Manthan] work in https://github.com/apache/fineract/pull/1079 for FINERACT-942), so I'll propose a PR related to this.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)