You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/06/24 06:10:58 UTC

[GitHub] [inlong] dockerzhang commented on a diff in pull request #4744: [INLONG-4684][Manager] Add enums validation for controller

dockerzhang commented on code in PR #4744:
URL: https://github.com/apache/inlong/pull/4744#discussion_r905746395


##########
inlong-manager/manager-web/src/test/java/org/apache/inlong/manager/web/controller/AnnoControllerTest.java:
##########
@@ -118,4 +118,27 @@ void testLogout() throws Exception {
         Assertions.assertFalse(SecurityUtils.getSubject().isAuthenticated());
     }
 
+    @Test
+    void testRegisterFailByInvalidType() throws Exception {
+        UserInfo userInfo = UserInfo.builder()
+                .username("admin11")
+                .password("22222")

Review Comment:
   it's better to make the password meaningful. like 'test_username', 'test_password'.
   '22222', '88888' is so casual.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org