You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ah...@apache.org on 2020/02/13 11:49:02 UTC
[commons-numbers] 01/04: Fixed spotbugs filter for JMH module.
This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git
commit 9a8e1c53fe815eff7680726d31be50d5cd298f76
Author: aherbert <ah...@apache.org>
AuthorDate: Thu Feb 13 11:22:31 2020 +0000
Fixed spotbugs filter for JMH module.
Ignore the generated JMH files.
Ignore exposing internal array for test data classes in Performance
classes.
Fixed XML schema namespace.
---
src/main/resources/spotbugs/spotbugs-exclude-filter.xml | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/src/main/resources/spotbugs/spotbugs-exclude-filter.xml b/src/main/resources/spotbugs/spotbugs-exclude-filter.xml
index 5d18f8e..c3012e8 100644
--- a/src/main/resources/spotbugs/spotbugs-exclude-filter.xml
+++ b/src/main/resources/spotbugs/spotbugs-exclude-filter.xml
@@ -22,9 +22,13 @@
put here to instruct spotbugs it must ignore them.
-->
<FindBugsFilter
- xmlns="https://github.com/spotbugs/filter/3.1.0"
+ xmlns="https://github.com/spotbugs/filter/3.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
- xsi:schemaLocation="https://github.com/spotbugs/filter/3.1.0 https://raw.githubusercontent.com/spotbugs/spotbugs/3.1.0/spotbugs/etc/findbugsfilter.xsd">
+ xsi:schemaLocation="https://github.com/spotbugs/filter/3.0.0 https://raw.githubusercontent.com/spotbugs/spotbugs/3.1.0/spotbugs/etc/findbugsfilter.xsd">
+
+ <Match>
+ <Class name="~.*\.jmh\..*generated\..*"/>
+ </Match>
<!-- Deliberately floating-point equality checks. -->
<Match>
@@ -38,4 +42,10 @@
<BugPattern name="FE_FLOATING_POINT_EQUALITY"/>
</Match>
+ <Match>
+ <!-- Benchmark state classes can expose internal representations -->
+ <Class name="~org.apache.commons.numbers.examples.jmh..*Performance.*"/>
+ <BugPattern name="EI_EXPOSE_REP"/>
+ </Match>
+
</FindBugsFilter>