You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2023/01/09 08:40:34 UTC
[GitHub] [spark] panbingkun opened a new pull request, #39466: [SPARK-41948][SQL] Fix NPE for error classes: CANNOT_PARSE_JSON_FIELD
panbingkun opened a new pull request, #39466:
URL: https://github.com/apache/spark/pull/39466
### What changes were proposed in this pull request?
The pr aims to fix NPE for error classes: CANNOT_PARSE_JSON_FIELD.
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass GA.
Existed UT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #39466: [SPARK-41948][SQL] Fix NPE for error classes: CANNOT_PARSE_JSON_FIELD
Posted by GitBox <gi...@apache.org>.
panbingkun commented on PR #39466:
URL: https://github.com/apache/spark/pull/39466#issuecomment-1375320671
> @panbingkun Is there any test which reproduces the issue? If not, please, add it.
https://github.com/apache/spark/blob/15a0f55246bee7b043bd6081f53744fbf74403eb/sql/core/src/test/resources/sql-tests/inputs/json-functions.sql#L45
Above test can reproduces the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] codecov-commenter commented on pull request #39466: [SPARK-41948][SQL] Fix NPE for error classes: CANNOT_PARSE_JSON_FIELD
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #39466:
URL: https://github.com/apache/spark/pull/39466#issuecomment-1375577547
# [Codecov](https://codecov.io/gh/apache/spark/pull/39466?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#39466](https://codecov.io/gh/apache/spark/pull/39466?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (15a0f55) into [master](https://codecov.io/gh/apache/spark/commit/1a197bdb61baa951c938f96cd7805c9dc59e87d3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1a197bd) will **decrease** coverage by `11.27%`.
> The diff coverage is `80.00%`.
> :exclamation: Current head 15a0f55 differs from pull request most recent head 7aa8f72. Consider uploading reports for the commit 7aa8f72 to get more accurate results
```diff
@@ Coverage Diff @@
## master #39466 +/- ##
===========================================
- Coverage 91.00% 79.72% -11.28%
===========================================
Files 343 243 -100
Lines 78341 63513 -14828
Branches 10672 8568 -2104
===========================================
- Hits 71294 50638 -20656
- Misses 5416 11437 +6021
+ Partials 1631 1438 -193
```
| Flag | Coverage Δ | |
|---|---|---|
| unittests | `79.72% <80.00%> (-11.27%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/spark/pull/39466?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [python/pyspark/sql/connect/dataframe.py](https://codecov.io/gh/apache/spark/pull/39466?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc3FsL2Nvbm5lY3QvZGF0YWZyYW1lLnB5) | `80.30% <70.21%> (-0.69%)` | :arrow_down: |
| [python/pyspark/sql/connect/plan.py](https://codecov.io/gh/apache/spark/pull/39466?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc3FsL2Nvbm5lY3QvcGxhbi5weQ==) | `88.49% <77.27%> (-0.25%)` | :arrow_down: |
| [...on/pyspark/sql/tests/connect/test\_connect\_basic.py](https://codecov.io/gh/apache/spark/pull/39466?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc3FsL3Rlc3RzL2Nvbm5lY3QvdGVzdF9jb25uZWN0X2Jhc2ljLnB5) | `99.36% <100.00%> (+0.01%)` | :arrow_up: |
| [...hon/pyspark/sql/tests/connect/test\_connect\_plan.py](https://codecov.io/gh/apache/spark/pull/39466?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc3FsL3Rlc3RzL2Nvbm5lY3QvdGVzdF9jb25uZWN0X3BsYW4ucHk=) | `96.90% <100.00%> (+0.05%)` | :arrow_up: |
| [python/pyspark/join.py](https://codecov.io/gh/apache/spark/pull/39466?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvam9pbi5weQ==) | `12.12% <0.00%> (-81.82%)` | :arrow_down: |
| [python/pyspark/pandas/categorical.py](https://codecov.io/gh/apache/spark/pull/39466?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3BhcmsvcGFuZGFzL2NhdGVnb3JpY2FsLnB5) | `17.96% <0.00%> (-77.25%)` | :arrow_down: |
| [python/pyspark/shuffle.py](https://codecov.io/gh/apache/spark/pull/39466?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc2h1ZmZsZS5weQ==) | `19.19% <0.00%> (-70.21%)` | :arrow_down: |
| [python/pyspark/pandas/strings.py](https://codecov.io/gh/apache/spark/pull/39466?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3BhcmsvcGFuZGFzL3N0cmluZ3MucHk=) | `29.48% <0.00%> (-68.93%)` | :arrow_down: |
| [python/pyspark/pandas/plot/core.py](https://codecov.io/gh/apache/spark/pull/39466?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3BhcmsvcGFuZGFzL3Bsb3QvY29yZS5weQ==) | `23.23% <0.00%> (-68.36%)` | :arrow_down: |
| [python/pyspark/ml/tuning.py](https://codecov.io/gh/apache/spark/pull/39466?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3BhcmsvbWwvdHVuaW5nLnB5) | `25.03% <0.00%> (-67.46%)` | :arrow_down: |
| ... and [191 more](https://codecov.io/gh/apache/spark/pull/39466?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #39466: [SPARK-41948][SQL] Fix NPE for error classes: CANNOT_PARSE_JSON_FIELD
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #39466:
URL: https://github.com/apache/spark/pull/39466#issuecomment-1400245902
+1, LGTM. Merging to master.
Thank you, @panbingkun.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #39466: [SPARK-41948][SQL] Fix NPE for error classes: CANNOT_PARSE_JSON_FIELD
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk closed pull request #39466: [SPARK-41948][SQL] Fix NPE for error classes: CANNOT_PARSE_JSON_FIELD
URL: https://github.com/apache/spark/pull/39466
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #39466: [WIP][SPARK-41948][SQL] Fix NPE for error classes: CANNOT_PARSE_JSON_FIELD
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #39466:
URL: https://github.com/apache/spark/pull/39466#issuecomment-1378728794
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org