[GitHub] [nifi] exceptionfactory commented on a change in pull request #5479: NIFI-9326 Add Socket Keep Alive property to ListenSyslog

[GitBox <gi...@apache.org>]

exceptionfactory commented on a change in pull request #5479:
URL: https://github.com/apache/nifi/pull/5479#discussion_r736582005



##########
File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListenSyslog.java
##########
@@ -183,6 +183,16 @@
         .defaultValue(ClientAuth.REQUIRED.name())
         .dependsOn(SSL_CONTEXT_SERVICE)
         .build();
+    public static final PropertyDescriptor SOCKET_KEEP_ALIVE = new PropertyDescriptor.Builder()
+            .name("socket-keep-alive")
+            .displayName("Socket Keep Alive")
+            .description("Whether or not to have TCP socket keep alive turned on. Timing details depend on operating system properties.")
+            .required(false)
+            .addValidator(StandardValidators.BOOLEAN_VALIDATOR)
+            .allowableValues(Boolean.TRUE.toString(), Boolean.FALSE.toString())
+            .defaultValue(Boolean.FALSE.toString())
+            .dependsOn(PROTOCOL, TCP_VALUE)
+            .build();

Review comment:
       Thanks for the feedback @pvillard31, that makes sense, will make the change to set `required(true)`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org