You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/10/26 20:57:31 UTC
[GitHub] [iceberg] wypoon opened a new pull request, #6063: Spark 3.2: #6041 follow-up/cleanup
wypoon opened a new pull request, #6063:
URL: https://github.com/apache/iceberg/pull/6063
In #6041, I ended up with a slightly different version of `TestSparkReaderDeletes` for v3.2 than in v3.3 because I created the PR before #6026 (the original PR, for v3.3) was merged and I then made some tweaks to `TestSparkReaderDeletes` for #6026. Here I align the version of `TestSparkReaderDeletes` in v3.2 with the version in v3.3. For future backports, it is easier when the 3.2 code base is the same as the 3.3 code base where there is no reason to be different.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] wypoon commented on pull request #6063: Spark 3.2: #6041 follow-up/cleanup
Posted by GitBox <gi...@apache.org>.
wypoon commented on PR #6063:
URL: https://github.com/apache/iceberg/pull/6063#issuecomment-1292769486
@flyrain sorry to trouble you again -- can you please review this? There were some simple improvements to `TestSparkReaderDeletes` in the v3.3 version that are missing from the v3.2 version. It's not a big deal, but would be nice to keep the code the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] flyrain commented on pull request #6063: Spark 3.2: #6041 follow-up/cleanup
Posted by GitBox <gi...@apache.org>.
flyrain commented on PR #6063:
URL: https://github.com/apache/iceberg/pull/6063#issuecomment-1295225620
Merged. Thanks @wypoon!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] wypoon commented on a diff in pull request #6063: Spark 3.2: #6041 follow-up/cleanup
Posted by GitBox <gi...@apache.org>.
wypoon commented on code in PR #6063:
URL: https://github.com/apache/iceberg/pull/6063#discussion_r1007475490
##########
spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkReaderDeletes.java:
##########
@@ -533,55 +534,52 @@ public void testIsDeletedColumnWithoutDeleteFile() {
public void testPosDeletesOnParquetFileWithMultipleRowGroups() throws IOException {
Assume.assumeTrue(format.equals("parquet"));
- String tblName = "test_multiple_row_groups";
+ String tblName = "test3";
Review Comment:
The reason I changed it to `test3` in the original (3.3) PR was that in the base class, the tables were `test` and `test2`, so I used `test3` for this new table to be consistent!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] flyrain merged pull request #6063: Spark 3.2: #6041 follow-up/cleanup
Posted by GitBox <gi...@apache.org>.
flyrain merged PR #6063:
URL: https://github.com/apache/iceberg/pull/6063
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] flyrain commented on a diff in pull request #6063: Spark 3.2: #6041 follow-up/cleanup
Posted by GitBox <gi...@apache.org>.
flyrain commented on code in PR #6063:
URL: https://github.com/apache/iceberg/pull/6063#discussion_r1007421071
##########
spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkReaderDeletes.java:
##########
@@ -533,55 +534,52 @@ public void testIsDeletedColumnWithoutDeleteFile() {
public void testPosDeletesOnParquetFileWithMultipleRowGroups() throws IOException {
Assume.assumeTrue(format.equals("parquet"));
- String tblName = "test_multiple_row_groups";
+ String tblName = "test3";
Review Comment:
Kinda prefer meaningful name, like `table_with_multiple_row_groups`, maybe we can change the 3.3 with a more meaningful name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] flyrain commented on a diff in pull request #6063: Spark 3.2: #6041 follow-up/cleanup
Posted by GitBox <gi...@apache.org>.
flyrain commented on code in PR #6063:
URL: https://github.com/apache/iceberg/pull/6063#discussion_r1007421071
##########
spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkReaderDeletes.java:
##########
@@ -533,55 +534,52 @@ public void testIsDeletedColumnWithoutDeleteFile() {
public void testPosDeletesOnParquetFileWithMultipleRowGroups() throws IOException {
Assume.assumeTrue(format.equals("parquet"));
- String tblName = "test_multiple_row_groups";
+ String tblName = "test3";
Review Comment:
Kinda prefer meaningful name, like `table_with_multiple_row_groups`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org