You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/07/21 16:53:23 UTC

[GitHub] mistercrunch closed pull request #5455: Add week granularity for Clickhouse

mistercrunch closed pull request #5455: Add week granularity for Clickhouse
URL: https://github.com/apache/incubator-superset/pull/5455
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/db_engine_specs.py b/superset/db_engine_specs.py
index 669a505625..97b8095d71 100644
--- a/superset/db_engine_specs.py
+++ b/superset/db_engine_specs.py
@@ -1350,6 +1350,9 @@ class ClickHouseEngineSpec(BaseEngineSpec):
         Grain('day', _('day'),
               'toStartOfDay(toDateTime({col}))',
               'P1D'),
+        Grain('week', _('week'),
+              'toMonday(toDateTime({col}))',
+              'P1W'),
         Grain('month', _('month'),
               'toStartOfMonth(toDateTime({col}))',
               'P1M'),


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org