You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ephraimbuddy (via GitHub)" <gi...@apache.org> on 2023/11/01 13:31:20 UTC
[PR] Remove `require_authentication` decorator from security.py [airflow]
ephraimbuddy opened a new pull request, #35340:
URL: https://github.com/apache/airflow/pull/35340
This decorator was added in #34317, but it seems it's not used anywhere. Opening this PR to see if I'm missing something
cc @vincbeck
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove `require_authentication` decorator from security.py [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on PR #35340:
URL: https://github.com/apache/airflow/pull/35340#issuecomment-1789011409
You can specify multiple authentication strategy for the API. See documentation [here](https://airflow.apache.org/docs/apache-airflow/stable/security/api.html). Example: `auth_backends = airflow.api.auth.backend.default, airflow.api.auth.backend.kerberos_auth`. [This code](https://github.com/apache/airflow/pull/35340/files#diff-86edd78c9ae6d7bd14be12d16870d2c900014027e53295d67f0f1ab80169825fR48) loop through all the API auths you specified in your config through `auth_backends` and then call them. So [this one](https://github.com/apache/airflow/blob/8c25304f047dd77dde6802155a894ce9a15481a8/airflow/auth/managers/fab/api/auth/backend/basic_auth.py#L58) is used whenever a user specify in his config `auth_backends = airflow.auth.managers.fab.api.auth.backend.basic_auth`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove `require_authentication` decorator from security.py [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on PR #35340:
URL: https://github.com/apache/airflow/pull/35340#issuecomment-1789016283
Erratum .... Sorry ... I got confused ... I think you're right, it is safe to remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove `require_authentication` decorator from security.py [airflow]
Posted by "ephraimbuddy (via GitHub)" <gi...@apache.org>.
ephraimbuddy commented on PR #35340:
URL: https://github.com/apache/airflow/pull/35340#issuecomment-1788976190
> It is used [here](https://github.com/apache/airflow/pull/35340/files#diff-86edd78c9ae6d7bd14be12d16870d2c900014027e53295d67f0f1ab80169825fR48) :) I love the try though
What of this: https://github.com/apache/airflow/blob/8c25304f047dd77dde6802155a894ce9a15481a8/airflow/auth/managers/fab/api/auth/backend/basic_auth.py#L58?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove `require_authentication` decorator from security.py [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on PR #35340:
URL: https://github.com/apache/airflow/pull/35340#issuecomment-1788970163
It is used [here](https://github.com/apache/airflow/pull/35340/files#diff-86edd78c9ae6d7bd14be12d16870d2c900014027e53295d67f0f1ab80169825fR48) :) I love the try though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove `require_authentication` decorator from security.py [airflow]
Posted by "ephraimbuddy (via GitHub)" <gi...@apache.org>.
ephraimbuddy merged PR #35340:
URL: https://github.com/apache/airflow/pull/35340
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org