You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/01/17 20:42:49 UTC
[GitHub] brodybits opened a new pull request #625: Update & cleanup
framework/project.properties
brodybits opened a new pull request #625: Update & cleanup framework/project.properties
URL: https://github.com/apache/cordova-android/pull/625
- target SDK version 28
- remove the other properties, which Android Studio reports to be unused properties
- update comments to reflect the actual situation
(in a similar fashion to `bin/templates/project/project.properties`)
triggered by discussion in apache/cordova#69
Rationale:
- value of `target` in `framework/project.properties` is read by the Gradle in <https://github.com/apache/cordova-android/blob/f1f1ac3cbd7e75aa1dfeb6faf856a90335d2197c/framework/cordova.gradle#L30-L40> then subsequently referenced & used directly and indirectly in the following places:
- <https://github.com/apache/cordova-android/blob/f1f1ac3cbd7e75aa1dfeb6faf856a90335d2197c/framework/cordova.gradle#L191>
- <https://github.com/apache/cordova-android/blob/f1f1ac3cbd7e75aa1dfeb6faf856a90335d2197c/framework/build.gradle#L21>
- <https://github.com/apache/cordova-android/blob/f1f1ac3cbd7e75aa1dfeb6faf856a90335d2197c/framework/build.gradle#L48>
- target SDK of the Cordova lib should match the target SDK of the rest of the app, if possible
- When I tried opening the generated project in Android Studio (3.3) and inspecting `platforms/android/CordovaLib/project.properties`, which seems to come from `framework/project.properties`, the editor told me that the other properties were unused. I think the unused properties should be removed for the sake of clarity.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org