You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by PSUdaemon <gi...@git.apache.org> on 2016/09/07 17:16:55 UTC
[GitHub] trafficserver pull request #981: TS-4821: Make hwloc a required dependency
GitHub user PSUdaemon opened a pull request:
https://github.com/apache/trafficserver/pull/981
TS-4821: Make hwloc a required dependency
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PSUdaemon/trafficserver make_hwloc_required
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/981.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #981
----
commit 88cc81274ca5009a8c4114e642c1c9175162daa0
Author: Phil Sorber <so...@apache.org>
Date: 2016-09-07T17:15:59Z
TS-4821: Make hwloc a required dependency
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #981: TS-4821: Make hwloc a required dependency
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/981
FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1271/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #981: TS-4821: Make hwloc a required dependency
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/981
Ubuntu 12 IIRC. But it is a problem with the virtualized hardware not the OS itself.
> On Dec 16, 2016, at 10:07 AM, Phil Sorber <no...@github.com> wrote:
>
> What was the underlying OS?
>
> \u2014
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub, or mute the thread.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #981: TS-4821: Make hwloc a required dependency
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/981
Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/777/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #981: TS-4821: Make hwloc a required dependency
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/981
@PSUdaemon don't forget to update the docs when you land this ... there are sections that talk about dependencies and building from source.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #981: TS-4821: Make hwloc a required dependency
Posted by PSUdaemon <gi...@git.apache.org>.
Github user PSUdaemon commented on the issue:
https://github.com/apache/trafficserver/pull/981
@jpeach can you elaborate on which platform it was that didn't have hwloc? If not, we are going to try to get this in still.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #981: TS-4821: Make hwloc a required dependency
Posted by PSUdaemon <gi...@git.apache.org>.
Github user PSUdaemon commented on the issue:
https://github.com/apache/trafficserver/pull/981
I'll try to rebase this soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #981: TS-4821: Make hwloc a required dependency
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/981
FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/882/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #981: TS-4821: Make hwloc a required dependency
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/981
Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/1166/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #981: TS-4821: Make hwloc a required dependency
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/981#discussion_r77900285
--- Diff: build/hwloc.m4 ---
@@ -0,0 +1,105 @@
+dnl -------------------------------------------------------- -*- autoconf -*-
+dnl Licensed to the Apache Software Foundation (ASF) under one or more
+dnl contributor license agreements. See the NOTICE file distributed with
+dnl this work for additional information regarding copyright ownership.
+dnl The ASF licenses this file to You under the Apache License, Version 2.0
+dnl (the "License"); you may not use this file except in compliance with
+dnl the License. You may obtain a copy of the License at
+dnl
+dnl http://www.apache.org/licenses/LICENSE-2.0
+dnl
+dnl Unless required by applicable law or agreed to in writing, software
+dnl distributed under the License is distributed on an "AS IS" BASIS,
+dnl WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+dnl See the License for the specific language governing permissions and
+dnl limitations under the License.
+
+dnl
+dnl hwloc.m4: Trafficserver's hwloc autoconf macros
+dnl
+
+dnl
+dnl TS_CHECK_HWLOC: look for hwloc libraries and headers
+dnl
+AC_DEFUN([TS_CHECK_HWLOC], [
--- End diff --
Normally the macro would just do the check, taking arguments of what to do if the check succeeded or failed. The caller would be responsible for throwing the error.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #981: TS-4821: Make hwloc a required dependency
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/981
The problem I saw was with hwloc crashing on startup. This was on a Chinese VM hosting service and was caused by hwloc doing a divide by zero. It was unclear what version of hwloc the bug was fixed in. Needless to say this was a bit of a showstopper for running Traffic Server.
> On Dec 16, 2016, at 9:38 AM, Phil Sorber <no...@github.com> wrote:
>
> @jpeach can you elaborate on which platform it was that didn't have hwloc? If not, we are going to try to get this in still.
>
> \u2014
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub, or mute the thread.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #981: TS-4821: Make hwloc a required dependency
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/981
FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/730/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #981: TS-4821: Make hwloc a required dependency
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/981
FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/727/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #981: TS-4821: Make hwloc a required dependency
Posted by PSUdaemon <gi...@git.apache.org>.
Github user PSUdaemon commented on the issue:
https://github.com/apache/trafficserver/pull/981
What was the underlying OS?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #981: TS-4821: Make hwloc a required dependency
Posted by PSUdaemon <gi...@git.apache.org>.
Github user PSUdaemon commented on the issue:
https://github.com/apache/trafficserver/pull/981
@jpeach we should close this, right? You found a case where we can't expect hwloc?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #981: TS-4821: Make hwloc a required dependency
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/981#discussion_r77898778
--- Diff: build/hwloc.m4 ---
@@ -0,0 +1,105 @@
+dnl -------------------------------------------------------- -*- autoconf -*-
+dnl Licensed to the Apache Software Foundation (ASF) under one or more
+dnl contributor license agreements. See the NOTICE file distributed with
+dnl this work for additional information regarding copyright ownership.
+dnl The ASF licenses this file to You under the Apache License, Version 2.0
+dnl (the "License"); you may not use this file except in compliance with
+dnl the License. You may obtain a copy of the License at
+dnl
+dnl http://www.apache.org/licenses/LICENSE-2.0
+dnl
+dnl Unless required by applicable law or agreed to in writing, software
+dnl distributed under the License is distributed on an "AS IS" BASIS,
+dnl WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+dnl See the License for the specific language governing permissions and
+dnl limitations under the License.
+
+dnl
+dnl hwloc.m4: Trafficserver's hwloc autoconf macros
+dnl
+
+dnl
+dnl TS_CHECK_HWLOC: look for hwloc libraries and headers
+dnl
+AC_DEFUN([TS_CHECK_HWLOC], [
+hwloc_path_provided=no
+AC_ARG_WITH(hwloc, [AC_HELP_STRING([--with-hwloc=DIR],[use a specific hwloc library])],
+[
+ if test "x$withval" != "xyes" && test "x$withval" != "x"; then
+ hwloc_base_dir="$withval"
+ if test "$withval" != "no"; then
+ hwloc_path_provided=yes
+ case "$withval" in
+ *":"*)
+ hwloc_include="`echo $withval |sed -e 's/:.*$//'`"
+ hwloc_ldflags="`echo $withval |sed -e 's/^.*://'`"
+ AC_MSG_CHECKING(checking for hwloc includes in $hwloc_include libs in $hwloc_ldflags )
+ ;;
+ *)
+ hwloc_include="$withval/include"
+ hwloc_ldflags="$withval/lib"
+ AC_MSG_CHECKING(checking for hwloc includes in $withval)
+ ;;
+ esac
+ fi
+ fi
+])
+
+if test "x$hwloc_path_provided" = "xno"; then
+ # Use pkg-config, because some distros (*cough* Ubuntu) put hwloc in unusual places.
+ PKG_CHECK_MODULES([HWLOC], [hwloc], [
+ SAVE_LIBS="$LIBS"
+ LIBS="-lhwloc"
+ AC_LANG_PUSH([C++])
+ AC_MSG_CHECKING([for hwloc C++ linking])
+ AC_LINK_IFELSE([
+ AC_LANG_PROGRAM([#include <hwloc.h>],[hwloc_topology_t t; hwloc_topology_init(&t); hwloc_get_type_depth(t, HWLOC_OBJ_SOCKET);])],[
+ AC_SUBST([HWLOC_CFLAGS])
+ AC_SUBST([HWLOC_LIBS])
+ AC_MSG_RESULT([yes])
--- End diff --
You can simplify the ``AC_LINK_IFELSE`` with ``AC_CHECK_LIB``.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #981: TS-4821: Make hwloc a required dependency
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/981
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/626/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #981: TS-4821: Make hwloc a required dependency
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/981
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/623/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---