[jira] [Commented] (CB-12397) .gitignore fix

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-12397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16497215#comment-16497215 ] 

ASF GitHub Bot commented on CB-12397:
-------------------------------------

brodybits commented on issue #8: CB-12397 fix .gitignore for plugins & platforms (cordova-create part)
URL: https://github.com/apache/cordova-create/pull/8#issuecomment-393687159
 
 
   Looking at the code I realized that it will be harder than I had thought before to get this one right. The existing code in `index.js` seems to overwrite some but not all artifacts from cordova-app-hello-world with artifacts from the optional user-provided template. There is also some difference in handling of different artifacts depending on whether or not there is a template subdirectory.
   
   I suspect that this would already be documented to a certain extent, not sure how complete or accurate it really is. I would like to see the documentation updated as well.
   
   Unfortunately I do not have the time to review the existing behavior and documentation due to a critical client deadline, should be able to revisit in 1-2 months or so. My bad for not seeing this before working on #14.
   
   Another thing is that if we switch over to using `_gitignore` in cordova-app-hello-world and user templates this would likely need a major release. We may have a better chance of fixing this issue in a minor release if we continue with a hack such as:
   - use `.npmignore` from cordova-app-hello-world for generated `.gitignore` if no `.gitignore` or `.npmignore` is present in the user-provided template (or there is no user-provided template)
   - in case of user-provided template with `.gitignore` file we use that one
   - we document that we support `.gitignore` but NOT `.npmignore` in user-provided template
   - test to see if we have to make a hack in case NPM renames `.gitignore` in user-provided template (maybe this was already done by @raphinesse)
   
   I will understand if the `.gitignore` problem proves too unwieldy and we have to use `_gitignore` instead (and document it), would still like to avoid the whole `_gitignore` thing if possible.
   
   I will understand if someone else wants to take this one over, would hope to see it done with the kind of testing I had already done for this one and #14.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> .gitignore fix
> --------------
>
>                 Key: CB-12397
>                 URL: https://issues.apache.org/jira/browse/CB-12397
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: cordova-app-hello-world, cordova-cli, cordova-create, cordova-lib
>            Reporter: Chris Brody
>            Priority: Major
>              Labels: backlog, easy-fix
>
> Followup to CB-12008 (autosave by default in cordova@7): if a user creates an app using "cordova create" there should be a .gitignore file to exclude the plugins and platforms artifacts from git.
> I raise this since I have seen way too many apps with outdated plugins / platforms artifacts included in git.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org