You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by zw...@apache.org on 2017/08/17 17:16:22 UTC
[trafficserver] 04/05: Added fallthrough comments for Fedora 26 and
gcc7 for ICP
This is an automated email from the ASF dual-hosted git repository.
zwoop pushed a commit to branch 7.1.x
in repository https://gitbox.apache.org/repos/asf/trafficserver.git
commit 0dee0df42322ebb41ba98ee032b339ee45ee5ba4
Author: Bryan Call <bc...@apache.org>
AuthorDate: Wed Aug 16 15:24:39 2017 -0700
Added fallthrough comments for Fedora 26 and gcc7 for ICP
---
proxy/ICP.cc | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/proxy/ICP.cc b/proxy/ICP.cc
index 0fec8e1..a5a80de 100644
--- a/proxy/ICP.cc
+++ b/proxy/ICP.cc
@@ -549,6 +549,7 @@ ICPPeerReadCont::PeerReadStateMachine(PeerReadData *s, Event *e)
}
}
ink_release_assert(0); // Should never happen
+ // fallthrough
case READ_DATA: {
ink_release_assert(_recursion_depth == 0);
@@ -595,6 +596,7 @@ ICPPeerReadCont::PeerReadStateMachine(PeerReadData *s, Event *e)
}
}
ink_release_assert(0); // Should never happen
+ // fallthrough
case READ_DATA_DONE: {
// Convert ICP message from network to host format
@@ -1183,6 +1185,7 @@ ICPRequestCont::ICPStateMachine(int event, void *d)
}
}
ink_release_assert(0); // should never happen
+ // fallthrough
case ICP_OFF_TERMINATE: {
if (!MUTEX_TAKE_TRY_LOCK_FOR(mutex, this_ethread(), _cont)) {
@@ -1200,6 +1203,7 @@ ICPRequestCont::ICPStateMachine(int event, void *d)
return EVENT_DONE;
}
ink_release_assert(0); // should never happen
+ // fallthrough
case ICP_QUEUE_REQUEST: {
// Place ICP request on the pending request queue
@@ -1271,6 +1275,7 @@ ICPRequestCont::ICPStateMachine(int event, void *d)
return EVENT_DONE;
}
ink_release_assert(0); // should never happen
+ // fallthrough
case ICP_AWAITING_RESPONSE: {
Debug("icp", "[ICP_AWAITING_RESPONSE] Id=%d", _sequence_number);
@@ -1299,6 +1304,7 @@ ICPRequestCont::ICPStateMachine(int event, void *d)
}
}
ink_release_assert(0); // should never happen
+ // fallthrough
case ICP_DEQUEUE_REQUEST: {
// Remove ICP request from active queue
@@ -1310,6 +1316,7 @@ ICPRequestCont::ICPStateMachine(int event, void *d)
break; // move to next_state
}
ink_release_assert(0); // should never happen
+ // fallthrough
case ICP_POST_COMPLETION: {
if (!MUTEX_TAKE_TRY_LOCK_FOR(mutex, this_ethread(), _cont)) {
@@ -1328,6 +1335,7 @@ ICPRequestCont::ICPStateMachine(int event, void *d)
break; // move to next_state
}
ink_release_assert(0); // should never happen
+ // fallthrough
case ICP_WAIT_SEND_COMPLETE: {
// wait for all the sends to complete.
if (npending_actions > 0) {
@@ -1339,6 +1347,7 @@ ICPRequestCont::ICPStateMachine(int event, void *d)
}
} break;
ink_release_assert(0); // should never happen
+ // fallthrough
case ICP_REQUEST_NOT_ACTIVE: {
Debug("icp", "[ICP_REQUEST_NOT_ACTIVE] Id=%d", _sequence_number);
_sequence_number = 0;
@@ -1354,6 +1363,7 @@ ICPRequestCont::ICPStateMachine(int event, void *d)
return EVENT_DONE;
}
ink_release_assert(0); // should never happen
+ // fallthrough
case ICP_DONE:
default:
--
To stop receiving notification emails like this one, please contact
"commits@trafficserver.apache.org" <co...@trafficserver.apache.org>.