[GitHub] [superset] zhaoyongjie commented on a change in pull request #18027: fix(generator): more cleanup to plugin framework

[GitBox <gi...@apache.org>]

zhaoyongjie commented on a change in pull request #18027:
URL: https://github.com/apache/superset/pull/18027#discussion_r784906601



##########
File path: superset-frontend/packages/generator-superset/generators/plugin-chart/templates/package.erb
##########
@@ -1,46 +1,43 @@
 {
-  "name": "superset-plugin-chart-<%= packageName %>",
+  "name": "<%= packageName %>",
   "version": "0.1.0",
-  "description": "Superset Chart - <%= description %>",
+  "description": "<%= description %>",
   "sideEffects": false,
   "main": "lib/index.js",
   "module": "esm/index.js",
   "files": [
     "esm",
     "lib"
   ],
+  "private": true,
   "scripts": {
     "build": "npm run build-cjs && npm run build-esm && npm run ts-types",
     "build-cjs": "babel src --extensions \".ts,.tsx,.js,.jsx\" --copy-files --out-dir lib",
     "build-clean": "npm run clean && npm run build",
     "build-esm": "BABEL_OUTPUT=esm babel src --extensions \".ts,.tsx,.js,.jsx\" --copy-files --out-dir esm",
-    "clean": "rm -rf {lib,esm,tsconfig.tsbuildinfo}",
-    "dev": "webpack --mode=development --color --watch",
+    "dev": "BABEL_OUTPUT=esm babel src --extensions \".ts,.tsx,.js,.jsx\" --watch --copy-files --out-dir esm",
+    "prebuild": "rimraf {lib,esm,tsconfig.tsbuildinfo}",
+    "postbuild": "npm run test",
     "ts-types": "tsc --build",
     "test": "jest"
   },
-  "author": "Superset",
+  "author": "My Name",
   "license": "Apache-2.0",
   "publishConfig": {
     "access": "public"
   },
-  "dependencies": {
-  },
+  "dependencies": {},
   "peerDependencies": {
-    "react": "^16.13.1",
-    "@superset-ui/core": "*",
-    "@superset-ui/chart-controls": "*"
+    "@superset-ui/chart-controls": "^0.18.25",
+    "@superset-ui/core": "^0.18.25",

Review comment:
       Can we use "*" to adapt the  core plugin?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org