You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2022/12/05 12:15:03 UTC
[GitHub] [incubator-brpc] serverglen opened a new pull request, #2041: mbvar support delete_stats and has_stats interface
serverglen opened a new pull request, #2041:
URL: https://github.com/apache/incubator-brpc/pull/2041
### What problem does this PR solve?
Issue Number: #2040
Problem Summary: MultiDimension add delete_stats and has_stats interface
### What is changed and the side effects?
Changed: See Problem Summary
Side effects:
- Performance effects(性能影响): No
- Breaking backward compatibility(向后兼容性): No
---
### Check List:
- Please make sure your changes are compilable(请确保你的更改可以通过编译).
- When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
- Please follow [Contributor Covenant Code of Conduct](../../master/CODE_OF_CONDUCT.md).(请遵循贡献者准则).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] serverglen commented on a diff in pull request #2041: mbvar support delete_stats and has_stats interface
Posted by GitBox <gi...@apache.org>.
serverglen commented on code in PR #2041:
URL: https://github.com/apache/incubator-brpc/pull/2041#discussion_r1040446549
##########
src/bvar/multi_dimension_inl.h:
##########
@@ -204,6 +221,13 @@ T* MultiDimension<T>::get_stats_impl(const key_type& labels_value, STATS_OP stat
return cache_metric;
}
+template <typename T>
+inline
+bool MultiDimension<T>::has_stats(const key_type& labels_value) {
+ auto bvar = get_stats_impl(labels_value);
Review Comment:
thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] cdjingit commented on a diff in pull request #2041: mbvar support delete_stats and has_stats interface
Posted by GitBox <gi...@apache.org>.
cdjingit commented on code in PR #2041:
URL: https://github.com/apache/incubator-brpc/pull/2041#discussion_r1040413369
##########
src/bvar/multi_dimension_inl.h:
##########
@@ -204,6 +221,13 @@ T* MultiDimension<T>::get_stats_impl(const key_type& labels_value, STATS_OP stat
return cache_metric;
}
+template <typename T>
+inline
+bool MultiDimension<T>::has_stats(const key_type& labels_value) {
+ auto bvar = get_stats_impl(labels_value);
Review Comment:
```
return get_stats_impl(labels_value) != nullptr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] cdjingit commented on a diff in pull request #2041: mbvar support delete_stats and has_stats interface
Posted by GitBox <gi...@apache.org>.
cdjingit commented on code in PR #2041:
URL: https://github.com/apache/incubator-brpc/pull/2041#discussion_r1040413369
##########
src/bvar/multi_dimension_inl.h:
##########
@@ -204,6 +221,13 @@ T* MultiDimension<T>::get_stats_impl(const key_type& labels_value, STATS_OP stat
return cache_metric;
}
+template <typename T>
+inline
+bool MultiDimension<T>::has_stats(const key_type& labels_value) {
+ auto bvar = get_stats_impl(labels_value);
Review Comment:
```
get_stats_impl(labels_value) != nullptr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] cdjingit commented on pull request #2041: mbvar support delete_stats and has_stats interface
Posted by GitBox <gi...@apache.org>.
cdjingit commented on PR #2041:
URL: https://github.com/apache/incubator-brpc/pull/2041#issuecomment-1338695222
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm merged pull request #2041: mbvar support delete_stats and has_stats interface
Posted by GitBox <gi...@apache.org>.
wwbmmm merged PR #2041:
URL: https://github.com/apache/incubator-brpc/pull/2041
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org