You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/07/24 03:39:33 UTC

[GitHub] [skywalking] zhaoyuguang opened a new issue #3155: Can SkyWalking-agent set Can-Redefine-Classes and Can-Retransform-Classes is true?

zhaoyuguang opened a new issue #3155: Can SkyWalking-agent set Can-Redefine-Classes and Can-Retransform-Classes is true?
URL: https://github.com/apache/skywalking/issues/3155
 
 
   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
    - [x] Discussion
   
   ___
   ### Discussion
   - Can SkyWalking-agent set Can-Redefine-Classes and Can-Retransform-Classes is true?
   In some cases, the enhancement of SkyWalking will fail;
   The first java agent, he only enhances the original java class, and transform is true.
   The second is SkyWalking-agent, Can-Retransform-Classes is false
   Look at JVMTI  the `Transformations are applied in the following order`
   ![image](https://user-images.githubusercontent.com/10150229/61763021-735ca900-ae06-11e9-9792-d90311ef1ae3.png)
   So the SkyWalking-agent transform will be invalidated.
   So can we open Can-Retransform-Classes?
   What if set Can-Retransform-Classes is true? Is it better to `set true it` with the set `Can-Redefine-Classes` also true?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services