[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #175: [FLINK-28255] Add extraFiles to DataFileMeta

[GitBox <gi...@apache.org>]

JingsongLi commented on code in PR #175:
URL: https://github.com/apache/flink-table-store/pull/175#discussion_r906944640


##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/utils/FileStorePathFactory.java:
##########
@@ -131,27 +129,4 @@ public String getPartitionString(BinaryRowData partition) {
     public String uuid() {
         return uuid;
     }
-
-    /** Cache for storing {@link DataFilePathFactory}s. */
-    public static class DataFilePathFactoryCache {

Review Comment:
   We don't need this cache now, we can just use `pathFactory.bucketPath`.
   Although it will convert the partition to string once at a time. The cost is not large.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org