You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/10/20 10:13:01 UTC
[GitHub] [nifi] timeabarna opened a new pull request, #6558: NIFI-9437 Flowfile Expiration cannot exceed 24 days
timeabarna opened a new pull request, #6558:
URL: https://github.com/apache/nifi/pull/6558
# Summary
[NIFI-9537](https://issues.apache.org/jira/browse/NIFI-9437) enables setting flowfile expiration longer than 24 days.
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [ ] Pull Request based on current revision of the `main` branch
- [ ] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `mvn clean install -P contrib-check`
- [ ] JDK 8
- [ ] JDK 11
- [ ] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] thenatog commented on a diff in pull request #6558: NIFI-9437 Flowfile Expiration cannot exceed 24 days
Posted by GitBox <gi...@apache.org>.
thenatog commented on code in PR #6558:
URL: https://github.com/apache/nifi/pull/6558#discussion_r1002075729
##########
nifi-stateless/nifi-stateless-bundle/nifi-stateless-engine/src/main/java/org/apache/nifi/stateless/queue/StatelessFlowFileQueue.java:
##########
@@ -283,8 +283,8 @@ public String getFlowFileExpiration() {
}
@Override
- public int getFlowFileExpiration(final TimeUnit timeUnit) {
- return (int) timeUnit.convert(expirationMillis, TimeUnit.MILLISECONDS);
+ public long getFlowFileExpiration(final TimeUnit timeUnit) {
+ return timeUnit.convert(expirationMillis, TimeUnit.MILLISECONDS);
Review Comment:
I believe a change also needs to be made to _public void setFlowFileExpiration(final String flowExpirationPeriod)_, as the value on line 292 is still being cast to int.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] timeabarna commented on pull request #6558: NIFI-9437 Flowfile Expiration cannot exceed 24 days
Posted by GitBox <gi...@apache.org>.
timeabarna commented on PR #6558:
URL: https://github.com/apache/nifi/pull/6558#issuecomment-1288826794
Hello @thenatog,
Thank you very much for your review. I hesitated whether flowfile expiration should be corrected as even 24 days seemed too long for stateless NiFI however you are right, let's be consistent. I've modified the code accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] thenatog commented on pull request #6558: NIFI-9437 Flowfile Expiration cannot exceed 24 days
Posted by GitBox <gi...@apache.org>.
thenatog commented on PR #6558:
URL: https://github.com/apache/nifi/pull/6558#issuecomment-1289447736
+1 looks good, will merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] thenatog commented on pull request #6558: NIFI-9437 Flowfile Expiration cannot exceed 24 days
Posted by GitBox <gi...@apache.org>.
thenatog commented on PR #6558:
URL: https://github.com/apache/nifi/pull/6558#issuecomment-1287312504
I tested this out with a unit test in StatelessFlowFileQueue and found that the limit was still 24 days, which seems to be a result of the setFlowFileExpiration() method still casting to int. I also tested the function at runtime still works correctly for small times like 10 seconds. I did not verify that the expiration now works for > 24 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] thenatog closed pull request #6558: NIFI-9437 Flowfile Expiration cannot exceed 24 days
Posted by GitBox <gi...@apache.org>.
thenatog closed pull request #6558: NIFI-9437 Flowfile Expiration cannot exceed 24 days
URL: https://github.com/apache/nifi/pull/6558
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] thenatog commented on pull request #6558: NIFI-9437 Flowfile Expiration cannot exceed 24 days
Posted by GitBox <gi...@apache.org>.
thenatog commented on PR #6558:
URL: https://github.com/apache/nifi/pull/6558#issuecomment-1285815971
Will review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org