[GitHub] [hudi] xushiyan commented on a diff in pull request #6468: [HUDI-4731] Shutdown CloudWatch reporter when query completes

[GitBox <gi...@apache.org>]

xushiyan commented on code in PR #6468:
URL: https://github.com/apache/hudi/pull/6468#discussion_r960218864


##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java:
##########
@@ -208,6 +209,7 @@ public void sync() throws Exception {
           throw ex;
         } finally {
           deltaSyncService.ifPresent(DeltaSyncService::close);
+          Metrics.shutdown();

Review Comment:
   this only works with sync once mode. can we also hook it up with continuous-mode's shutdown callback as well?



##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DefaultSource.scala:
##########
@@ -181,6 +181,7 @@ class DefaultSource extends RelationProvider
       HoodieSparkSqlWriter.bootstrap(sqlContext, mode, optParams, dfWithoutMetaCols)
     } else {
       HoodieSparkSqlWriter.write(sqlContext, mode, optParams, dfWithoutMetaCols)
+      HoodieSparkSqlWriter.cleanup()

Review Comment:
   i think a better place to shutdown metrics is `commitAndPerformPostOperations` in `HoodieSparkSqlWriter`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org